[
https://issues.apache.org/jira/browse/OFBIZ-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042963#comment-17042963 ]
Michael Brohl commented on OFBIZ-8297:
--------------------------------------
[~pierresmits], if you follow the discussion you will see that I reviewed the issue in a constructive way. I explained why the proposed patch is not ready to get committed and you simply didn't even answer or work on it further.
On the other hand you are complaining that patches grow stale and don't get into the codebase. That's what I call obstructive.
What do you expect? That others pick up your unfinished work and work it out until it's ready?
If you want this to be in the codebase, act responsible and work out an acceptable solution. I'll be happy to commit it as I intended in the first place when first reviewing the patch.
> Convert <property-to field functions to tenant-aware solutions
> --------------------------------------------------------------
>
> Key: OFBIZ-8297
> URL:
https://issues.apache.org/jira/browse/OFBIZ-8297> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
> Affects Versions: Trunk
> Reporter: Pierre Smits
> Assignee: Michael Brohl
> Priority: Minor
> Labels: configuration
> Attachments: OFBIZ-8297-AgreementScreens.xml.patch, OFBIZ-8297-AgreementScreens.xml.patch
>
>
> *<property-to-field ...* functions look specifically to content in .property files when it comes to retrieving runtime configuration variables.
> While this flawed approach is most prevalent when working with a multi-tenant setup, where default values of runtime configuration parameters can differ from tenant to tenant, it is also a wrong approach when using OFBiz in controlled production setups.
> When an adopter is required to change the value of a runtime configuration parameter, it is required to go into a code upgrade process instead of changing the value through the admin component (web tools).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
