[jira] [Commented] (OFBIZ-8341) Fix Default or Empty Catch block in Java and Groovy files

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-8341) Fix Default or Empty Catch block in Java and Groovy files

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068225#comment-16068225 ]

Jacques Le Roux commented on OFBIZ-8341:
----------------------------------------

I'll sometimes create subtasks or new Jira issues to differentiate cases that need to be discussed. It would be good for instance for a type of exception and a type of file (service, event, helper/handler/test/etc.) to use and adopt a same type of exception handling.

> Fix Default or Empty Catch block in Java and Groovy files
> ---------------------------------------------------------
>
>                 Key: OFBIZ-8341
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-8341
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>            Reporter: Harsh Vijaywargiya
>            Assignee: Jacques Le Roux
>             Fix For: Upcoming Release
>
>
> In many Java files we have auto generated catch blocks or empty catch blocks.
> To avoid such exception swallowing this should be improved to at least log the error and also return error in case of service.
> As of now I found following classes with such patterns -
> InventoryServices.java
> FreeMarkerWorker.java
> QRCodeEvents.java
> QRCodeServices.java



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)