[jira] [Commented] (OFBIZ-8343) Make data type field length of id fields accept guid ids

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-8343) Make data type field length of id fields accept guid ids

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15814565#comment-15814565 ]

Pierre Smits commented on OFBIZ-8343:
-------------------------------------

There are numerous places throughout OFBiz where id fields can be set manually, just do a simple search on:
* "<auto-fields-entity entity-name="AgreementTerm" default-field-type="edit"/>"
* Id*<text/>

The mere fact of having this decreases the UX as duplication may occur when entering manually or importing existing data through the webtools/import functions, or when migrating from an existing RDBMS solution to a new (RDBMS/newSQL) solution. Also, using a uuid requires less complexities to ensure uniqueness when applied to clustered implementations (multiple OFBiz apps servers combined with HAFO RDBMS solutions, or even newSQL solutions) compared to having sequenced Ids.
With sequenced Id the migration process to a new rdbms (or newSQL) solution of requires a lot more effort than when using uuids.

There are also numerous entities where a sequenced Id is not required per se as the primary Id, e.g.

* the various Type entities
* the various Attribute entities
* JobSandbox
* Visit
* Visitor
* The various entities that require compounded primary key definitions to ensure uniqueness.

Using a sequence num should only be used where it is required by external factors, such as business process or local law (which is mainly for human convenience purposes, e.g invoice numbering). It should have been the exception, is stead of the norm.

Furthermore, why don't you work your own issues (https://issues.apache.org/jira/issues/?jql=project%20%3D%20OFBIZ%20AND%20resolution%20%3D%20Unresolved%20AND%20assignee%20%3D%20lektran%20ORDER%20BY%20priority%20DESC) to successful conclusion first, and then work your way through unassigned issues ()https://issues.apache.org/jira/issues/?jql=project%20%3D%20OFBIZ%20AND%20resolution%20%3D%20Unresolved%20AND%20assignee%20is%20EMPTY%20ORDER%20BY%20priority%20DESC) before you start considering closing issues worked on by others.

> Make data type field length of id fields accept guid ids
> --------------------------------------------------------
>
>                 Key: OFBIZ-8343
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-8343
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Pierre Smits
>         Attachments: OFBIZ-8343-fieldtype-36.patch, OFBIZ-8343-fieldtype.patch
>
>
> Currently the length of id fields is limited to 20 characters. In order for these fields to accept GUIIDs the length should be increased to 32 characters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)