[
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15683125#comment-15683125 ]
Michael Brohl commented on OFBIZ-9123:
--------------------------------------
Maybe I have not expressed myself well enough.
If I got it right, you have added a new component under specialpurpose and I cannot see that it was there before or that it was moved from the applications to specialpurpose. My point is not that you've added a new component but the chosen process of doing so. As far as I can see you created this Jira and immediately committed your work to trunk without any discussion or review before.
In my opinion the process should be:
1. create a Jira with a good description of the contribution, what does it do, why should it be added etc.
2. provide a patch and ask for review
3. review and discussion by the community
4. if the community wants to add the contribution, it can be committed.
Even if we as committers have direct access to the repository, we should still follow the process of contribute - discuss - review - commit as any other contributor.
To be clear, I have not reviewed the contribution yet so I have currently no opinion if we should add it to the repository.
> Add a PriCat component under specialpurpose
> -------------------------------------------
>
> Key: OFBIZ-9123
> URL:
https://issues.apache.org/jira/browse/OFBIZ-9123> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: Trunk
> Reporter: Shi Jinghai
> Assignee: Shi Jinghai
> Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download excel output with errors commented.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
