[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950326#comment-15950326 ]
Jacques Le Roux commented on OFBIZ-9254:
----------------------------------------
Thanks Devanshu,
I have reviewed the Groovy patch and it's OK with me.
Reviewing the Java patch is something else (10+ times more). I was wondering: did you do your changes with the help of a regexp S/R or all by hand? Because I could use a regexp S/R to make the same changes and compares with yours.
> Inconsistent String Comparisons
> -------------------------------
>
> Key: OFBIZ-9254
> URL:
https://issues.apache.org/jira/browse/OFBIZ-9254> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: Trunk
> Reporter: Devanshu Vyas
> Priority: Minor
> Attachments: OFBIZ-9254_groovy.patch, OFBIZ-9254_java.patch
>
>
> I found an inconsistency in the code for string comparison statusId.equals("PRUN_COMPLETED") whereas it should be written as "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
>
http://markmail.org/message/iqfaab3fl3ukxchy--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Locked
