[jira] [Commented] (OFBIZ-9262) Error message when svn updating due to pullAllPluginsSource

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-9262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926345#comment-15926345 ]

Jacques Le Roux commented on OFBIZ-9262:
----------------------------------------

Ok I tried this
{code}
Index: build.gradle
===================================================================
--- build.gradle (revision 1787060)
+++ build.gradle (working copy)
@@ -17,6 +17,7 @@
  * under the License.
  */
 import at.bxm.gradleplugins.svntools.tasks.SvnCheckout
+import at.bxm.gradleplugins.svntools.tasks.SvnUpdate
 import org.apache.tools.ant.filters.ReplaceTokens

 /* ========================================================
@@ -749,10 +750,16 @@

     task pullPluginsFromSvn(type: SvnCheckout) {
         svnUrl = "https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk"
-        workspaceDir = "${rootDir}/temp"
+        delete "${rootDir}/pluginsTemp"
+        workspaceDir = "${rootDir}/pluginsTemp"
         doLast{
             delete "${rootDir}/plugins"
-            ant.move(file: "${rootDir}/temp", toFile: "${rootDir}/plugins")
+            ant.move(file: "${rootDir}/pluginsTemp", toFile: "${rootDir}/plugins")
+            task pullPluginReadmeTxt(type: SvnUpdate) {
+                svnUrl = "https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk/plugins"
+                workspaceDir = "${rootDir}/plugins"
+            }
+            delete "${rootDir}/pluginsTemp"
         }
     }
     dependsOn pullPluginsFromSvn
{code}
But despite
{code}
C:\projectsASF\ofbiz-framework>gradlew pullAllPluginsSource
:pullPluginsFromSvn
:pullAllPluginsSource
:installAllPlugins UP-TO-DATE
BUILD SUCCESSFUL
Total time: 6.115 secs
BUILD SUCCESSFUL
Total time: 1 mins 28.741 secs
C:\projectsASF\ofbiz-framework>
{code}
I'm back to the same situation (ie same error msg here when udpating the whole).
Which makes sens when you think about it. The task pullPluginReadmeTxt is actually updating the new plugins directory which works. And updating the whole from Gradle would result with the same error msg reported here. Not sure if it's possible to handle w/o an externals...

Ah last note, I used pluginsTemp instead of temp because a custom project might use a temp directory and would be surprise to find its files in the plugins directory and possibly deleted later. I also delete pluginsTemp I suppose the name is sufficiently different what we could expect.

> Error message when svn updating due to pullAllPluginsSource
> -----------------------------------------------------------
>
>                 Key: OFBIZ-9262
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9262
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Critical
>             Fix For: Upcoming Release
>
>
> When try to update a ofbiz-framework working copy after having used pullAllPluginsSource, you get an error message "Skipped obstructing working copy".
> This is because we have already a plugins folder in the ofbiz-framework/trunk branch and when we use pullAllPluginsSource we replace it by a new one (plugins folder) and the main .svn gets confused (in root)
> In other words, because of the plugins/README.txt file when you create a working copy from the ofbiz-framework/trunk branch you generate a .svn in root folder where there is a "knowledge" of this file and the plugins directory.
> So, we can't delete the whole plugins directory and replace it by another different plugins directory with the plugins sub-folders inside.
> Morevoer you can't make a chekout (which pullAllPluginsSource currently does) in a non empty folder.
> And If you temporarily move the plugins/README.txt file to get an empty directory you get this error message
> > svn-checkout failed for https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk
> svn: E155000: 'C:\projectsASF\ofbiz-framework\plugins' is already a working copy for a different URL; perform update to complete it.

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)