[jira] [Commented] (OFBIZ-9351) Remove unnecessary field types

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-9351) Remove unnecessary field types

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002281#comment-16002281 ]

Deepak Dixit commented on OFBIZ-9351:
-------------------------------------

If field is define as primary key field so by default is will be set as not-null=true,
so we can replace all the primary key field type from id-ne to id in one shot.

> Remove unnecessary field types
> ------------------------------
>
>                 Key: OFBIZ-9351
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9351
>             Project: OFBiz
>          Issue Type: Task
>            Reporter: Aditya Sharma
>            Assignee: Aditya Sharma
>            Priority: Trivial
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty" field types  ("id-ne", "id-long-ne" and  "id-vlong-ne") were initially added to implement validations on data. But, because the validations where only implemented in some place like webtools, it contradicts the distinction to be upheld on various layers. So it is better to remove these field types. So we will remove all those field types and will create sub tickets to replace them in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by corresponding "id" types we will add a *not-null="true"* attribute to "makes the field NOT NULL on the database (like primary key fields)" as explained in "not-null" documentation in fieldtypemodel.xsd.  We will finally clean the documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)