[
https://issues.apache.org/jira/browse/OFBIZ-9372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027305#comment-16027305 ]
Deepak Dixit commented on OFBIZ-9372:
-------------------------------------
Hi Leila,
I reviewed your patch and it looks good to me, here are some couple of improvement that can be done
- We can use entity-auto for createPartyAcctgPreference service
- Please use != null check for genericValue instead of using UtilValidate method
- We can use EntityConditionBuilder to make the entity condition.
> Convert AcctgAdminServices.xml mini lang to groovy
> --------------------------------------------------
>
> Key: OFBIZ-9372
> URL:
https://issues.apache.org/jira/browse/OFBIZ-9372> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
> Affects Versions: Trunk
> Reporter: Leila Mekika
> Priority: Minor
> Attachments: OFBIZ-9372.patch
>
>
> This is an attempt to migrate AcctgAdminServices.xml to groovy file version.
> The discussion is still running about the automation of the migration and the langage to use for service migration (Java or groovy)
> In both case, maybe this can help migrate it to java or to identify some automatic migration matching patterns.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Locked
