[jira] [Commented] (OFBIZ-9372) Convert AcctgAdminServices.xml mini lang to groovy

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-9372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027411#comment-16027411 ]

Jacques Le Roux commented on OFBIZ-9372:
----------------------------------------

Hi Leila, Deepak,

About
bq. Please use != null check for genericValue instead of using UtilValidate method
Actually you can even follow http://groovy-lang.org/semantics.html#Groovy-Truth. Also for String, etc.
So for instance
bq. while ( UtilValidate.isNotEmpty(currentOrganizationPartyId) && containsEmptyFields) {
can be written
bq. while (currentOrganizationPartyId && containsEmptyFields) {
and
bq. if (UtilValidate.isNotEmpty(currentPartyAcctgPref)) {
bq. if (currentPartyAcctgPref) {
etc. There are plenty of examples in current source.

> Convert AcctgAdminServices.xml mini lang to groovy
> --------------------------------------------------
>
>                 Key: OFBIZ-9372
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9372
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Leila Mekika
>            Priority: Minor
>         Attachments: OFBIZ-9372.patch
>
>
> This is an attempt to migrate AcctgAdminServices.xml to groovy file version.
> The discussion is still running about the automation of the migration and the langage to use for service migration (Java or groovy)
> In both case, maybe this can help migrate it to java or to identify some automatic migration matching patterns.

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)