[
https://issues.apache.org/jira/browse/OFBIZ-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027317#comment-16027317 ]
Nicolas Malin commented on OFBIZ-9381:
--------------------------------------
Hi Deepak, I appreciate your review,
{quote}I think we can use entity-auto for updateRateAmount/deleteRateAmount service, they are belongs to CRUD operation{quote}
I hesitated, to replace it by entity-auto because we have some default value instanciation manageable by defautl-value on the service definition and define seca to manage the pretreatment. Finally I took the choice that it's more readable on groovyDSL but it's also questionable
{quote}Instead of Debug.log we can use Debug.logVerbose to print the newEntity.toMapString(){quote} Oups I forgot to remove it ^^
{quote}I think we can change delete to expire in separate commit{quote} Completely agree, I will do it
{quote}We can use default-value attribute for setting the default value for service in parameter{quote}
I also hesitated, but I will follow your suggest
Thanks Deepak
> Convert RateServices.xml mini-lang to groovyDSL
> -----------------------------------------------
>
> Key: OFBIZ-9381
> URL:
https://issues.apache.org/jira/browse/OFBIZ-9381> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
> Affects Versions: Trunk
> Reporter: Nicolas Malin
> Assignee: Nicolas Malin
> Priority: Minor
> Labels: groovy, mini-lang
> Attachments: OFBIZ-9381.patch, OFBIZ-9381.patch
>
>
> With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some mini-lang service to groovy script.
> I converted updateRateAmount, deleteRateAmount, updatePartyRate and deleteRateAmount.
> Delete isn't a good definition for the service who expire the element instead of remove if. So I propose with the patch to move the deleteRateAmount and deletePartyRate to expireRateAmount and expirePartyRate.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Locked
