[jira] [Commented] (OFBIZ-9405) refactor list related forms in PartyScreen widgets

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255217#comment-16255217 ]

Swapnil M Mane commented on OFBIZ-9405:
---------------------------------------

Dear [~jacques.le.roux],

I think, *Identification Numbers* section under view party profile view (https://localhost:18443/partymgr/control/viewprofile?partyId=DemoCustomer) is broken after this. Here is the console log.
{code}
2017-11-16 17:40:27,149 |sse-nio-18443-exec-4 |ModelScreenWidget             |E| Error rendering included form named [ListPartyIdentification] at location [component://party/widget/partymgr/PartyForms.xml]: java.lang.NullPointerException
java.lang.NullPointerException: null
        at org.apache.ofbiz.widget.model.FormFactory.createModelForm(FormFactory.java:134) ~[ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.FormFactory.createModelForm(FormFactory.java:130) ~[ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.FormFactory.getFormFromLocation(FormFactory.java:71) ~[ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$Form.getModelForm(ModelScreenWidget.java:1067) ~[ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$Form.renderWidgetString(ModelScreenWidget.java:1050) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:688) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:598) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.renderer.macro.MacroScreenRenderer.renderPortalPagePortletBody(MacroScreenRenderer.java:1030) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$PortalPage.renderWidgetString(ModelScreenWidget.java:1981) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:905) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:127) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:942) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSection.renderWidgetString(ModelScreenWidget.java:905) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$SectionsRenderer.render(ModelScreenWidget.java:127) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorSectionInclude.renderWidgetString(ModelScreenWidget.java:942) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:458) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:458) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$Container.renderWidgetString(ModelScreenWidget.java:458) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:779) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:779) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:779) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorScreen.renderWidgetString(ModelScreenWidget.java:859) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorScreen.renderWidgetString(ModelScreenWidget.java:859) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:138) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:100) [ofbiz.jar:?]
        at org.apache.ofbiz.widget.renderer.macro.MacroScreenViewHandler.render(MacroScreenViewHandler.java:122) [ofbiz.jar:?]
        at org.apache.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:999) [ofbiz.jar:?]
        at org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:646) [ofbiz.jar:?]
        at org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212) [ofbiz.jar:?]
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:686) [javax.servlet-api-4.0.0.jar:4.0.0]
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:791) [javax.servlet-api-4.0.0.jar:4.0.0]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231) [tomcat-catalina-8.5.23.jar:8.5.23]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat-catalina-8.5.23.jar:8.5.23]
        at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) [tomcat-embed-websocket-8.5.23.jar:8.5.23]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [tomcat-catalina-8.5.23.jar:8.5.23]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat-catalina-8.5.23.jar:8.5.23]
        at org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:213) [ofbiz.jar:?]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [tomcat-catalina-8.5.23.jar:8.5.23]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat-catalina-8.5.23.jar:8.5.23]
        at org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:157) [ofbiz.jar:?]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [tomcat-catalina-8.5.23.jar:8.5.23]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat-catalina-8.5.23.jar:8.5.23]
        at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:199) [tomcat-catalina-8.5.23.jar:8.5.23]
        at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96) [tomcat-catalina-8.5.23.jar:8.5.23]
        at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478) [tomcat-catalina-8.5.23.jar:8.5.23]
        at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140) [tomcat-catalina-8.5.23.jar:8.5.23]
        at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:81) [tomcat-catalina-8.5.23.jar:8.5.23]
        at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87) [tomcat-catalina-8.5.23.jar:8.5.23]
        at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:650) [tomcat-catalina-8.5.23.jar:8.5.23]
        at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342) [tomcat-catalina-8.5.23.jar:8.5.23]
        at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:803) [tomcat-coyote-8.5.23.jar:8.5.23]
        at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66) [tomcat-coyote-8.5.23.jar:8.5.23]
        at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868) [tomcat-coyote-8.5.23.jar:8.5.23]
        at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1459) [tomcat-coyote-8.5.23.jar:8.5.23]
        at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) [tomcat-coyote-8.5.23.jar:8.5.23]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_66]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_66]
        at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) [tomcat-util-8.5.23.jar:8.5.23]
        at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
2017-11-16 17:40:27,179 |sse-nio-18443-exec-4 |ControlServlet                |E| Error in request handler:
java.lang.RuntimeException: Error rendering included form named [ListPartyIdentification] at location [component://party/widget/partymgr/PartyForms.xml]: java.lang.NullPointerExceptionjava.lang.NullPointerException
{code}

Please let me know if I am missing something.

Thanks,
Swapnil

> refactor list related forms in PartyScreen widgets
> --------------------------------------------------
>
>                 Key: OFBIZ-9405
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9405
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Jacques Le Roux
>              Labels: refactor, widget
>             Fix For: Upcoming Release
>
>         Attachments: OFBIZ-9405-party.patch
>
>
> Refactoring various list forms into grids
> Refactoring various list form references in screens

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)