[jira] [Commented] (OFBIZ-9457) Improvements in OrderHeader entity definition and services

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-9457) Improvements in OrderHeader entity definition and services

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-9457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079146#comment-16079146 ]

Rishi Solanki commented on OFBIZ-9457:
--------------------------------------

[~aishwary]: Your patch looks good to me, thanks for providing patch for the same.

> Improvements in OrderHeader entity definition and services
> ----------------------------------------------------------
>
>                 Key: OFBIZ-9457
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9457
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: Trunk
>            Reporter: Rishi Solanki
>            Priority: Minor
>         Attachments: OFBIZ-9457.diff, OFBIZ-9457.patch
>
>
> Fix entity definition of OrderHeader and do the following changes in the implementation;
> - Remove relations with OrderHeaderNoteView and OrderItemAndShipGroupAssoc from the entity definition.
> - Check for the both views used at any place as getRelated() generic value methods on OrderHeader then change them with appropriate EntityQuery method or delegaor or other script as applicable.
> - Few find areas are;
> -- AddItemsFromOrder.groovy
> -- ReceiveInventoryAgainstPurchaseOrder.groovy
> Note: As we are removing relation from OrderHeader so only need to work on the items where we are trying to get related data by using the relations. We need to rewrite only those lines of code. Reverse in not true.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)