[
https://issues.apache.org/jira/browse/OFBIZ-9551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130192#comment-16130192 ]
Deepak Dixit commented on OFBIZ-9551:
-------------------------------------
Hi [~suraj.khurana],
I reviewed your patch and it looks good to me, we can do some minor changes
- campaignPartyIdCheck simple method should only check the partyId and user login id, we can split the party id check and MARKETING create permission check.
- It should work similar to partyIdPermissionCheck, and instead of writing new method we can call partyIdPermissionCheck to check partyId and userlogin.patryid check.
- You can refer basePlusPartyIdPermissionCheck simple method for more reference.
First check for permission if user done not have permission then check for partyId permission check.
> Convert createMarketingCampaignRole service to entity-auto service
> ------------------------------------------------------------------
>
> Key: OFBIZ-9551
> URL:
https://issues.apache.org/jira/browse/OFBIZ-9551> Project: OFBiz
> Issue Type: Sub-task
> Components: marketing
> Affects Versions: Trunk
> Reporter: Suraj Khurana
> Assignee: Deepak Dixit
> Attachments: OFBIZ-9551.patch
>
>
> Currently, this service is having some permission related code at CampaignServices.xml which is of no use and can be deleted, we can move that code to a separate permission check service that can be used elsewhere as well.
> Also, this pattern is currently used in other areas like Party etc
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Locked
