[jira] [Commented] (OFBIZ-9558) Manage deprecated service on the ModelService

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-9558) Manage deprecated service on the ModelService

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-9558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118311#comment-16118311 ]

Jacques Le Roux commented on OFBIZ-9558:
----------------------------------------

Thanks Nicolas,

I only reviewed (not tested), this sounds quite right to me. Just something I second is Scott's suggestion about using strikethrough in webtools
bq. For webtools, add a strikethrough on the service name in the Service List screen and add the information to the UI in the service definition screen.
Note that [HTML <strike> Tag. is Not Supported in HTML5.|https://www.w3schools.com/tags/tag_strike.asp] but seems still supported by modern browsers

I note that Scott also suggested:
bq.  I think it would be a good idea to replace the attribute definitions on the old service to use the "implements" element which would point to the new service.  It would help keep them aligned with each other for future changes without duplication.

This could be part of a deprecation policy (not only about service but also Java, Groovy, etc.) we don't have yet but for Entities (I checked only in wiki) and could be added with a definitive way as Scott wondered for
bq. (I can't remember the policy for deprecation,  remove after the next release or after two?)



> Manage deprecated service on the ModelService
> ---------------------------------------------
>
>                 Key: OFBIZ-9558
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9558
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>         Attachments: OFBIZ-9558.patch, OFBIZ-9558.patch
>
>
> Following the thread https://lists.apache.org/thread.html/ce4f9899d811208b8ecbc0a6bdc99a47057dfcd354f932a879aa947b@%3Cdev.ofbiz.apache.org%3E on how manage the deprecated service we started on the idea :
> * create a new element deprecated on services.xsd with attribute
> * * use-instead : what service replace the current
> * * since
> * * and content element as reason of the deprecation
> * alert in log warning each call on this service
> * set "@deprecated" on the service List in webtools and inform on detail service page.
> The patch contains this feature



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)