[
https://issues.apache.org/jira/browse/OFBIZ-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125965#comment-16125965 ]
Jacques Le Roux commented on OFBIZ-9572:
----------------------------------------
To be completly clear:
# BigDecimal.ZERO is the real zero constant and should not be changed. That makes no sense.
# But, like in any BigDecimal comparison, values compared to BigDecimal.ZERO must be weighted by using setScale()
# Like I did in OFBIZ-9571 we should not use the setScale() variant with integer but the one with RoundingMode.
I'll now update the description
> Replace all "BigDecimal ZERO" by BigDecimal.ZERO
> ------------------------------------------------
>
> Key: OFBIZ-9572
> URL:
https://issues.apache.org/jira/browse/OFBIZ-9572> Project: OFBiz
> Issue Type: Improvement
> Reporter: Jacques Le Roux
>
> Using "BigDecimal ZERO" instead of BigDecimal.ZERO does not add anything but more useless code. They are both constants and the compiler will made them so.
> This should not be done when setScale() is used on the ZERO constant
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Locked
