[jira] [Commented] (OFBIZ-9603) EntityListIterator Not Closed for Entity [PartyRoleAndContactMechDetail], caught in Finalize

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-9603) EntityListIterator Not Closed for Entity [PartyRoleAndContactMechDetail], caught in Finalize

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722080#comment-16722080 ]

Jacques Le Roux commented on OFBIZ-9603:
----------------------------------------

I found the reason. After fixing OFBIZ-10711 I wondered about this one and found that as much as 3 EntityListIterators are initialised in this page by FindServices::executeFind.

When you use the menu as reported by Aditya only 2 EntityListIterators are initialised with respectively the conditions:

* ((statusId <> 'PARTY_DISABLED' OR statusId IS NULL) AND roleTypeId = 'ACCOUNT')
* ((statusId <> 'PARTY_DISABLED' OR statusId IS NULL) AND roleTypeId = 'LEAD')

Same when you the "Find" button.

If you use the "All Leads" button another EntityListIterator is added to these 2, with the condition

* (partyIdFrom = 'admin' AND (statusId <> 'PARTY_DISABLED' OR statusId IS NULL) AND roleTypeIdTo = 'LEAD' AND partyRelationshipTypeId = 'LEAD_OWNER' AND (partyStatusId <> 'PARTY_DISABLED' OR partyStatusId IS NULL) AND ((thruDate IS NULL OR thruDate > '2018-12-15 10:23:51.373') AND (fromDate IS NULL OR fromDate <= '2018-12-15 10:23:51.373')))

But only one of these EntityListIterators is really used and closed in FormRenderer::renderItemRows when you use one of the functionality. So the others are caught and close in EntityListIterator::finalize.

I see no easy ways to prevent that and see no problems with it since the superfluous EntityListIterators are only initialised not used.

So closing with "Informtation Provided"


> EntityListIterator Not Closed for Entity [PartyRoleAndContactMechDetail], caught in Finalize
> --------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-9603
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9603
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: marketing
>    Affects Versions: Trunk
>            Reporter: Aditya Sharma
>            Priority: Minor
>
> Steps to regenerate issue:
> 1. Go to SFA component (https://localhost:8443/sfa/control/main)
> 2. Click on sub-menu "Leads" (https://localhost:8443/sfa/control/FindLeads)
> Following error in logs:
> {code:java}
> 2017-08-22 08:59:50,496 |Finalizer            |EntityListIterator            |E|
> ==============================================================================
> EntityListIterator Not Closed for Entity [PartyRoleAndContactMechDetail], caught in Finalize
> ==============================================================================
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)