[jira] [Commented] (OFBIZ-9673) CommonEvents improvements

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-9673) CommonEvents improvements

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-9673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151965#comment-16151965 ]

Wai commented on OFBIZ-9673:
----------------------------

I'm deriving from CommonEvents.java and creating a new method that calls CommonEvent.writeJSONtoResponse(). Unfortunately, CommonEvent.writeJSONtoResponse() is private. Hence, I could not compile.  I believe that methods that should not be accessible from other classes should at least allow derived classes to extend it. Hence, changing it to "protected" rather than "private" is more appropriate.


> CommonEvents improvements
> -------------------------
>
>                 Key: OFBIZ-9673
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9673
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Wai
>            Assignee: Jacques Le Roux
>             Fix For: Upcoming Release
>
>         Attachments: OFBIZ-9673.patch
>
>
> replaced private to protected so that CommonEvents.java is more usable to derived classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)