[jira] [Commented] (OFBIZ-9833) Token Based Authentication

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-9833) Token Based Authentication

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206296#comment-16206296 ]

Jacques Le Roux commented on OFBIZ-9833:
----------------------------------------

This afternoon I discussed with [~soledad] about the proposed usage of properties for the JJWT masterSecretKey.

As you may know I'm an old chap :). So in my mind a static final field in Java would be linked when compiling, like for instance in C or C++. But Nicolas was septical on that. And then indeed it occured to me that I was speaking about a language which uses classes with Java bytecode and JIT compilation. So I had a look and found https://docs.oracle.com/javase/tutorial/essential/environment/properties.html where it's clear I was wrong.

Anyway Nicolas suggested rather to use sed and uuidgen to dynamically modify the source file rather than using a properties file. And I think it's a great idea. I'll reflect that in the comment about it in ExternalLoginKeysManager.java and will create a new patch.

> Token Based Authentication
> --------------------------
>
>                 Key: OFBIZ-9833
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9833
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Deepak Dixit
>            Assignee: Deepak Dixit
>         Attachments: JSON Web Tokens.pdf, OFBIZ-9833-external-server-test-example.patch, OFBIZ-9833-external-server.patch, OFBIZ-9833-external-server.patch, Token Based Authentication in Apache OfBiz.pdf, Token Based Authentication.pdf, rfc7519.pdf
>
>
> Here is dev list discussion for token based authentication work:
> http://markmail.org/message/vyskeh2wujqpkbwg



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)