[jira] [Commented] (OFBIZ-9846) Replace Inline js with External js in renderFormClose macro

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491948#comment-16491948 ]

Jacques Le Roux commented on OFBIZ-9846:
----------------------------------------

Hi Aditya,

Actually when you look at [my commit|http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/themes/rainbowstone/template/macro/HtmlMenuMacroLibrary.ftl?r1=1832307&r2=1832306&pathrev=1832307] you will see that I did not add
{code}
+        <#--<#if parameterList?has_content>-->
+            <#--<#list parameterList as parameter>-->
+                <#--<#local params += ",'${parameter.name}': '${parameter.value}'">-->
+            <#--</#list>-->
+        <#--</#if>-->
{code}
which was only in your patch ;)

> Replace Inline js with External js in renderFormClose macro
> -----------------------------------------------------------
>
>                 Key: OFBIZ-9846
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9846
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Trunk
>            Reporter: Aditya Sharma
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-9846.patch
>
>

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)