[jira] [Commented] (OFBIZ-9877) [Refactoring] Package org.apache.ofbiz.accounting.tax

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-9877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293723#comment-16293723 ]

Jacques Le Roux commented on OFBIZ-9877:
----------------------------------------

Hi Julian, Michael, and Ecomify team at large.

Before I again send a message to the dev ML about the Java max line length. I'd like to discuss with you about that. Here I roughly see that you unwrap lines at around 90 for comments and 120 for code. Is that right? Why is so? Do you use small screens on laptop, another reason?

I don't know others now, and don't want to rehash this ad lib. We had already discussions in the past:
http://markmail.org/message/calbmwzd4nj32l4g
http://markmail.org/message/qx3base6tolxfcjf
http://markmail.org/message/t2am3t6eev6zk5bj

To me (and others in above convos) the most important thing is to not arbitrarily cut lines with automated formatter when creating refactoring patch (it could makes sense in formatting patch, but do we really want that?). Again, it's a pain for reviewers. I don't know if others are really reviewing code, but I do. And sincerely, again, if we could avoid formatting while refactoring it would be less painful, for me a least.

And no, formatting is not refactoring! So when you are reviewing a refatoring patch and find mostly formatting stuff you are really spending your time at nothing.

I'm sincerely sorry to be abrupt, but I can't sanely continue to review bursts of patches if we don't find a common solution to this problem. I hope you understand my position, thanks!

IMO Jacopo's point in the 1st convos is the simplest solution to this problem: simply don't format when patching, or at least do that in specific patches but we then need to agree about lines lengths and IMO the longer the better (I use 180 for code and comments, but of course rarely get so far)

> [Refactoring] Package org.apache.ofbiz.accounting.tax
> -----------------------------------------------------
>
>                 Key: OFBIZ-9877
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9877
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Julian Leichert
>            Assignee: Michael Brohl
>            Priority: Minor
>             Fix For: Upcoming Release
>
>         Attachments: OFBIZ-9877_org.apache.ofbiz.accounting.tax.TaxAuthorityServices_refactoring.patch
>
>

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)