[jira] [Commented] (OFBIZ-9911) Add ability to record Return Communication

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298503#comment-16298503 ]

Ratnesh Upadhyay commented on OFBIZ-9911:
-----------------------------------------

*Closure Template:*

This is new feature, now system should be able to record return communication in same way as we are recording it for order communications.

*High Level Technical Summary:*
- Added *CommunicationEventReturn* entity and *CommunicationEventAndReturn* view entity.
- Added *createCommunicationEventReturn* and *removeCommunicationEventReturn* services to create and remove records from aforementioned entity.
- Added required request map and view map in party controller.
- Implemented *FindCommunicationByReturn* screen to wrap find/list communication by return forms.
- Implemented *FindCommunicationByReturn* and *ListCommunicationByReturn* forms to find and list the return communications, used *performFind* service to filter the communication records on various fields.
- Extended party menus with new menu item to navigate over *FindCommunicationByReturn* screen.
- Extended definition of *createCommunicationEventInterface*, *createCommEventFromEmail* and *sendMailInterface* services.
- Added support in *createCommunicationEvent* service to record return communication in *CommunicationEventReturn* entity.
- Extended *sendReturnNotificationScreen* , *createCommEventFromEmail* methods to supply returnId to candidate services.
- Extended *sendMail* service to keep returnId in result and returned it to caller method/service.

*Unit Testing:*
- Created sales order (for DemoCustomer) and ship it, Initiated return from order view page. Now select return items and accept return. Verified that Return Accepted email received and it's recorded in *CommunicationEvent*, *CommunicationEventReturn* entities and populating in *CommunicationEventAndReturn* view.
- Verified *Find Communication By Return* tab started appearing in Party > Communication screen
- Verified *Party > Find Communication*  is intact and working as expected, there is no regression on this screen due to new changes.
- Verified all the eturn communications are listing over *Party > Profile > Communications > Find Communication Screen* by clicking upon *Find* button.
- Verified return communications are filtering based upon supplied *Search Options* like returnId and communicationEventId over *Find Communication By Return* screen.
- Verified create and delete operation are executing successfully from webtools over *CommunicationEventReturn* entity and respective records/changes  are reflecting in *Find Communication By Return* screen.

Apart from this I've also attached updated patch with latest revision and functional and data transition screenshots for quick reference and verification, thanks!

> Add ability to record Return Communication
> ------------------------------------------
>
>                 Key: OFBIZ-9911
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9911
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order, party
>            Reporter: Ratnesh Upadhyay
>            Assignee: Rishi Solanki
>         Attachments: OFBIZ-9911-CommunicationEventReturn-Entity.jpg, OFBIZ-9911-FindCommByReturn-FilterRecords-Screen.jpg, OFBIZ-9911-FindCommunicationByReturn-Screen.jpg, OFBIZ-9911.patch, OFBIZ-9911.patch
>
>
> In OOTB we are having the ability to record order specific communication in CommunicationEventOrder and the user can retrieve/review them from party > communications screen but we don't have such support for return communications. So It would be great to have an ability to record return specific communication in the system.
> We have to implement following items to establish this feature :
> *Data Model Details:*
> - We will have to create new entity CommunicationEventReturn to record return communication. It should have returnId and communicationEventId along with other necessary fields.
> - We have to implement following view CommunicationEventAndReturn to fetch return communications over screens as needed.
> *New Implementation Details:*
> - We have to add CRUD services for the new entity.
> *Existing Implementation Details:*
> - We have to extend createCommunicationEvent service definition with retunId field and extend the existing implementation to create the record in CommunicationEventReturn based on supplied returnId parameter.
> - Also, we have to extend return related email services to provide returnId in service context.
> *User Interface Details:*
> - In the current system we have Party > Communications > Find Communication By Order screen, in the same way, we can add another screen to find communication by return.
> - We can add return communication screenlet over Order Manager > Return > Return History screen or we can add communication tab under Order > Return screen, this is just a thought still thinking on it.
> - We can also provide communication tab in order component as well.
> Thanks to [~jacques.le.roux], [~rishisolankii] and [~deepakddixit] for discussion and inputs.

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)