[
https://issues.apache.org/jira/browse/OFBIZ-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283064#comment-16283064 ]
Jacques Le Roux commented on OFBIZ-9981:
----------------------------------------
Thanks Suraj,
Your modified patch is in trunk at revision: 1817455
I put a toString() in ServiceUtil.returnProblem, Debug.logError() does not work with maps
I also replaced tabs by spaces in QRCodeEvents and put debug info in exceptions
I don't close as there is at least one subtask, I let you decide on this. IMO a main task can be closed and still have sub-tasks pending, but I also find it weird :D
> Handle service response effectively
> -----------------------------------
>
> Key: OFBIZ-9981
> URL:
https://issues.apache.org/jira/browse/OFBIZ-9981> Project: OFBiz
> Issue Type: Improvement
> Reporter: Suraj Khurana
> Assignee: Suraj Khurana
> Attachments: OFBIZ-9981.patch
>
>
> As per discussion on Dev ML:
> ==========================
> Every service calling from java/groovy must handle errors by service util methods such as isError, reutrnError etc. and similarly in case of XML <call-service, there should be <check-error/> to make sure service was executed successfully.
> Apart from this, one suggestion is to include *Debug.logError* in *_ServiceUtil.returnProblem_* so that in case of any error occurred and handled, it will always be logged on the console.
> ==========================
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Locked
