[
https://issues.apache.org/jira/browse/OFBIZ-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307843#comment-16307843 ]
Suraj Khurana commented on OFBIZ-9981:
--------------------------------------
Hi [~jacques.le.roux],
Thank you so much for committing changes.
I agree with you and we can use the pattern you are suggesting. +1 for it.
I also reviewed the changes after you commit and nothing was found critical or major.
Please let me know in case of any other help required in reviewing or testing these changes.
> Handle service response effectively
> -----------------------------------
>
> Key: OFBIZ-9981
> URL:
https://issues.apache.org/jira/browse/OFBIZ-9981> Project: OFBiz
> Issue Type: Improvement
> Reporter: Suraj Khurana
> Assignee: Jacques Le Roux
> Attachments: OFBIZ-9981-MAR-SECEXT-WE.patch, OFBIZ-9981-content.patch, OFBIZ-9981-manufacturing.patch, OFBIZ-9981-order.patch, OFBIZ-9981-party.patch, OFBIZ-9981-plugins.patch, OFBIZ-9981-product.patch, OFBIZ-9981.patch
>
>
> [As per discussion on Dev ML|
http://markmail.org/message/dfriai337uxlx5mo]:
> ==========================
> Every service calling from java/groovy must handle errors by service util methods such as isError, reutrnError etc. and similarly in case of XML <call-service, there should be <check-error/> to make sure service was executed successfully.
> Apart from this, one suggestion is to include *Debug.logError* in *_ServiceUtil.returnProblem_* so that in case of any error occurred and handled, it will always be logged on the console.
> ==========================
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Locked
