[jira] Created: (OFBIZ-1009) Reorganization of PayPalEvents

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551610 ]

Marco Risaliti commented on OFBIZ-1009:
---------------------------------------

Fixed in rev. 604030 in the trunk and it has still to be fixed in release 4.

> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
>                 Key: OFBIZ-1009
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1009
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk, Release Branch 4.0
>         Environment: mac os x
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: PayPal_bug.patch, PayPal_bug2.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551650 ]

Marco Risaliti commented on OFBIZ-1009:
---------------------------------------

I have applied those patch also on www.ofbiz.it and I have configured PayPal and it can be tested on this server using simply a sandbox paypal buyer user.

Thanks
Marco

> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
>                 Key: OFBIZ-1009
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1009
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk, Release Branch 4.0
>         Environment: mac os x
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: PayPal_bug.patch, PayPal_bug2.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551775 ]

Marco Risaliti commented on OFBIZ-1009:
---------------------------------------

Jacques and all committers,

May I can commit the PayPal_bug2.patch into the release 4 ?
I have not the possibility to test it because yesterday when I test on my laptop it was not possible the notify from PayPal with a fixed IP site.
So to test it I need to use it the www.ofbiz.it site.
I think it is a bug fix and it can be included into the release 4.

Thanks
Marco

> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
>                 Key: OFBIZ-1009
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1009
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk, Release Branch 4.0
>         Environment: mac os x
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: PayPal_bug.patch, PayPal_bug2.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti closed OFBIZ-1009.
---------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 4.0

I have committed in rev. 604311 into release 4 and so I now close this issue.

Thanks
Marco

> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
>                 Key: OFBIZ-1009
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1009
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk, Release Branch 4.0
>         Environment: mac os x
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: PayPal_bug.patch, PayPal_bug2.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552214 ]

Jacques Le Roux commented on OFBIZ-1009:
----------------------------------------

Marco,

Sorry I did no answer to your demands above. If you need some help tp revert from release to reapply without links to HWM server  feel free to ask.

> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
>                 Key: OFBIZ-1009
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1009
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk, Release Branch 4.0
>         Environment: mac os x
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: PayPal_bug.patch, PayPal_bug2.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.