[jira] [Created] (OFBIZ-10247) Resolve address from InvoiceWorker not respect the invoice date

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (OFBIZ-10247) Resolve address from InvoiceWorker not respect the invoice date

Nicolas Malin (Jira)
Nicolas Malin created OFBIZ-10247:
-------------------------------------

             Summary: Resolve address from InvoiceWorker not respect the invoice date
                 Key: OFBIZ-10247
                 URL: https://issues.apache.org/jira/browse/OFBIZ-10247
             Project: OFBiz
          Issue Type: Bug
          Components: accounting
    Affects Versions: Trunk
            Reporter: Nicolas Malin


When you edit an invoice pdf, the different addresses are resolved by the InvoiceWorker with the method getInvoiceAddressByType.
{code:java}
public static GenericValue getInvoiceAddressByType(GenericValue invoice, String contactMechPurposeTypeId, boolean fetchPartyAddress) {{code}
This method check first on the InvoiceContactMech table and if no address found, check directly on the party with a filter date to now.
{code:java}
try {
locations = invoice.getRelated("InvoiceContactMech", UtilMisc.toMap("contactMechPurposeTypeId", contactMechPurposeTypeId), null, false);
} catch (GenericEntityException e) {
Debug.logError("Touble getting InvoiceContactMech entity list", module);
}

if (UtilValidate.isEmpty(locations) && fetchPartyAddress) {
// if no locations found get it from the PartyAndContactMech using the from and to party on the invoice
...
locations = EntityUtil.filterByDate(locations, date, "contactFromDate", "contactThruDate", true);

{code}
If you edit the invoice pdf one year after, addresses present on it can be change because the invoice date isn't use to resolve validate address related.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)