[jira] Created: (OFBIZ-1045) EntityOperator does not correctly construct SQL for BETWEEN clause

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632820#action_12632820 ]

Jacques Le Roux commented on OFBIZ-1045:
----------------------------------------

Hopefully Adam will have a look. Else I will but later, please be patient...

> EntityOperator does not correctly construct SQL for BETWEEN clause
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-1045
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1045
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: ubuntu 7.04, postgres 8.2, working with SVN release 4955, but EntityOperator.java has not changed since then. fix for vesion 694561
>            Reporter: Luke Prentice
>            Assignee: Adam Heath
>         Attachments: EntityOperator-r694561.patch
>
>
> when using the BETWEEN EntityOperator the SQL produced is incorrectly formatted:
> ... field1 BETWEEN (value1, value2)
> it should be
> ... field1 BETWEEN value1 AND value2
> this produces an SQL parse exception.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643070#action_12643070 ]

Jacques Le Roux commented on OFBIZ-1045:
----------------------------------------

I'm looking at this but it's not yet completly clear to me...

> EntityOperator does not correctly construct SQL for BETWEEN clause
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-1045
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1045
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: ubuntu 7.04, postgres 8.2, working with SVN release 4955, but EntityOperator.java has not changed since then. fix for vesion 694561
>            Reporter: Luke Prentice
>            Assignee: Adam Heath
>         Attachments: EntityOperator-r694561.patch
>
>
> when using the BETWEEN EntityOperator the SQL produced is incorrectly formatted:
> ... field1 BETWEEN (value1, value2)
> it should be
> ... field1 BETWEEN value1 AND value2
> this produces an SQL parse exception.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643086#action_12643086 ]

Luke Prentice commented on OFBIZ-1045:
--------------------------------------

jacques, what's not clear to you?

a problem has been identified, and a patch supplied to fix the SQL incorrect syntax when using the "BETWEEN" operator.

> EntityOperator does not correctly construct SQL for BETWEEN clause
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-1045
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1045
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: ubuntu 7.04, postgres 8.2, working with SVN release 4955, but EntityOperator.java has not changed since then. fix for vesion 694561
>            Reporter: Luke Prentice
>            Assignee: Adam Heath
>         Attachments: EntityOperator-r694561.patch
>
>
> when using the BETWEEN EntityOperator the SQL produced is incorrectly formatted:
> ... field1 BETWEEN (value1, value2)
> it should be
> ... field1 BETWEEN value1 AND value2
> this produces an SQL parse exception.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643996#action_12643996 ]

Jacques Le Roux commented on OFBIZ-1045:
----------------------------------------

Luke,

Why did you not fix the "IN" and "NOT-LIKE" ? Is there not the same problems for them (ie did you test them) ?
Also a written example of use would make things easier.

Thanks

> EntityOperator does not correctly construct SQL for BETWEEN clause
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-1045
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1045
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: ubuntu 7.04, postgres 8.2, working with SVN release 4955, but EntityOperator.java has not changed since then. fix for vesion 694561
>            Reporter: Luke Prentice
>            Assignee: Adam Heath
>         Attachments: EntityOperator-r694561.patch
>
>
> when using the BETWEEN EntityOperator the SQL produced is incorrectly formatted:
> ... field1 BETWEEN (value1, value2)
> it should be
> ... field1 BETWEEN value1 AND value2
> this produces an SQL parse exception.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-1045:
--------------------------------------

    Assignee: Jacques Le Roux  (was: Adam Heath)

> EntityOperator does not correctly construct SQL for BETWEEN clause
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-1045
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1045
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: ubuntu 7.04, postgres 8.2, working with SVN release 4955, but EntityOperator.java has not changed since then. fix for vesion 694561
>            Reporter: Luke Prentice
>            Assignee: Jacques Le Roux
>         Attachments: EntityOperator-r694561.patch
>
>
> when using the BETWEEN EntityOperator the SQL produced is incorrectly formatted:
> ... field1 BETWEEN (value1, value2)
> it should be
> ... field1 BETWEEN value1 AND value2
> this produces an SQL parse exception.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1045.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 4.0
                   SVN trunk

Thanks Luke,

Your patch is in OFBiz tunk revision: 721887, release4.0 721892  

I have also made a modification for widget action in trunk r721839, R4 r721893  

> EntityOperator does not correctly construct SQL for BETWEEN clause
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-1045
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1045
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: ubuntu 7.04, postgres 8.2, working with SVN release 4955, but EntityOperator.java has not changed since then. fix for vesion 694561
>            Reporter: Luke Prentice
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: EntityOperator-r694561.patch
>
>
> when using the BETWEEN EntityOperator the SQL produced is incorrectly formatted:
> ... field1 BETWEEN (value1, value2)
> it should be
> ... field1 BETWEEN value1 AND value2
> this produces an SQL parse exception.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651873#action_12651873 ]

Jacques Le Roux commented on OFBIZ-1045:
----------------------------------------

Luke,

I forgot your remark about call to makeRHSWhereStringValue() in EntityOperator.java  "IN"'s, done in trun r721904, R4 r721905  

> EntityOperator does not correctly construct SQL for BETWEEN clause
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-1045
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1045
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: ubuntu 7.04, postgres 8.2, working with SVN release 4955, but EntityOperator.java has not changed since then. fix for vesion 694561
>            Reporter: Luke Prentice
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: EntityOperator-r694561.patch
>
>
> when using the BETWEEN EntityOperator the SQL produced is incorrectly formatted:
> ... field1 BETWEEN (value1, value2)
> it should be
> ... field1 BETWEEN value1 AND value2
> this produces an SQL parse exception.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.