[jira] Created: (OFBIZ-1054) Filtering expired emails in sendEmailToContactList method

[Nicolas Malin (Jira)]

Filtering expired emails in sendEmailToContactList method
---------------------------------------------------------

                 Key: OFBIZ-1054
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1054
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: marketing
    Affects Versions: SVN trunk, Release Branch 4.0
            Reporter: Bilgin Ibryam
             Fix For: SVN trunk, Release Branch 4.0


Hi all,
If you create a contact list with 'Contact Mechanism Type = email address' and then create comm events (ie send email to parties in the Contact list), you will see that the emails are sent to all parties in the contact list, even to the expired email addresses.
With the attached patch the expired emails (PartyContactMech) are filtered.
regards,
-Bilgin

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1054:
---------------------------------

    Attachment: filter.patch

Patch for filtering expired emails

> Filtering expired emails in sendEmailToContactList method
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1054
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1054
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: marketing
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Bilgin Ibryam
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: filter.patch
>
>
> Hi all,
> If you create a contact list with 'Contact Mechanism Type = email address' and then create comm events (ie send email to parties in the Contact list), you will see that the emails are sent to all parties in the contact list, even to the expired email addresses.
> With the attached patch the expired emails (PartyContactMech) are filtered.
> regards,
> -Bilgin

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501886 ]

Ray Barlow commented on OFBIZ-1054:
-----------------------------------

I've not tested so not committed, but the patch looks OK.

It did lead me to think that we should probably create a new Jira issue to implement an improvement that will update contact lists with updated emails. For example if Mr Smith is registered with your newsletter and he changes his email address unless he specifically updates his subscription he won't receive any more newsletter emails.

> Filtering expired emails in sendEmailToContactList method
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1054
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1054
>             Project: OFBiz
>          Issue Type: Bug
>          Components: marketing
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Bilgin Ibryam
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: filter.patch
>
>
> Hi all,
> If you create a contact list with 'Contact Mechanism Type = email address' and then create comm events (ie send email to parties in the Contact list), you will see that the emails are sent to all parties in the contact list, even to the expired email addresses.
> With the attached patch the expired emails (PartyContactMech) are filtered.
> regards,
> -Bilgin

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502308 ]

Bilgin Ibryam commented on OFBIZ-1054:
--------------------------------------

If mr Smith updates his existing email, he will continue to receive the newsletters in the updates email address. If he expire the email we should remove it from list (with my patch). And if he adds a new email and after some time decide to recive newsletters again he can again add his email to contact list. I cannot see a need for new jira at this point.
regards,
- Bilgin

> Filtering expired emails in sendEmailToContactList method
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1054
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1054
>             Project: OFBiz
>          Issue Type: Bug
>          Components: marketing
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Bilgin Ibryam
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: filter.patch
>
>
> Hi all,
> If you create a contact list with 'Contact Mechanism Type = email address' and then create comm events (ie send email to parties in the Contact list), you will see that the emails are sent to all parties in the contact list, even to the expired email addresses.
> With the attached patch the expired emails (PartyContactMech) are filtered.
> regards,
> -Bilgin

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502325 ]

Ray Barlow commented on OFBIZ-1054:
-----------------------------------

In OFBiz you will find that ContactMech details are generally (if not always) immutable. Therefore the action of updating your email address actually expires the existing and creates a new one, try it and then click on the "Show old" link and you'll see more than one email contact entry.

Your patch, which I'm sure will get applied as it makes perfect sense, will show the problem very clearly once you update an email address already associated to a contact list the user will no longer get the newsletter. The contact list will remain associated with the old expired contactMechId as no code has relinked it, so it needs to be manually updated, hence the need for a jira issue to help the process.

Hope that makes sense,

Ray

> Filtering expired emails in sendEmailToContactList method
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1054
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1054
>             Project: OFBiz
>          Issue Type: Bug
>          Components: marketing
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Bilgin Ibryam
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: filter.patch
>
>
> Hi all,
> If you create a contact list with 'Contact Mechanism Type = email address' and then create comm events (ie send email to parties in the Contact list), you will see that the emails are sent to all parties in the contact list, even to the expired email addresses.
> With the attached patch the expired emails (PartyContactMech) are filtered.
> regards,
> -Bilgin

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503315 ]

Bilgin Ibryam commented on OFBIZ-1054:
--------------------------------------

Ray, i checked the code and yuo are right. I will create a new Jira issue to implement an improvement that will update contact lists with updated emails.  Do you have any idea how could it be done ? May be with ECA rules ? Please give some ideas.
Thanks,
Bilgin

> Filtering expired emails in sendEmailToContactList method
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1054
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1054
>             Project: OFBiz
>          Issue Type: Bug
>          Components: marketing
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Bilgin Ibryam
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: filter.patch
>
>
> Hi all,
> If you create a contact list with 'Contact Mechanism Type = email address' and then create comm events (ie send email to parties in the Contact list), you will see that the emails are sent to all parties in the contact list, even to the expired email addresses.
> With the attached patch the expired emails (PartyContactMech) are filtered.
> regards,
> -Bilgin

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1054.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Bilgin,

Your patch is in trunk revision 554250  release 4.0 554252

> Filtering expired emails in sendEmailToContactList method
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1054
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1054
>             Project: OFBiz
>          Issue Type: Bug
>          Components: marketing
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Bilgin Ibryam
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: filter.patch
>
>
> Hi all,
> If you create a contact list with 'Contact Mechanism Type = email address' and then create comm events (ie send email to parties in the Contact list), you will see that the emails are sent to all parties in the contact list, even to the expired email addresses.
> With the attached patch the expired emails (PartyContactMech) are filtered.
> regards,
> -Bilgin

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.