Workeffort Calendar has bugs
---------------------------- Key: OFBIZ-1069 URL: https://issues.apache.org/jira/browse/OFBIZ-1069 Project: OFBiz Issue Type: Bug Components: workeffort Reporter: Adrian Crum Priority: Minor The Workeffort calendar does not accomodate DST, so March and November are not calculated correctly - https://demo.hotwaxmedia.com/workeffort/control/month?start=1193979600000 Also, the "Day" screenlet header seems to ignore the currently selected locale - https://demo.hotwaxmedia.com/workeffort/control/day -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[ https://issues.apache.org/jira/browse/OFBIZ-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502417 ] Adrian Crum commented on OFBIZ-1069: ------------------------------------ The DST bug is caused by a combination of the workeffort getCalendarEventsByPeriod method and the bsh scripts that call it. The fix is to use the java.util.Calendar class to compute periods instead of calculating seconds elaspsed in a period. I'll create a patch in a few days if someone else doesn't get to it first. > Workeffort Calendar has bugs > ---------------------------- > > Key: OFBIZ-1069 > URL: https://issues.apache.org/jira/browse/OFBIZ-1069 > Project: OFBiz > Issue Type: Bug > Components: workeffort > Reporter: Adrian Crum > Priority: Minor > > The Workeffort calendar does not accomodate DST, so March and November are not calculated correctly - > https://demo.hotwaxmedia.com/workeffort/control/month?start=1193979600000 > Also, the "Day" screenlet header seems to ignore the currently selected locale - > https://demo.hotwaxmedia.com/workeffort/control/day -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502449 ] Adrian Crum commented on OFBIZ-1069: ------------------------------------ The correct method name for the DST bug is getWorkEffortEventsByPeriod in WorkEffortServices.java. > Workeffort Calendar has bugs > ---------------------------- > > Key: OFBIZ-1069 > URL: https://issues.apache.org/jira/browse/OFBIZ-1069 > Project: OFBiz > Issue Type: Bug > Components: workeffort > Reporter: Adrian Crum > Priority: Minor > > The Workeffort calendar does not accomodate DST, so March and November are not calculated correctly - > https://demo.hotwaxmedia.com/workeffort/control/month?start=1193979600000 > Also, the "Day" screenlet header seems to ignore the currently selected locale - > https://demo.hotwaxmedia.com/workeffort/control/day -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-1069: ------------------------------- Attachment: workeffort.patch Attached patch fixes the bug. This patch and the new UtilDateTime.java should be applied to the Release 4 branch also. > Workeffort Calendar has bugs > ---------------------------- > > Key: OFBIZ-1069 > URL: https://issues.apache.org/jira/browse/OFBIZ-1069 > Project: OFBiz > Issue Type: Bug > Components: workeffort > Reporter: Adrian Crum > Priority: Minor > Attachments: workeffort.patch > > > The Workeffort calendar does not accomodate DST, so March and November are not calculated correctly - > https://demo.hotwaxmedia.com/workeffort/control/month?start=1193979600000 > Also, the "Day" screenlet header seems to ignore the currently selected locale - > https://demo.hotwaxmedia.com/workeffort/control/day -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-1069: ---------------------------------------- Assignee: Jacopo Cappellato > Workeffort Calendar has bugs > ---------------------------- > > Key: OFBIZ-1069 > URL: https://issues.apache.org/jira/browse/OFBIZ-1069 > Project: OFBiz > Issue Type: Bug > Components: workeffort > Reporter: Adrian Crum > Assignee: Jacopo Cappellato > Priority: Minor > Attachments: workeffort.patch > > > The Workeffort calendar does not accomodate DST, so March and November are not calculated correctly - > https://demo.hotwaxmedia.com/workeffort/control/month?start=1193979600000 > Also, the "Day" screenlet header seems to ignore the currently selected locale - > https://demo.hotwaxmedia.com/workeffort/control/day -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-1069: ---------------------------------- Assignee: Adrian Crum (was: Jacopo Cappellato) > Workeffort Calendar has bugs > ---------------------------- > > Key: OFBIZ-1069 > URL: https://issues.apache.org/jira/browse/OFBIZ-1069 > Project: OFBiz > Issue Type: Bug > Components: workeffort > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: workeffort.patch > > > The Workeffort calendar does not accomodate DST, so March and November are not calculated correctly - > https://demo.hotwaxmedia.com/workeffort/control/month?start=1193979600000 > Also, the "Day" screenlet header seems to ignore the currently selected locale - > https://demo.hotwaxmedia.com/workeffort/control/day -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum resolved OFBIZ-1069. -------------------------------- Resolution: Fixed Revision 548384 . > Workeffort Calendar has bugs > ---------------------------- > > Key: OFBIZ-1069 > URL: https://issues.apache.org/jira/browse/OFBIZ-1069 > Project: OFBiz > Issue Type: Bug > Components: workeffort > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: workeffort.patch > > > The Workeffort calendar does not accomodate DST, so March and November are not calculated correctly - > https://demo.hotwaxmedia.com/workeffort/control/month?start=1193979600000 > Also, the "Day" screenlet header seems to ignore the currently selected locale - > https://demo.hotwaxmedia.com/workeffort/control/day -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-1069. ------------------------------------ > Workeffort Calendar has bugs > ---------------------------- > > Key: OFBIZ-1069 > URL: https://issues.apache.org/jira/browse/OFBIZ-1069 > Project: OFBiz > Issue Type: Bug > Components: workeffort > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: workeffort.patch > > > The Workeffort calendar does not accomodate DST, so March and November are not calculated correctly - > https://demo.hotwaxmedia.com/workeffort/control/month?start=1193979600000 > Also, the "Day" screenlet header seems to ignore the currently selected locale - > https://demo.hotwaxmedia.com/workeffort/control/day -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Free forum by Nabble | Edit this page |