[jira] Created: (OFBIZ-1109) Ability to add items with modifiers

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
30 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549775 ]

Jacques Le Roux commented on OFBIZ-1109:
----------------------------------------

Actually the only weird thing is the price of the unconfigured product and I agree that we should better show the price of the default configuration. I never occured to me that there was a problem here has I saw the $ 50 as the price without any options. But as it's something you can't reasonnably buy (like a car without tyres or something) showing the default configuration price should be good. Mmmm... I remember now that you have opened an issue to allow a default configuration, I understand why now :o)

> Ability to add items with modifiers
> -----------------------------------
>
>                 Key: OFBIZ-1109
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1109
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>         Attachments: 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.  
> A few scenarios should be supported.
> 1.  The item has a default configuration and can be added without configuration.
> 2.  The item requires configuration and a screen to configure the item should present upon adding the item.
> 3.  A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1.  Is anyone else interested in this functionality?
> 2.  What does everyone think is the best way to accomplish this?
> Thanks!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549799 ]

Chris Lombardi commented on OFBIZ-1109:
---------------------------------------

Yes, it's ofbiz-1495.  I was planning on taking care of it, I just like to give everyone a few days for comments before I start.  I'll put you down as a vote for the fix as proposed.

Yeah, having the default configuration, IMHO, is nice.  That combined with the default base price is going to go a long way towards better clarity with this patch.  I'll have to go through this patch again in light of ofbiz-1393 and ofbiz-1495.

> Ability to add items with modifiers
> -----------------------------------
>
>                 Key: OFBIZ-1109
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1109
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>         Attachments: 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.  
> A few scenarios should be supported.
> 1.  The item has a default configuration and can be added without configuration.
> 2.  The item requires configuration and a screen to configure the item should present upon adding the item.
> 3.  A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1.  Is anyone else interested in this functionality?
> 2.  What does everyone think is the best way to accomplish this?
> Thanks!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552072 ]

Jacques Le Roux commented on OFBIZ-1109:
----------------------------------------

Has I worked on the POS today, I suggest other minor improvements to this patch :

Windows titles are still "Load a sale"
Cancel buttons are missing (we need big buttons because of touch screen)
Please use a new color in the Main POS windows for the "Config PC" button

Thanks

> Ability to add items with modifiers
> -----------------------------------
>
>                 Key: OFBIZ-1109
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1109
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>         Attachments: 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.  
> A few scenarios should be supported.
> 1.  The item has a default configuration and can be added without configuration.
> 2.  The item requires configuration and a screen to configure the item should present upon adding the item.
> 3.  A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1.  Is anyone else interested in this functionality?
> 2.  What does everyone think is the best way to accomplish this?
> Thanks!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1109) Ability to add items with modifiers

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Lombardi updated OFBIZ-1109:
----------------------------------

    Attachment: 16Dec2007.patch

Window title changed from "Load a sale"
New color used for "Config PC".  I tried to keep it the same shade as the other colors.

> Ability to add items with modifiers
> -----------------------------------
>
>                 Key: OFBIZ-1109
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1109
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>         Attachments: 16Dec2007.patch, 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.  
> A few scenarios should be supported.
> 1.  The item has a default configuration and can be added without configuration.
> 2.  The item requires configuration and a screen to configure the item should present upon adding the item.
> 3.  A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1.  Is anyone else interested in this functionality?
> 2.  What does everyone think is the best way to accomplish this?
> Thanks!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552310 ]

Chris Lombardi commented on OFBIZ-1109:
---------------------------------------

I originally had a "cancel" button, but I ended up removing it.  It makes sense from a general purpose program standpoint, but I wasn't sure a "cancel" button made sense in the context of a POS.

What is the expected action of a "cancel"?  Would it be to void the item?  There is already a "reset" to cancel the configuration changes and reset to the default configuration.  You can also hit "ok" and then hit the "void item" button.  I didn't want to introduce a way to inadvertently void a bunch of items, etc.

Let me know what you think.




> Ability to add items with modifiers
> -----------------------------------
>
>                 Key: OFBIZ-1109
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1109
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>         Attachments: 16Dec2007.patch, 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.  
> A few scenarios should be supported.
> 1.  The item has a default configuration and can be added without configuration.
> 2.  The item requires configuration and a screen to configure the item should present upon adding the item.
> 3.  A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1.  Is anyone else interested in this functionality?
> 2.  What does everyone think is the best way to accomplish this?
> Thanks!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552347 ]

Jacques Le Roux commented on OFBIZ-1109:
----------------------------------------

Chris,

Just as a side note for patches name. For a commiter who have more than one patch testing at a time, it's easier to have a patch name saying something to him. For instance config-pc-pos.patch would be easier here. Don't worry about versions, Jira is able to take the same name and will grey the previous versions.

For the cancel button, I used one in load and save sale. I think that now everybody is used to the cancel concept on a PC.
Maybe in the context of config we could use a different name (Main screen, back, ... ?).

> Ability to add items with modifiers
> -----------------------------------
>
>                 Key: OFBIZ-1109
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1109
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>         Attachments: 16Dec2007.patch, 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.  
> A few scenarios should be supported.
> 1.  The item has a default configuration and can be added without configuration.
> 2.  The item requires configuration and a screen to configure the item should present upon adding the item.
> 3.  A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1.  Is anyone else interested in this functionality?
> 2.  What does everyone think is the best way to accomplish this?
> Thanks!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552354 ]

Jacques Le Roux commented on OFBIZ-1109:
----------------------------------------

Chris, do you think this patch is ready to be commited or should we wait OFBIZ-1495 ?

> Ability to add items with modifiers
> -----------------------------------
>
>                 Key: OFBIZ-1109
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1109
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>         Attachments: 16Dec2007.patch, 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.  
> A few scenarios should be supported.
> 1.  The item has a default configuration and can be added without configuration.
> 2.  The item requires configuration and a screen to configure the item should present upon adding the item.
> 3.  A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1.  Is anyone else interested in this functionality?
> 2.  What does everyone think is the best way to accomplish this?
> Thanks!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552465 ]

Chris Lombardi commented on OFBIZ-1109:
---------------------------------------

I think the core is solid enough for a commit.  I'll open up new issues for the receipt, cancel button, etc.  Thanks.

> Ability to add items with modifiers
> -----------------------------------
>
>                 Key: OFBIZ-1109
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1109
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>         Attachments: 16Dec2007.patch, 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.  
> A few scenarios should be supported.
> 1.  The item has a default configuration and can be added without configuration.
> 2.  The item requires configuration and a screen to configure the item should present upon adding the item.
> 3.  A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1.  Is anyone else interested in this functionality?
> 2.  What does everyone think is the best way to accomplish this?
> Thanks!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-1109) Ability to add items with modifiers

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1109.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

> Ability to add items with modifiers
> -----------------------------------
>
>                 Key: OFBIZ-1109
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1109
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: 16Dec2007.patch, 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.  
> A few scenarios should be supported.
> 1.  The item has a default configuration and can be added without configuration.
> 2.  The item requires configuration and a screen to configure the item should present upon adding the item.
> 3.  A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1.  Is anyone else interested in this functionality?
> 2.  What does everyone think is the best way to accomplish this?
> Thanks!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552526 ]

Jacques Le Roux commented on OFBIZ-1109:
----------------------------------------

Thanks Chris,

Your patch is in trunk revision: 604993. Some advices, questions and remarks :

Please don't add xpos.properties in your patches. As you may know this file is dynamically modified by the system to allow XUI localisation. About this subject I have added the following lines
    ### This file contains labels directly translated by XUI framework
    ### This file contains labels translated by the POS component (ie not by XUI framework)
in respectively XuiUilabels*.properties files and pos*.properties file to make things more obvious.

Should we keep PosTransaction.configureItem commented ?

Please update or remove code comments, for instance the one I already noticed in a comment above

I commented some remaining Debug.logInfo in ConfigureItem feel free to uncomment if you feel they are needed.

Thanks for your great work, I love the color !






> Ability to add items with modifiers
> -----------------------------------
>
>                 Key: OFBIZ-1109
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1109
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: 16Dec2007.patch, 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.  
> A few scenarios should be supported.
> 1.  The item has a default configuration and can be added without configuration.
> 2.  The item requires configuration and a screen to configure the item should present upon adding the item.
> 3.  A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1.  Is anyone else interested in this functionality?
> 2.  What does everyone think is the best way to accomplish this?
> Thanks!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

12