[jira] Created: (OFBIZ-1120) Replace EditBillingAccountTerms FTL/BSH with Forms and widget logic

[Nicolas Malin (Jira)]

Replace EditBillingAccountTerms FTL/BSH with Forms and widget logic
-------------------------------------------------------------------

                 Key: OFBIZ-1120
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1120
             Project: OFBiz
          Issue Type: Improvement
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Wickersheimer Jeremy
            Priority: Minor


Replacing EditBillingAccountTerms.bsh and EditBillingAccountTerms.ftl with widgets and forms.

This also fix a small bug that was due to the FTL (i think), when adding a Term with UOM, then a Term without, the one without is displayed with the same UOM as the previous in the list.

Patch coming.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-1120:
----------------------------------------

    Attachment: ofbiz-1120.patch

Modify the EditBillingAccountTerms screen in applications/accounting/widget/BillingAccountScreens.xml
Add two Froms in applications/accounting/widget/BillingAccountForms.xml
- ListBillingAccountTerms
- EditBillingAccountTerms

Obsolete the files:
applications/accounting/webapp/accounting/billingaccount/EditBillingAccountTerms.ftl
applications/accounting/webapp/accounting/WEB-INF/actions/billingaccount/EditBillingAccountTerms.bsh

> Replace EditBillingAccountTerms FTL/BSH with Forms and widget logic
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-1120
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1120
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: ofbiz-1120.patch
>
>
> Replacing EditBillingAccountTerms.bsh and EditBillingAccountTerms.ftl with widgets and forms.
> This also fix a small bug that was due to the FTL (i think), when adding a Term with UOM, then a Term without, the one without is displayed with the same UOM as the previous in the list.
> Patch coming.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1120:
----------------------------------------

    Assignee: Jacopo Cappellato

> Replace EditBillingAccountTerms FTL/BSH with Forms and widget logic
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-1120
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1120
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: ofbiz-1120.patch
>
>
> Replacing EditBillingAccountTerms.bsh and EditBillingAccountTerms.ftl with widgets and forms.
> This also fix a small bug that was due to the FTL (i think), when adding a Term with UOM, then a Term without, the one without is displayed with the same UOM as the previous in the list.
> Patch coming.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1120.
------------------------------------

    Resolution: Fixed

Thanks Jeremy,

I applied your patch in rev. 555228 with some remarkable differences: in your patch the billing account invoices screen was removed from the system... I guess it was a work in progress. However I've completed that one too.

> Replace EditBillingAccountTerms FTL/BSH with Forms and widget logic
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-1120
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1120
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: ofbiz-1120.patch
>
>
> Replacing EditBillingAccountTerms.bsh and EditBillingAccountTerms.ftl with widgets and forms.
> This also fix a small bug that was due to the FTL (i think), when adding a Term with UOM, then a Term without, the one without is displayed with the same UOM as the previous in the list.
> Patch coming.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511943 ]

Wickersheimer Jeremy commented on OFBIZ-1120:
---------------------------------------------

I've been scratching my head for a few minutes on this. Made a diff from your version to mine and there was no differences ...
So i have no idea why that screen was removed in the patch. Thanks for your work.

> Replace EditBillingAccountTerms FTL/BSH with Forms and widget logic
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-1120
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1120
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: ofbiz-1120.patch
>
>
> Replacing EditBillingAccountTerms.bsh and EditBillingAccountTerms.ftl with widgets and forms.
> This also fix a small bug that was due to the FTL (i think), when adding a Term with UOM, then a Term without, the one without is displayed with the same UOM as the previous in the list.
> Patch coming.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.