[jira] Created: (OFBIZ-1131) Pagination in the product search

[Nicolas Malin (Jira)]

Pagination in the product search
--------------------------------

                 Key: OFBIZ-1131
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1131
             Project: OFBiz
          Issue Type: Improvement
          Components: ecommerce, product
    Affects Versions: SVN trunk
         Environment: mac os
            Reporter: Marco Risaliti
            Priority: Minor
             Fix For: SVN trunk


This is a new improvement to allow to disable pagination and see all the product find in the search in only one page.
For the moment I have not applied it to the ecommerce module because probably in that part is not so important.

Thanks
Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1131:
----------------------------------

    Attachment: paging_on_product_search.patch

This is the first patch.

> Pagination in the product search
> --------------------------------
>
>                 Key: OFBIZ-1131
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1131
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, product
>    Affects Versions: SVN trunk
>         Environment: mac os
>            Reporter: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: paging_on_product_search.patch
>
>
> This is a new improvement to allow to disable pagination and see all the product find in the search in only one page.
> For the moment I have not applied it to the ecommerce module because probably in that part is not so important.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534676 ]

Jacques Le Roux commented on OFBIZ-1131:
----------------------------------------

Hi Marco,

Not sure why, I was not able to use your patch. However it seems correct, I tried to convert from mac eol to dos (I use Windows) and also changed the char between file name and revision number to 4 spaces, but noway.

> Pagination in the product search
> --------------------------------
>
>                 Key: OFBIZ-1131
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1131
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, product
>    Affects Versions: SVN trunk
>         Environment: mac os
>            Reporter: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: paging_on_product_search.patch
>
>
> This is a new improvement to allow to disable pagination and see all the product find in the search in only one page.
> For the moment I have not applied it to the ecommerce module because probably in that part is not so important.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534767 ]

Marco Risaliti commented on OFBIZ-1131:
---------------------------------------

Thanks a lot Jacques to review this patch.
In this moment I cannot check it but I will let you know you something more in the next days and I will provide a new working patch.

Marco

> Pagination in the product search
> --------------------------------
>
>                 Key: OFBIZ-1131
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1131
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, product
>    Affects Versions: SVN trunk
>         Environment: mac os
>            Reporter: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: paging_on_product_search.patch
>
>
> This is a new improvement to allow to disable pagination and see all the product find in the search in only one page.
> For the moment I have not applied it to the ecommerce module because probably in that part is not so important.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1131.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Hi Marco,

Finally I was able to apply your patch. I put a new line after line 165 and removed the / before applications (was the main reason I guess).
I was not able to completly test it since I had not enough products (using OFBiz OOTB) but I saw that you are changing  from a default
    catalog/control/keywordsearch/~VIEW_INDEX=0/~VIEW_SIZE=25/~clearSearch=N/~PAGING=Y
to
    catalog/control/keywordsearch/~VIEW_INDEX=0/~VIEW_SIZE=99999/~clearSearch=N/~PAGING=N

I checked in ecommerce and order manager (no options but no side effects), and as it's ok  I commited in trunk rev. 600171

I think it could be extended to ecommerce and order manager.

Thanks

> Pagination in the product search
> --------------------------------
>
>                 Key: OFBIZ-1131
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1131
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, product
>    Affects Versions: SVN trunk
>         Environment: mac os
>            Reporter: Marco Risaliti
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: paging_on_product_search.patch
>
>
> This is a new improvement to allow to disable pagination and see all the product find in the search in only one page.
> For the moment I have not applied it to the ecommerce module because probably in that part is not so important.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.