[jira] Created: (OFBIZ-1143) Rouding problem while order is payed with billing account

[Nicolas Malin (Jira)]

Rouding problem while order is payed with billing account
---------------------------------------------------------

                 Key: OFBIZ-1143
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1143
             Project: OFBiz
          Issue Type: Bug
          Components: order
            Reporter: Rashko Rejmer
            Priority: Minor
         Attachments: opp_rounding.patch

While creating order that is payed via billing account the OrderPaymentPreference record
has wrong rounding.
It is hard to find example for this bug in OFBiz. I will explain the surcomstances when this is hapenning:

1. Create sales order to "DemoCustCompany" party.
2. Add to cart 10 X GZ-1001 products and nothing else.
3. Chose no shipping
4. Pay with billing account(Id = 9010);

The order total amount is 216.86 if ofbiz demo data is used.
The calculated amount is 212.859999999... so the OrderPaymentPreference record has amount = 212.85.

I have a patch that fixes that problem, but I am not sure if this is a right sollution fot it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rashko Rejmer updated OFBIZ-1143:
---------------------------------

    Attachment: opp_rounding.patch

> Rouding problem while order is payed with billing account
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1143
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1143
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>            Reporter: Rashko Rejmer
>            Priority: Minor
>         Attachments: opp_rounding.patch
>
>
> While creating order that is payed via billing account the OrderPaymentPreference record
> has wrong rounding.
> It is hard to find example for this bug in OFBiz. I will explain the surcomstances when this is hapenning:
> 1. Create sales order to "DemoCustCompany" party.
> 2. Add to cart 10 X GZ-1001 products and nothing else.
> 3. Chose no shipping
> 4. Pay with billing account(Id = 9010);
> The order total amount is 216.86 if ofbiz demo data is used.
> The calculated amount is 212.859999999... so the OrderPaymentPreference record has amount = 212.85.
> I have a patch that fixes that problem, but I am not sure if this is a right sollution fot it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reassigned OFBIZ-1143:
---------------------------------

    Assignee: Scott Gray

> Rouding problem while order is payed with billing account
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1143
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1143
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>            Reporter: Rashko Rejmer
>            Assignee: Scott Gray
>            Priority: Minor
>         Attachments: opp_rounding.patch
>
>
> While creating order that is payed via billing account the OrderPaymentPreference record
> has wrong rounding.
> It is hard to find example for this bug in OFBiz. I will explain the surcomstances when this is hapenning:
> 1. Create sales order to "DemoCustCompany" party.
> 2. Add to cart 10 X GZ-1001 products and nothing else.
> 3. Chose no shipping
> 4. Pay with billing account(Id = 9010);
> The order total amount is 216.86 if ofbiz demo data is used.
> The calculated amount is 212.859999999... so the OrderPaymentPreference record has amount = 212.85.
> I have a patch that fixes that problem, but I am not sure if this is a right sollution fot it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray closed OFBIZ-1143.
-----------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Thanks Rashko, this is in with rev. 556341

I made a small change to the amountBD.setScale call so that it used the values from accounting.properties.

> Rouding problem while order is payed with billing account
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1143
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1143
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>            Reporter: Rashko Rejmer
>            Assignee: Scott Gray
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: opp_rounding.patch
>
>
> While creating order that is payed via billing account the OrderPaymentPreference record
> has wrong rounding.
> It is hard to find example for this bug in OFBiz. I will explain the surcomstances when this is hapenning:
> 1. Create sales order to "DemoCustCompany" party.
> 2. Add to cart 10 X GZ-1001 products and nothing else.
> 3. Chose no shipping
> 4. Pay with billing account(Id = 9010);
> The order total amount is 216.86 if ofbiz demo data is used.
> The calculated amount is 212.859999999... so the OrderPaymentPreference record has amount = 212.85.
> I have a patch that fixes that problem, but I am not sure if this is a right sollution fot it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.