[jira] Created: (OFBIZ-1177) Products should have Roles just as ProductCategories and ProductCatalogs do

[Nicolas Malin (Jira)]

Products should have Roles just as ProductCategories and ProductCatalogs do
---------------------------------------------------------------------------

                 Key: OFBIZ-1177
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1177
             Project: OFBiz
          Issue Type: New Feature
          Components: product
    Affects Versions: SVN trunk
         Environment: Debian Linux, testing
            Reporter: Ean Schuessler
            Priority: Minor
             Fix For: SVN trunk


This patch adds support for ProductRoles, including the entity definition and related editing screens for product catalog administration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ean Schuessler updated OFBIZ-1177:
----------------------------------

    Attachment: product_parties.diff

This is a diff for the product parties feature.

> Products should have Roles just as ProductCategories and ProductCatalogs do
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-1177
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1177
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Debian Linux, testing
>            Reporter: Ean Schuessler
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: product_parties.diff
>
>
> This patch adds support for ProductRoles, including the entity definition and related editing screens for product catalog administration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ean Schuessler updated OFBIZ-1177:
----------------------------------

    Attachment:     (was: product_parties.diff)

> Products should have Roles just as ProductCategories and ProductCatalogs do
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-1177
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1177
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Debian Linux, testing
>            Reporter: Ean Schuessler
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: product_parties.diff
>
>
> This patch adds support for ProductRoles, including the entity definition and related editing screens for product catalog administration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ean Schuessler updated OFBIZ-1177:
----------------------------------

    Attachment: product_parties.diff

The first attachment I uploaded didn't have the new .ftl screen in it. I had to do an SVN add to get it to show up in the diff.

> Products should have Roles just as ProductCategories and ProductCatalogs do
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-1177
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1177
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Debian Linux, testing
>            Reporter: Ean Schuessler
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: product_parties.diff
>
>
> This patch adds support for ProductRoles, including the entity definition and related editing screens for product catalog administration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum reassigned OFBIZ-1177:
----------------------------------

    Assignee: Adrian Crum

> Products should have Roles just as ProductCategories and ProductCatalogs do
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-1177
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1177
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Debian Linux, testing
>            Reporter: Ean Schuessler
>            Assignee: Adrian Crum
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: product_parties.diff
>
>
> This patch adds support for ProductRoles, including the entity definition and related editing screens for product catalog administration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1177:
-------------------------------

    Attachment: product_parties.patch

Ean,

I spent some time this weekend working on your patch. I merged it into a recent svn and I went through the ftl file - deleting unnecessary markup and deprecated CSS classes.

Then the problems began. When I tried to add a party relationship, I got a foreign key violation error. I commented out the Product relation in entitymodel.xml and that got me past that error.

When I tried to update the party relation, the service engine attempted to invoke a non-existent simple method. I fixed that error. Then another error popped up while trying to update.

I gave up at that point. The attached file is your patch plus my changes. It needs more work.

I'd like to get this committed because it's something we can use here, but I don't have time to correct all of the errors.

> Products should have Roles just as ProductCategories and ProductCatalogs do
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-1177
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1177
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Debian Linux, testing
>            Reporter: Ean Schuessler
>            Assignee: Adrian Crum
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: product_parties.diff, product_parties.patch
>
>
> This patch adds support for ProductRoles, including the entity definition and related editing screens for product catalog administration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-1177.
------------------------------

    Resolution: Fixed

Ean,

I fixed the final bug myself. Everything works now and your patch is in rev  578930. You'll still need to take a look at the relation I commented out, plus the party ID text entry needs a lookup screen.

> Products should have Roles just as ProductCategories and ProductCatalogs do
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-1177
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1177
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Debian Linux, testing
>            Reporter: Ean Schuessler
>            Assignee: Adrian Crum
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: product_parties.diff, product_parties.patch
>
>
> This patch adds support for ProductRoles, including the entity definition and related editing screens for product catalog administration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529972 ]

Ean Schuessler commented on OFBIZ-1177:
---------------------------------------

Adrian,

That commented out section should read:

<relation type="one" fk-name="PROD_RLE_PRODUCT" rel-entity-name="Product">
    <key-map field-name="productId"/>
</relation>

I copied the code from the ProductCategory edit and missed changing that. Is there an existing text resource I can use for the "party ID text entry" or am I misunderstanding what you are referring to?

> Products should have Roles just as ProductCategories and ProductCatalogs do
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-1177
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1177
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Debian Linux, testing
>            Reporter: Ean Schuessler
>            Assignee: Adrian Crum
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: product_parties.diff, product_parties.patch
>
>
> This patch adds support for ProductRoles, including the entity definition and related editing screens for product catalog administration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529978 ]

Adrian Crum commented on OFBIZ-1177:
------------------------------------

Ean,

Go to this link:

https://127.0.0.1:8443/catalog/control/EditProdCatalogParties?prodCatalogId=RentalCatalog

I'm referring to the lookup icon (and link) next to the Party Id text entry box. Your enhancement needs one of those so that users aren't expected to memorize party IDs.

> Products should have Roles just as ProductCategories and ProductCatalogs do
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-1177
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1177
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Debian Linux, testing
>            Reporter: Ean Schuessler
>            Assignee: Adrian Crum
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: product_parties.diff, product_parties.patch
>
>
> This patch adds support for ProductRoles, including the entity definition and related editing screens for product catalog administration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.