[jira] [Created] (OFBIZ-11823) Refactor PickListServices#isBinComplete method to remove unnecessary iterations

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (OFBIZ-11823) Refactor PickListServices#isBinComplete method to remove unnecessary iterations

Nicolas Malin (Jira)
Pawan Verma created OFBIZ-11823:
-----------------------------------

             Summary: Refactor PickListServices#isBinComplete method to remove unnecessary iterations
                 Key: OFBIZ-11823
                 URL: https://issues.apache.org/jira/browse/OFBIZ-11823
             Project: OFBiz
          Issue Type: Improvement
          Components: product/facility
    Affects Versions: Trunk
            Reporter: Pawan Verma
            Assignee: Pawan Verma


PickListServices#isBinComplete() is used to check if picklistBin is complete.

This method reduces system performance when a picklistBin contains heavy no of items in it, this method iterator all the items to check the status of the item to validate if the bin is complete or not.

Instead of iteration, we can add itemStatusId != PICKITEM_COMPLETED condition while fetching records from the entity using queryCount() method and if we found count then picklistBin is not complete.


It can be a major performance factor on a production system working on heavy orders.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)