[jira] Created: (OFBIZ-1203) Drop Ship sales and purchase orders, move items to completed when items are shipped and received.

[Nicolas Malin (Jira)]

Drop Ship sales and purchase orders, move items to completed when items are shipped and received.
-------------------------------------------------------------------------------------------------

                 Key: OFBIZ-1203
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1203
             Project: OFBiz
          Issue Type: Improvement
          Components: accounting, order
         Environment: All systems, all enviornments
            Reporter: Karl Pieleck


Setup: When a product that is marked drop ship is sold, and the product's vendor is marked as "will drop ship".

Result: The purchase order and sales order never close, even when the items are shipped, received, and the purchase order is paid. This activity is different than a regular sales order for items sold from stock, where the order is completed once the items are paid and the order is shipped.

Action to Correct: Add code and services to close "Drop Ship Type PO's and Sales Orders" when they are actually completed.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520934 ]

Jacopo Cappellato commented on OFBIZ-1203:
------------------------------------------

Yes, this feature is currently not implemented.
The trick to implement this is to probably create a new service that starting from a List of invoiceIds iterates over them, then retrieves the OrderItems associated and if the order item is still not COMPLETED and with the new invoices it is completely invoiced then complete it (calling the updateOrderItem service). There should be no need to complete the OrderHeader because there are ECAs attached to the updateOrderItem service that should already do this for us.
This new service can then be attached with a new ECA to the "createInvoicesFromShipment" service (the output List returned by this service, "invoicesCreated", will be the input of our new service.

PS: the new service could be named "checkCompleteInvoicedOrderItems" and can be defined and implemented in the order component.

> Drop Ship sales and purchase orders, move items to completed when items are shipped and received.
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1203
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1203
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, order
>         Environment: All systems, all enviornments
>            Reporter: Karl Pieleck
>
> Setup: When a product that is marked drop ship is sold, and the product's vendor is marked as "will drop ship".
> Result: The purchase order and sales order never close, even when the items are shipped, received, and the purchase order is paid. This activity is different than a regular sales order for items sold from stock, where the order is completed once the items are paid and the order is shipped.
> Action to Correct: Add code and services to close "Drop Ship Type PO's and Sales Orders" when they are actually completed.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520935 ]

Jacopo Cappellato commented on OFBIZ-1203:
------------------------------------------

There is probably a solution better than the one I've proposed in my previous comment:

- the new service will be "checkCompleteInvoicedOrderItem" and will accept as input  "orderId" and "orderItemSeqId"; the service will select all the OrderItemBilling records for the given OrderItem and if they completely match the total number of units ordered then it will call the updateOrderItem service to complete the OrderItem (if is is not already completed)
- this new service will be attached with an ECA to the createOrderItemBilling service

This should do the trick.

> Drop Ship sales and purchase orders, move items to completed when items are shipped and received.
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1203
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1203
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, order
>         Environment: All systems, all enviornments
>            Reporter: Karl Pieleck
>
> Setup: When a product that is marked drop ship is sold, and the product's vendor is marked as "will drop ship".
> Result: The purchase order and sales order never close, even when the items are shipped, received, and the purchase order is paid. This activity is different than a regular sales order for items sold from stock, where the order is completed once the items are paid and the order is shipped.
> Action to Correct: Add code and services to close "Drop Ship Type PO's and Sales Orders" when they are actually completed.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520990 ]

Karl Pieleck commented on OFBIZ-1203:
-------------------------------------

Hi Jacopo
We will be working on this soon, how can I assign it to show it being worked
on. We plan to send the code to you for review and check in to the project
when complete.

Karl Pieleck

> Drop Ship sales and purchase orders, move items to completed when items are shipped and received.
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1203
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1203
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, order
>         Environment: All systems, all enviornments
>            Reporter: Karl Pieleck
>
> Setup: When a product that is marked drop ship is sold, and the product's vendor is marked as "will drop ship".
> Result: The purchase order and sales order never close, even when the items are shipped, received, and the purchase order is paid. This activity is different than a regular sales order for items sold from stock, where the order is completed once the items are paid and the order is shipped.
> Action to Correct: Add code and services to close "Drop Ship Type PO's and Sales Orders" when they are actually completed.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521010 ]

Jacopo Cappellato commented on OFBIZ-1203:
------------------------------------------

Great,

we can communicate using comments in this issue and when you have some code that needs review you can attach it here

Jacopo

> Drop Ship sales and purchase orders, move items to completed when items are shipped and received.
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1203
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1203
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, order
>         Environment: All systems, all enviornments
>            Reporter: Karl Pieleck
>
> Setup: When a product that is marked drop ship is sold, and the product's vendor is marked as "will drop ship".
> Result: The purchase order and sales order never close, even when the items are shipped, received, and the purchase order is paid. This activity is different than a regular sales order for items sold from stock, where the order is completed once the items are paid and the order is shipped.
> Action to Correct: Add code and services to close "Drop Ship Type PO's and Sales Orders" when they are actually completed.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1203:
----------------------------------------

    Assignee: Jacopo Cappellato

> Drop Ship sales and purchase orders, move items to completed when items are shipped and received.
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1203
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1203
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, order
>         Environment: All systems, all enviornments
>            Reporter: Karl Pieleck
>            Assignee: Jacopo Cappellato
>
> Setup: When a product that is marked drop ship is sold, and the product's vendor is marked as "will drop ship".
> Result: The purchase order and sales order never close, even when the items are shipped, received, and the purchase order is paid. This activity is different than a regular sales order for items sold from stock, where the order is completed once the items are paid and the order is shipped.
> Action to Correct: Add code and services to close "Drop Ship Type PO's and Sales Orders" when they are actually completed.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522857 ]

Eric Crawford commented on OFBIZ-1203:
--------------------------------------

Hi Jacopo,

 I am working on this issue with Karl. We are unable to find the updateOrderItem service that you refer to in this issue. We see the updateOrderitems service, but it does not look like that service is what we are looking for.  Can you please confirm the service name for us?

Thanks for your help,
Eric

> Drop Ship sales and purchase orders, move items to completed when items are shipped and received.
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1203
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1203
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, order
>         Environment: All systems, all enviornments
>            Reporter: Karl Pieleck
>            Assignee: Jacopo Cappellato
>
> Setup: When a product that is marked drop ship is sold, and the product's vendor is marked as "will drop ship".
> Result: The purchase order and sales order never close, even when the items are shipped, received, and the purchase order is paid. This activity is different than a regular sales order for items sold from stock, where the order is completed once the items are paid and the order is shipped.
> Action to Correct: Add code and services to close "Drop Ship Type PO's and Sales Orders" when they are actually completed.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525992 ]

Jacopo Cappellato commented on OFBIZ-1203:
------------------------------------------

Yes, you are right about the updateOrderItem service... when I wrote my notes I hadn't the source code available, so I just tried to remember the code.
The right service is: changeOrderItemStatus

Here are the corrected notes:

- the new service will be "checkCompleteInvoicedOrderItem" and will accept as input "orderId" and "orderItemSeqId"; the service will select all the OrderItemBilling records for the given OrderItem and if they completely match the total number of units ordered then it will call the changeOrderItemStatus service to complete the OrderItem (if is is not already completed)
- this new service will be attached with an ECA to the createOrderItemBilling service

> Drop Ship sales and purchase orders, move items to completed when items are shipped and received.
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1203
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1203
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, order
>         Environment: All systems, all enviornments
>            Reporter: Karl Pieleck
>            Assignee: Jacopo Cappellato
>
> Setup: When a product that is marked drop ship is sold, and the product's vendor is marked as "will drop ship".
> Result: The purchase order and sales order never close, even when the items are shipped, received, and the purchase order is paid. This activity is different than a regular sales order for items sold from stock, where the order is completed once the items are paid and the order is shipped.
> Action to Correct: Add code and services to close "Drop Ship Type PO's and Sales Orders" when they are actually completed.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533153 ]

Karl Pieleck commented on OFBIZ-1203:
-------------------------------------

Note to Jacopo, We are starting on the coding for this on 10/10 (Wednesday) - Thanks Karl Pieleck

> Drop Ship sales and purchase orders, move items to completed when items are shipped and received.
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1203
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1203
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, order
>         Environment: All systems, all enviornments
>            Reporter: Karl Pieleck
>            Assignee: Jacopo Cappellato
>
> Setup: When a product that is marked drop ship is sold, and the product's vendor is marked as "will drop ship".
> Result: The purchase order and sales order never close, even when the items are shipped, received, and the purchase order is paid. This activity is different than a regular sales order for items sold from stock, where the order is completed once the items are paid and the order is shipped.
> Action to Correct: Add code and services to close "Drop Ship Type PO's and Sales Orders" when they are actually completed.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533162 ]

BJ Freeman commented on OFBIZ-1203:
-----------------------------------

Sales order is completed when the Dropshipper notifies of a tracking number or an invoice is received.
Purchase order is not Closed, but is completed, until the Dropshipper invoice is reconciled with the PO.
reconciled  process is added to allow the accountant to close a PO.
At least the way one customer wanted it.

> Drop Ship sales and purchase orders, move items to completed when items are shipped and received.
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1203
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1203
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, order
>         Environment: All systems, all enviornments
>            Reporter: Karl Pieleck
>            Assignee: Jacopo Cappellato
>
> Setup: When a product that is marked drop ship is sold, and the product's vendor is marked as "will drop ship".
> Result: The purchase order and sales order never close, even when the items are shipped, received, and the purchase order is paid. This activity is different than a regular sales order for items sold from stock, where the order is completed once the items are paid and the order is shipped.
> Action to Correct: Add code and services to close "Drop Ship Type PO's and Sales Orders" when they are actually completed.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533163 ]

Vince Clark commented on OFBIZ-1203:
------------------------------------

This is great functionality. I'm glad to see it being added. Here are some questions that will hopefully help clarify to the community how the finished code will work.

Will you take into consideration Orders that are mixed? Meaning they have both drop ship and inventory items on them? I believe this to be true based on the comments on the issue. It appears everything will be driven from the order item level and the order won't be completed until all lines are invoiced.

Invoicing is driven from Shipments, so how will this work on drop ships? Are shipments automatically generated for drop ship items? Would it be possible to wait for shipment confirmation from the supplier.

Will payment capture remain the same?

> Drop Ship sales and purchase orders, move items to completed when items are shipped and received.
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1203
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1203
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, order
>         Environment: All systems, all enviornments
>            Reporter: Karl Pieleck
>            Assignee: Jacopo Cappellato
>
> Setup: When a product that is marked drop ship is sold, and the product's vendor is marked as "will drop ship".
> Result: The purchase order and sales order never close, even when the items are shipped, received, and the purchase order is paid. This activity is different than a regular sales order for items sold from stock, where the order is completed once the items are paid and the order is shipped.
> Action to Correct: Add code and services to close "Drop Ship Type PO's and Sales Orders" when they are actually completed.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533181 ]

BJ Freeman commented on OFBIZ-1203:
-----------------------------------

in the order process for the drop shipper there are some extra statuses.
1) order on hold while checking shippers inventory (usually for backorders)
2) order waiting Shipper shipping notice (usually tracking data)
3) order waiting shipper invoice. (if not tracking data this this notifies of shipment)
4) order waiting to be reconcile with shipper invoice

The above is more dependent on other services that allow orders to be sent to and invoices received from the dropshipper.
the reconcile is both manual and automatic if the dropshippers roles allow for automatic processing.

The shipping invoice for PO is held to be processed when the real invoice from the dropshipper is received.
Shipment are released for the dropshipper when either the invoice is received, manually, or the Tracking number is received and the order is set to ship as one shipment, not split.

Note: I am referring to the implementation we use for dropshippers.
The is a lot of electronic communications between the dropshipper and ofbiz.
this includes requesting RMA from the shipper and issuing RMA to the customer after recieving from the Dropshipper.

> Drop Ship sales and purchase orders, move items to completed when items are shipped and received.
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1203
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1203
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, order
>         Environment: All systems, all enviornments
>            Reporter: Karl Pieleck
>            Assignee: Jacopo Cappellato
>
> Setup: When a product that is marked drop ship is sold, and the product's vendor is marked as "will drop ship".
> Result: The purchase order and sales order never close, even when the items are shipped, received, and the purchase order is paid. This activity is different than a regular sales order for items sold from stock, where the order is completed once the items are paid and the order is shipped.
> Action to Correct: Add code and services to close "Drop Ship Type PO's and Sales Orders" when they are actually completed.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533639 ]

Jacopo Cappellato commented on OFBIZ-1203:
------------------------------------------

Karl,

this is great news; let us know if you have any questions.

> Drop Ship sales and purchase orders, move items to completed when items are shipped and received.
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1203
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1203
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, order
>         Environment: All systems, all enviornments
>            Reporter: Karl Pieleck
>            Assignee: Jacopo Cappellato
>
> Setup: When a product that is marked drop ship is sold, and the product's vendor is marked as "will drop ship".
> Result: The purchase order and sales order never close, even when the items are shipped, received, and the purchase order is paid. This activity is different than a regular sales order for items sold from stock, where the order is completed once the items are paid and the order is shipped.
> Action to Correct: Add code and services to close "Drop Ship Type PO's and Sales Orders" when they are actually completed.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539791 ]

Karl Pieleck commented on OFBIZ-1203:
-------------------------------------

Thank you for your help

> Drop Ship sales and purchase orders, move items to completed when items are shipped and received.
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1203
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1203
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, order
>         Environment: All systems, all enviornments
>            Reporter: Karl Pieleck
>            Assignee: Jacopo Cappellato
>
> Setup: When a product that is marked drop ship is sold, and the product's vendor is marked as "will drop ship".
> Result: The purchase order and sales order never close, even when the items are shipped, received, and the purchase order is paid. This activity is different than a regular sales order for items sold from stock, where the order is completed once the items are paid and the order is shipped.
> Action to Correct: Add code and services to close "Drop Ship Type PO's and Sales Orders" when they are actually completed.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546342 ]

Si Chen commented on OFBIZ-1203:
--------------------------------

our commit r 598723 should complete the drop ship po's

> Drop Ship sales and purchase orders, move items to completed when items are shipped and received.
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1203
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1203
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, order
>         Environment: All systems, all enviornments
>            Reporter: Karl Pieleck
>            Assignee: Jacopo Cappellato
>
> Setup: When a product that is marked drop ship is sold, and the product's vendor is marked as "will drop ship".
> Result: The purchase order and sales order never close, even when the items are shipped, received, and the purchase order is paid. This activity is different than a regular sales order for items sold from stock, where the order is completed once the items are paid and the order is shipped.
> Action to Correct: Add code and services to close "Drop Ship Type PO's and Sales Orders" when they are actually completed.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546468 ]

BJ Freeman commented on OFBIZ-1203:
-----------------------------------

Guess I am kinda a slow.
this is for the company using ofbiz to dropship.
so now we have the whole issue of a supplier dropshipping orders to customer that order thru the eccommerce.

> Drop Ship sales and purchase orders, move items to completed when items are shipped and received.
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1203
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1203
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, order
>         Environment: All systems, all enviornments
>            Reporter: Karl Pieleck
>            Assignee: Jacopo Cappellato
>
> Setup: When a product that is marked drop ship is sold, and the product's vendor is marked as "will drop ship".
> Result: The purchase order and sales order never close, even when the items are shipped, received, and the purchase order is paid. This activity is different than a regular sales order for items sold from stock, where the order is completed once the items are paid and the order is shipped.
> Action to Correct: Add code and services to close "Drop Ship Type PO's and Sales Orders" when they are actually completed.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1203.
------------------------------------

    Resolution: Fixed

> Drop Ship sales and purchase orders, move items to completed when items are shipped and received.
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1203
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1203
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, order
>         Environment: All systems, all enviornments
>            Reporter: Karl Pieleck
>            Assignee: Jacopo Cappellato
>
> Setup: When a product that is marked drop ship is sold, and the product's vendor is marked as "will drop ship".
> Result: The purchase order and sales order never close, even when the items are shipped, received, and the purchase order is paid. This activity is different than a regular sales order for items sold from stock, where the order is completed once the items are paid and the order is shipped.
> Action to Correct: Add code and services to close "Drop Ship Type PO's and Sales Orders" when they are actually completed.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.