[jira] Created: (OFBIZ-1205) Use facility of cart when creating PO from requirements

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-1205) Use facility of cart when creating PO from requirements

Nicolas Malin (Jira)
Use facility of cart when creating PO from requirements
-------------------------------------------------------

                 Key: OFBIZ-1205
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1205
             Project: OFBiz
          Issue Type: Improvement
          Components: order
    Affects Versions: SVN trunk
            Reporter: Leon Torres
            Priority: Minor


Right now when creating a PO from requirements, the ShoppingCart chooses a random facility to associate with the order.  Instead, it should just be using the facilityId set for the cart, and setting this facilityId should be the responsibility of the requirement event method ShoppingCartHelper.addToCartBulkRequirements().

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1205) Use facility of cart when creating PO from requirements

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leon Torres updated OFBIZ-1205:
-------------------------------

    Attachment: createPOFromRequirementsFacility.patch

Here's a simple and straightforward fix:

1.  The requirement screen passes the facilityId
2.  addToCartBulkRequirements() will do cart.setFacilityId()
3.  default options uses this facilityId, otherwise it does not create any shipping (that is, do not use a random facility, it just surprises the users)

To test this,

1.  create a sales order for GZ-1005 or whatever product creates requirements.  
2. Approve the requirements
3.  view the requirements by vendor, select a facility
4.  create the PO
5.  Notice that the ship to address is for the selected facility
6.  Don't create the order, instead go back to step #3 and choose a different facility, then repeat test to make sure the facility address is correct

> Use facility of cart when creating PO from requirements
> -------------------------------------------------------
>
>                 Key: OFBIZ-1205
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1205
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon Torres
>            Priority: Minor
>         Attachments: createPOFromRequirementsFacility.patch
>
>
> Right now when creating a PO from requirements, the ShoppingCart chooses a random facility to associate with the order.  Instead, it should just be using the facilityId set for the cart, and setting this facilityId should be the responsibility of the requirement event method ShoppingCartHelper.addToCartBulkRequirements().

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-1205) Use facility of cart when creating PO from requirements

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Si Chen closed OFBIZ-1205.
--------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

> Use facility of cart when creating PO from requirements
> -------------------------------------------------------
>
>                 Key: OFBIZ-1205
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1205
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon Torres
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: createPOFromRequirementsFacility.patch
>
>
> Right now when creating a PO from requirements, the ShoppingCart chooses a random facility to associate with the order.  Instead, it should just be using the facilityId set for the cart, and setting this facilityId should be the responsibility of the requirement event method ShoppingCartHelper.addToCartBulkRequirements().

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.