Canceling rental product reservations (room booking)
---------------------------------------------------- Key: OFBIZ-1209 URL: https://issues.apache.org/jira/browse/OFBIZ-1209 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Reporter: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Hi all, This is an initial service for canceling rental product reservations, visible through fixed asset calendar. It is called on a seca rule while canceling order items and cancel the whole future reservation, or if the order is canceled in the middle of reservation period, only the future dates (from tomorrow till the end of reservation) will be canceled. For now i put it in OrderServices.java file, but i see that there is new directory for rental things in product, so may be that is the right place. This service is working fine for me but may be needs some changes/improvements, so i'll be happy to hear any comments. Regards, Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[ https://issues.apache.org/jira/browse/OFBIZ-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-1209: --------------------------------- Attachment: cancelRental.patch > Canceling rental product reservations (room booking) > ---------------------------------------------------- > > Key: OFBIZ-1209 > URL: https://issues.apache.org/jira/browse/OFBIZ-1209 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Reporter: Bilgin Ibryam > Priority: Minor > Fix For: SVN trunk > > Attachments: cancelRental.patch > > > Hi all, > This is an initial service for canceling rental product reservations, visible through fixed asset calendar. > It is called on a seca rule while canceling order items and cancel the whole future reservation, or if the order is canceled in the middle of reservation period, only the future dates (from tomorrow till the end of reservation) will be canceled. > For now i put it in OrderServices.java file, but i see that there is new directory for rental things in product, so may be that is the right place. > This service is working fine for me but may be needs some changes/improvements, so i'll be happy to hear any comments. > Regards, > Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker reassigned OFBIZ-1209: ---------------------------------- Assignee: Hans Bakker > Canceling rental product reservations (room booking) > ---------------------------------------------------- > > Key: OFBIZ-1209 > URL: https://issues.apache.org/jira/browse/OFBIZ-1209 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Reporter: Bilgin Ibryam > Assignee: Hans Bakker > Priority: Minor > Fix For: SVN trunk > > Attachments: cancelRental.patch > > > Hi all, > This is an initial service for canceling rental product reservations, visible through fixed asset calendar. > It is called on a seca rule while canceling order items and cancel the whole future reservation, or if the order is canceled in the middle of reservation period, only the future dates (from tomorrow till the end of reservation) will be canceled. > For now i put it in OrderServices.java file, but i see that there is new directory for rental things in product, so may be that is the right place. > This service is working fine for me but may be needs some changes/improvements, so i'll be happy to hear any comments. > Regards, > Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520548 ] Bilgin Ibryam commented on OFBIZ-1209: -------------------------------------- May be it is also a good idea to change the status of the associated workefforts to CAL_CANCELLED. This way we can keep track (through WorkEffortStatus entity) who and when canceled the rental product . > Canceling rental product reservations (room booking) > ---------------------------------------------------- > > Key: OFBIZ-1209 > URL: https://issues.apache.org/jira/browse/OFBIZ-1209 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Reporter: Bilgin Ibryam > Assignee: Hans Bakker > Priority: Minor > Fix For: SVN trunk > > Attachments: cancelRental.patch > > > Hi all, > This is an initial service for canceling rental product reservations, visible through fixed asset calendar. > It is called on a seca rule while canceling order items and cancel the whole future reservation, or if the order is canceled in the middle of reservation period, only the future dates (from tomorrow till the end of reservation) will be canceled. > For now i put it in OrderServices.java file, but i see that there is new directory for rental things in product, so may be that is the right place. > This service is working fine for me but may be needs some changes/improvements, so i'll be happy to hear any comments. > Regards, > Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam reassigned OFBIZ-1209: ------------------------------------ Assignee: Bilgin Ibryam (was: Hans Bakker) > Canceling rental product reservations (room booking) > ---------------------------------------------------- > > Key: OFBIZ-1209 > URL: https://issues.apache.org/jira/browse/OFBIZ-1209 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Reporter: Bilgin Ibryam > Assignee: Bilgin Ibryam > Priority: Minor > Fix For: SVN trunk > > Attachments: cancelRental.patch > > > Hi all, > This is an initial service for canceling rental product reservations, visible through fixed asset calendar. > It is called on a seca rule while canceling order items and cancel the whole future reservation, or if the order is canceled in the middle of reservation period, only the future dates (from tomorrow till the end of reservation) will be canceled. > For now i put it in OrderServices.java file, but i see that there is new directory for rental things in product, so may be that is the right place. > This service is working fine for me but may be needs some changes/improvements, so i'll be happy to hear any comments. > Regards, > Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-1209: -------------------------------------- Assignee: Jacques Le Roux (was: Bilgin Ibryam) > Canceling rental product reservations (room booking) > ---------------------------------------------------- > > Key: OFBIZ-1209 > URL: https://issues.apache.org/jira/browse/OFBIZ-1209 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Reporter: Bilgin Ibryam > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: cancelRental.patch > > > Hi all, > This is an initial service for canceling rental product reservations, visible through fixed asset calendar. > It is called on a seca rule while canceling order items and cancel the whole future reservation, or if the order is canceled in the middle of reservation period, only the future dates (from tomorrow till the end of reservation) will be canceled. > For now i put it in OrderServices.java file, but i see that there is new directory for rental things in product, so may be that is the right place. > This service is working fine for me but may be needs some changes/improvements, so i'll be happy to hear any comments. > Regards, > Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-1209: -------------------------------------- Assignee: Bilgin Ibryam (was: Jacques Le Roux) Sorry Bilgin, I did not realise that this issue was already assigned to you. I prefer to let you make the decision :o) > Canceling rental product reservations (room booking) > ---------------------------------------------------- > > Key: OFBIZ-1209 > URL: https://issues.apache.org/jira/browse/OFBIZ-1209 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Reporter: Bilgin Ibryam > Assignee: Bilgin Ibryam > Priority: Minor > Fix For: SVN trunk > > Attachments: cancelRental.patch > > > Hi all, > This is an initial service for canceling rental product reservations, visible through fixed asset calendar. > It is called on a seca rule while canceling order items and cancel the whole future reservation, or if the order is canceled in the middle of reservation period, only the future dates (from tomorrow till the end of reservation) will be canceled. > For now i put it in OrderServices.java file, but i see that there is new directory for rental things in product, so may be that is the right place. > This service is working fine for me but may be needs some changes/improvements, so i'll be happy to hear any comments. > Regards, > Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-1209. -------------------------------- Resolution: Later > Canceling rental product reservations (room booking) > ---------------------------------------------------- > > Key: OFBIZ-1209 > URL: https://issues.apache.org/jira/browse/OFBIZ-1209 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Reporter: Bilgin Ibryam > Assignee: Bilgin Ibryam > Priority: Minor > Fix For: SVN trunk > > Attachments: cancelRental.patch > > > Hi all, > This is an initial service for canceling rental product reservations, visible through fixed asset calendar. > It is called on a seca rule while canceling order items and cancel the whole future reservation, or if the order is canceled in the middle of reservation period, only the future dates (from tomorrow till the end of reservation) will be canceled. > For now i put it in OrderServices.java file, but i see that there is new directory for rental things in product, so may be that is the right place. > This service is working fine for me but may be needs some changes/improvements, so i'll be happy to hear any comments. > Regards, > Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Free forum by Nabble | Edit this page |