[jira] Created: (OFBIZ-1212) small, easy to review and commit code cleanups

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-1212) small, easy to review and commit code cleanups

Nicolas Malin (Jira)
small, easy to review and commit code cleanups
----------------------------------------------

                 Key: OFBIZ-1212
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1212
             Project: OFBiz
          Issue Type: Bug
    Affects Versions: SVN trunk
            Reporter: Bilgin Ibryam
            Priority: Trivial
             Fix For: SVN trunk
         Attachments: trivial.patch

I am sending some small code cleanups done while browsing the code. I am afraid that commiters will get angry me for spamming the jira with such a trivial fixes.
I also want to ask:is this a bug: delegator.getNextSeqId("techDataCalendar");, because someone can use the entity name delegator.getNextSeqId("TechDataCalendar"); and then the ids can duplicate. Isn't it ? If i am wrong you can skip this part of the patch, while commiting.

Regards,
Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1212) small, easy to review and commit code cleanups

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1212:
---------------------------------

    Attachment: trivial.patch

> small, easy to review and commit code cleanups
> ----------------------------------------------
>
>                 Key: OFBIZ-1212
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1212
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: trivial.patch
>
>
> I am sending some small code cleanups done while browsing the code. I am afraid that commiters will get angry me for spamming the jira with such a trivial fixes.
> I also want to ask:is this a bug: delegator.getNextSeqId("techDataCalendar");, because someone can use the entity name delegator.getNextSeqId("TechDataCalendar"); and then the ids can duplicate. Isn't it ? If i am wrong you can skip this part of the patch, while commiting.
> Regards,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-1212) small, easy to review and commit code cleanups

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum reassigned OFBIZ-1212:
----------------------------------

    Assignee: Adrian Crum

> small, easy to review and commit code cleanups
> ----------------------------------------------
>
>                 Key: OFBIZ-1212
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1212
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Adrian Crum
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: trivial.patch
>
>
> I am sending some small code cleanups done while browsing the code. I am afraid that commiters will get angry me for spamming the jira with such a trivial fixes.
> I also want to ask:is this a bug: delegator.getNextSeqId("techDataCalendar");, because someone can use the entity name delegator.getNextSeqId("TechDataCalendar"); and then the ids can duplicate. Isn't it ? If i am wrong you can skip this part of the patch, while commiting.
> Regards,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-1212) small, easy to review and commit code cleanups

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-1212.
------------------------------

    Resolution: Fixed

Thanks Bilgin. Your patch is in rev 567087.


> small, easy to review and commit code cleanups
> ----------------------------------------------
>
>                 Key: OFBIZ-1212
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1212
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Adrian Crum
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: trivial.patch
>
>
> I am sending some small code cleanups done while browsing the code. I am afraid that commiters will get angry me for spamming the jira with such a trivial fixes.
> I also want to ask:is this a bug: delegator.getNextSeqId("techDataCalendar");, because someone can use the entity name delegator.getNextSeqId("TechDataCalendar"); and then the ids can duplicate. Isn't it ? If i am wrong you can skip this part of the patch, while commiting.
> Regards,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.