[jira] Created: (OFBIZ-1281) update Productstoreworker.java

[Nicolas Malin (Jira)]

update Productstoreworker.java
------------------------------

                 Key: OFBIZ-1281
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1281
             Project: OFBiz
          Issue Type: Sub-task
          Components: product
    Affects Versions: SVN trunk, Release Branch 4.0
            Reporter: BJ Freeman
             Fix For: SVN trunk, Release Branch 4.0


Add all the current defaults to Productstoreworker.defaultProductStoreEmailScreenLocation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

BJ Freeman updated OFBIZ-1281:
------------------------------

    Attachment: adddefualtProdemails.patch

adds all the current default prod store emails.
Note these are all widgets so until create customer and possibly others are fixed this there will be errrors.

> update Productstoreworker.java
> ------------------------------
>
>                 Key: OFBIZ-1281
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1281
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: BJ Freeman
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: adddefualtProdemails.patch
>
>
> Add all the current defaults to Productstoreworker.defaultProductStoreEmailScreenLocation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

BJ Freeman updated OFBIZ-1281:
------------------------------

    Attachment:     (was: adddefualtProdemails.patch)

> update Productstoreworker.java
> ------------------------------
>
>                 Key: OFBIZ-1281
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1281
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: BJ Freeman
>             Fix For: SVN trunk, Release Branch 4.0
>
>
> Add all the current defaults to Productstoreworker.defaultProductStoreEmailScreenLocation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

BJ Freeman updated OFBIZ-1281:
------------------------------

    Attachment: adddefualtProdemails.patch

this adds all the current prod store emails as default to productstoreworker.java
Note this does not cure all the problems.
will still get errors till the rest of the patches are implemented

> update Productstoreworker.java
> ------------------------------
>
>                 Key: OFBIZ-1281
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1281
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: BJ Freeman
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: adddefualtProdemails.patch
>
>
> Add all the current defaults to Productstoreworker.defaultProductStoreEmailScreenLocation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

BJ Freeman updated OFBIZ-1281:
------------------------------

    Attachment:     (was: adddefualtProdemails.patch)

> update Productstoreworker.java
> ------------------------------
>
>                 Key: OFBIZ-1281
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1281
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: BJ Freeman
>             Fix For: SVN trunk, Release Branch 4.0
>
>
> Add all the current defaults to Productstoreworker.defaultProductStoreEmailScreenLocation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

BJ Freeman updated OFBIZ-1281:
------------------------------

    Attachment: adddefualtProdemails.patch

this adds all the current prod store emails as default to productstoreworker.java
Note this does not cure all the problems.
will still get errors till the rest of the patches are implemented

ps sorry of all the extra notices.  should have tested before uploading last time.

> update Productstoreworker.java
> ------------------------------
>
>                 Key: OFBIZ-1281
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1281
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: BJ Freeman
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: adddefualtProdemails.patch
>
>
> Add all the current defaults to Productstoreworker.defaultProductStoreEmailScreenLocation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

BJ Freeman updated OFBIZ-1281:
------------------------------

    Attachment: demoprod.patch

Adds the missing PRDS_CUST_REGISTER to the demoproducts.xml

> update Productstoreworker.java
> ------------------------------
>
>                 Key: OFBIZ-1281
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1281
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: BJ Freeman
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: adddefualtProdemails.patch, demoprod.patch
>
>
> Add all the current defaults to Productstoreworker.defaultProductStoreEmailScreenLocation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Geisert updated OFBIZ-1281:
-------------------------------------

    Attachment: new-defaultProductStoreEmail.diff

The whole OFBIZ-1278 is a bit confusing (and if I understand correctly should be done with OFBIZ-982 anyway)

But it would be good to set the default for all ProductStore Emails, the attached patch does this (for both trunk and release branch)

> update Productstoreworker.java
> ------------------------------
>
>                 Key: OFBIZ-1281
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1281
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: BJ Freeman
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: adddefualtProdemails.patch, demoprod.patch, new-defaultProductStoreEmail.diff
>
>
> Add all the current defaults to Productstoreworker.defaultProductStoreEmailScreenLocation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536747 ]

BJ Freeman commented on OFBIZ-1281:
-----------------------------------

christian:
patch does not include
PRDS_CUST_REGISTER
as does not my patch that does the same thing.

> update Productstoreworker.java
> ------------------------------
>
>                 Key: OFBIZ-1281
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1281
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: BJ Freeman
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: adddefualtProdemails.patch, demoprod.patch, new-defaultProductStoreEmail.diff
>
>
> Add all the current defaults to Productstoreworker.defaultProductStoreEmailScreenLocation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Geisert updated OFBIZ-1281:
-------------------------------------

    Attachment: new-defaultProductStoreEmail.diff

Ah, I thought PRDS_CUST_REGISTER is a new event that comes with OFBIZ-1278 ...
(so IMHO it makes no sense that this is a subtask)

Anyway, I've updated the patch to include PRDS_CUST_REGISTER
(your patch adds lots of unsused imports)

> update Productstoreworker.java
> ------------------------------
>
>                 Key: OFBIZ-1281
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1281
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: BJ Freeman
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: adddefualtProdemails.patch, demoprod.patch, new-defaultProductStoreEmail.diff, new-defaultProductStoreEmail.diff
>
>
> Add all the current defaults to Productstoreworker.defaultProductStoreEmailScreenLocation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537054 ]

BJ Freeman commented on OFBIZ-1281:
-----------------------------------

not sure we are on the same page.
you revision is (Revision 1224)
the one I did was for  (revision 581071)

> update Productstoreworker.java
> ------------------------------
>
>                 Key: OFBIZ-1281
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1281
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: BJ Freeman
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: adddefualtProdemails.patch, demoprod.patch, new-defaultProductStoreEmail.diff, new-defaultProductStoreEmail.diff
>
>
> Add all the current defaults to Productstoreworker.defaultProductStoreEmailScreenLocation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537268 ]

Christian Geisert commented on OFBIZ-1281:
------------------------------------------

Uh, thats a revison from our internal repository :-(
But the patch has been tested with both current trunk and branch (rev. 587847)

> update Productstoreworker.java
> ------------------------------
>
>                 Key: OFBIZ-1281
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1281
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: BJ Freeman
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: adddefualtProdemails.patch, demoprod.patch, new-defaultProductStoreEmail.diff, new-defaultProductStoreEmail.diff
>
>
> Add all the current defaults to Productstoreworker.defaultProductStoreEmailScreenLocation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1281:
----------------------------------------

    Assignee: Jacopo Cappellato

> update Productstoreworker.java
> ------------------------------
>
>                 Key: OFBIZ-1281
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1281
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: BJ Freeman
>            Assignee: Jacopo Cappellato
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: adddefualtProdemails.patch, demoprod.patch, new-defaultProductStoreEmail.diff, new-defaultProductStoreEmail.diff
>
>
> Add all the current defaults to Productstoreworker.defaultProductStoreEmailScreenLocation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537304 ]

BJ Freeman commented on OFBIZ-1281:
-----------------------------------

not sure how the imports got generated different. will have to watch this next time.
thanks for letting me know.
also have to change the absolute path and the tabs.

> update Productstoreworker.java
> ------------------------------
>
>                 Key: OFBIZ-1281
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1281
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: BJ Freeman
>            Assignee: Jacopo Cappellato
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: adddefualtProdemails.patch, demoprod.patch, new-defaultProductStoreEmail.diff, new-defaultProductStoreEmail.diff
>
>
> Add all the current defaults to Productstoreworker.defaultProductStoreEmailScreenLocation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537395 ]

Jacques Le Roux commented on OFBIZ-1281:
----------------------------------------

Christian,

Thanks for the recall about OFBIZ-982. We need to clarify all this before commiting anything.

BJ,

Thanks for you commitment in this task. As soon as we will be clear on that I (or Jacopo maybe) will commit the work. Should be soon I guess...

> update Productstoreworker.java
> ------------------------------
>
>                 Key: OFBIZ-1281
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1281
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: BJ Freeman
>            Assignee: Jacopo Cappellato
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: adddefualtProdemails.patch, demoprod.patch, new-defaultProductStoreEmail.diff, new-defaultProductStoreEmail.diff
>
>
> Add all the current defaults to Productstoreworker.defaultProductStoreEmailScreenLocation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537408 ]

BJ Freeman commented on OFBIZ-1281:
-----------------------------------

it will not cause any errors to apply these now.
 can ignore  adddefualtProdemails.patch but apply #2 and #3
once 892 is applied then these will work properly.

> update Productstoreworker.java
> ------------------------------
>
>                 Key: OFBIZ-1281
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1281
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: BJ Freeman
>            Assignee: Jacopo Cappellato
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: adddefualtProdemails.patch, demoprod.patch, new-defaultProductStoreEmail.diff, new-defaultProductStoreEmail.diff
>
>
> Add all the current defaults to Productstoreworker.defaultProductStoreEmailScreenLocation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554138 ]

Jacopo Cappellato commented on OFBIZ-1281:
------------------------------------------

Christian,

since it seems you have tested/reviewed/modified this patch, would you please take care this task (and commit or close/reject)? I'm a bit confused about this (don't quite understand).

Thanks

> update Productstoreworker.java
> ------------------------------
>
>                 Key: OFBIZ-1281
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1281
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: BJ Freeman
>            Assignee: Jacopo Cappellato
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: adddefualtProdemails.patch, demoprod.patch, new-defaultProductStoreEmail.diff, new-defaultProductStoreEmail.diff
>
>
> Add all the current defaults to Productstoreworker.defaultProductStoreEmailScreenLocation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1281:
----------------------------------------

    Assignee: Christian Geisert  (was: Jacopo Cappellato)

> update Productstoreworker.java
> ------------------------------
>
>                 Key: OFBIZ-1281
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1281
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: BJ Freeman
>            Assignee: Christian Geisert
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: adddefualtProdemails.patch, demoprod.patch, new-defaultProductStoreEmail.diff, new-defaultProductStoreEmail.diff
>
>
> Add all the current defaults to Productstoreworker.defaultProductStoreEmailScreenLocation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

BJ Freeman closed OFBIZ-1281.
-----------------------------

    Resolution: Won't Fix

> update Productstoreworker.java
> ------------------------------
>
>                 Key: OFBIZ-1281
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1281
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: BJ Freeman
>            Assignee: Christian Geisert
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: adddefualtProdemails.patch, demoprod.patch, new-defaultProductStoreEmail.diff, new-defaultProductStoreEmail.diff
>
>
> Add all the current defaults to Productstoreworker.defaultProductStoreEmailScreenLocation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Geisert reopened OFBIZ-1281:
--------------------------------------


I'll commit the patch with the missing defaults

> update Productstoreworker.java
> ------------------------------
>
>                 Key: OFBIZ-1281
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1281
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: BJ Freeman
>            Assignee: Christian Geisert
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: adddefualtProdemails.patch, demoprod.patch, new-defaultProductStoreEmail.diff, new-defaultProductStoreEmail.diff
>
>
> Add all the current defaults to Productstoreworker.defaultProductStoreEmailScreenLocation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.