[jira] Created: (OFBIZ-1352) Rewrite FlexibleMapAccessor into a top-down instead of bottom-up algorithm

[Nicolas Malin (Jira)]

Rewrite FlexibleMapAccessor into a top-down instead of bottom-up algorithm
--------------------------------------------------------------------------

                 Key: OFBIZ-1352
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1352
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Adam Heath
             Fix For: SVN trunk
         Attachments: framework-base-FlexibleMapAccessor-bottom-up-top-down.patch

It wasn't possible to make FlexibleMapAccessor generic, given how it was currently written.  There was a single field that would change the type of the object it stored, based on various other parameters.  So, the attached patch is a major rewrite of the algorithm.

The code still parses the string into an internal compiled form; but resolution now happens left-to-right, instead of inside-out.

I'm filing this as a bug instead of just committing it, as I want it to be discussed first.  There is one patch left after this, to make all of framework/base generified and ported to java 1.5.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Heath updated OFBIZ-1352:
------------------------------

    Attachment: framework-base-FlexibleMapAccessor-bottom-up-top-down.patch

> Rewrite FlexibleMapAccessor into a top-down instead of bottom-up algorithm
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-1352
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1352
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adam Heath
>             Fix For: SVN trunk
>
>         Attachments: framework-base-FlexibleMapAccessor-bottom-up-top-down.patch
>
>
> It wasn't possible to make FlexibleMapAccessor generic, given how it was currently written.  There was a single field that would change the type of the object it stored, based on various other parameters.  So, the attached patch is a major rewrite of the algorithm.
> The code still parses the string into an internal compiled form; but resolution now happens left-to-right, instead of inside-out.
> I'm filing this as a bug instead of just committing it, as I want it to be discussed first.  There is one patch left after this, to make all of framework/base generified and ported to java 1.5.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633777#action_12633777 ]

Adrian Crum commented on OFBIZ-1352:
------------------------------------

Adam,

If you could update your patch, I'd like to take a look at this.

> Rewrite FlexibleMapAccessor into a top-down instead of bottom-up algorithm
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-1352
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1352
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adam Heath
>             Fix For: SVN trunk
>
>         Attachments: framework-base-FlexibleMapAccessor-bottom-up-top-down.patch
>
>
> It wasn't possible to make FlexibleMapAccessor generic, given how it was currently written.  There was a single field that would change the type of the object it stored, based on various other parameters.  So, the attached patch is a major rewrite of the algorithm.
> The code still parses the string into an internal compiled form; but resolution now happens left-to-right, instead of inside-out.
> I'm filing this as a bug instead of just committing it, as I want it to be discussed first.  There is one patch left after this, to make all of framework/base generified and ported to java 1.5.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-1352.
------------------------------

    Resolution: Won't Fix

This has been made invalid by the recent refactoring.

> Rewrite FlexibleMapAccessor into a top-down instead of bottom-up algorithm
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-1352
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1352
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adam Heath
>             Fix For: SVN trunk
>
>         Attachments: framework-base-FlexibleMapAccessor-bottom-up-top-down.patch
>
>
> It wasn't possible to make FlexibleMapAccessor generic, given how it was currently written.  There was a single field that would change the type of the object it stored, based on various other parameters.  So, the attached patch is a major rewrite of the algorithm.
> The code still parses the string into an internal compiled form; but resolution now happens left-to-right, instead of inside-out.
> I'm filing this as a bug instead of just committing it, as I want it to be discussed first.  There is one patch left after this, to make all of framework/base generified and ported to java 1.5.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.