[jira] Created: (OFBIZ-1363) UtilDateTime.toDate(int, int, int, int, int, int) does not initialise milisecond part of created date

[Nicolas Malin (Jira)]

UtilDateTime.toDate(int, int, int, int, int, int) does not initialise milisecond part of created date
-----------------------------------------------------------------------------------------------------

                 Key: OFBIZ-1363
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1363
             Project: OFBiz
          Issue Type: Bug
          Components: framework
            Reporter: Markus Studer
            Priority: Trivial


The public static java.util.Date toDate(int month, int day, int year, int hour, int minute, int second) method does not initialise the milisecond part of the created date predictably (uses the milisecond part of the current system time). This can lead to confusing results when comparing dates as the dates created with this method usually contain a milisecond part.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Markus Studer updated OFBIZ-1363:
---------------------------------

    Attachment: UtilDateTime.diff

Patch to set milisecond part of date to 0

> UtilDateTime.toDate(int, int, int, int, int, int) does not initialise milisecond part of created date
> -----------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1363
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1363
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Markus Studer
>            Priority: Trivial
>         Attachments: UtilDateTime.diff
>
>
> The public static java.util.Date toDate(int month, int day, int year, int hour, int minute, int second) method does not initialise the milisecond part of the created date predictably (uses the milisecond part of the current system time). This can lead to confusing results when comparing dates as the dates created with this method usually contain a milisecond part.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538566 ]

Jacques Le Roux commented on OFBIZ-1363:
----------------------------------------

Hi Markus,

This is interesting but I wonder if nobody is using this specificity (though I must admit it seems weird, and I saw nothing in code). If somebody is aware of  a specific use (with milliseconds not initialised)  please let us know, else I will commit this patch soon.

> UtilDateTime.toDate(int, int, int, int, int, int) does not initialise milisecond part of created date
> -----------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1363
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1363
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Markus Studer
>            Priority: Trivial
>         Attachments: UtilDateTime.diff
>
>
> The public static java.util.Date toDate(int month, int day, int year, int hour, int minute, int second) method does not initialise the milisecond part of the created date predictably (uses the milisecond part of the current system time). This can lead to confusing results when comparing dates as the dates created with this method usually contain a milisecond part.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-1363:
--------------------------------------

    Assignee: Jacques Le Roux

> UtilDateTime.toDate(int, int, int, int, int, int) does not initialise milisecond part of created date
> -----------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1363
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1363
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Markus Studer
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>         Attachments: UtilDateTime.diff
>
>
> The public static java.util.Date toDate(int month, int day, int year, int hour, int minute, int second) method does not initialise the milisecond part of the created date predictably (uses the milisecond part of the current system time). This can lead to confusing results when comparing dates as the dates created with this method usually contain a milisecond part.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538572 ]

Adrian Crum commented on OFBIZ-1363:
------------------------------------

Jacques,

I found two places where this method is being used - indirectly through the String argument version of the method. In both cases, initializing milliseconds to zero should not be a problem.

> UtilDateTime.toDate(int, int, int, int, int, int) does not initialise milisecond part of created date
> -----------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1363
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1363
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Markus Studer
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>         Attachments: UtilDateTime.diff
>
>
> The public static java.util.Date toDate(int month, int day, int year, int hour, int minute, int second) method does not initialise the milisecond part of the created date predictably (uses the milisecond part of the current system time). This can lead to confusing results when comparing dates as the dates created with this method usually contain a milisecond part.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1363.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 4.0
                   SVN trunk

Thanks Markus,

Your patch is in trunk revision: 589862 , release 589863

> UtilDateTime.toDate(int, int, int, int, int, int) does not initialise milisecond part of created date
> -----------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1363
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1363
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Markus Studer
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: UtilDateTime.diff
>
>
> The public static java.util.Date toDate(int month, int day, int year, int hour, int minute, int second) method does not initialise the milisecond part of the created date predictably (uses the milisecond part of the current system time). This can lead to confusing results when comparing dates as the dates created with this method usually contain a milisecond part.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[SkipDever]

Create an order to DemoCustCompany for 1 GZ-1001 and 1 WG-1111

Go to Facilities-Shipments and enter 00001 (or the shipment number).  You get this error:

Expression shipment is undefined on line 29, column 10 in component://product/webapp/facility/shipment/ShipmentTabBar.ftl. The problematic instruction: ---------- ==> if shipment.shipmentTypeId?exists && shipment.shipmentTypeId='SALES_SHIPMENT' [on line 29, column 5 in component://product/webapp/facility/shipment/ShipmentTabBar.ftl] ---------- Java backtrace for programmers: ---------- freemarker.core.InvalidReferenceException: Expression shipment is undefined on line 29, column 10 in component://product/webapp/facility/shipment/ShipmentTabBar.ftl. at freemarker.core.TemplateObject.assertNonNull(TemplateObject.java:124) at freemarker.core.TemplateObject.invalidTypeException(TemplateObject.java:134) at freemarker.core.Dot._getAsTemplateModel(Dot.java:78) at freemarker.core.Expression.getAsTemplateModel(Expression.java:89) at freemarker.core.BuiltIn$existsBI._getAsTemplateModel(BuiltIn.java:636) at freemarker.core.BuiltIn$existsBI.isTrue(BuiltIn.java:647) at freemarker.core.AndExpression.isTrue(AndExpression.java:68) at freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:77) at freemarker.core.Environment.visit(Environment.java:196) at freemarker.core.MixedContent.accept(MixedContent.java:92) at freemarker.core.Environment.visit(Environment.java:196) at freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:79) at freemarker.core.Environment.visit(Environment.java:196) at freemarker.core.MixedContent.accept(MixedContent.java:92) at freemarker.core.Environment.visit(Environment.java:196) at freemarker.core.Environment.process(Environment.java:176) at org.ofbiz.base.util.template.FreeMarkerWorker.renderTemplate(FreeMarkerWorker.java:197) at ...

Go back to the order screen for the order you just created and click on "Pack Shipment for Ship group xxxx"
You get this error:
org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://product/widget/facility/ShipmentScreens.xml#PackOrder]: org.ofbiz.base.util.GeneralException: Error running BSH script at location [component://product/webapp/facility/WEB-INF/actions/shipment/PackOrder.bsh]: org.ofbiz.base.util.GeneralException: Error running BSH script at [component://product/webapp/facility/WEB-INF/actions/shipment/PackOrder.bsh], line [139]: Sourced file: component://product/webapp/facility/WEB-INF/actions/shipment/PackOrder.bsh : Method Invocation packSession.getShipmentCostEstimate : at Line: 139 : in file: component://product/webapp/facility/WEB-INF/actions/shipment/PackOrder.bsh : packSession .getShipmentCostEstimate ( orderItemShipGroup , productStoreId , shippableItemInfo , shippableTotal , shippableWeight , shippableQuantity )

With this exception:
java.lang.NullPointerException
        at org.ofbiz.shipment.packing.PackingSession.getShipmentCostEstimate(Pac
kingSession.java:893)
        at org.ofbiz.shipment.packing.PackingSession.getShipmentCostEstimate(Pac
kingSession.java:837)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...

[Scott Gray]

Thanks Skip, I'll have a look.

Scott

On 31/10/2007, skip@theDevers <[hidden email]> wrote:

> Create an order to DemoCustCompany for 1 GZ-1001 and 1 WG-1111
>
> Go to Facilities-Shipments and enter 00001 (or the shipment number).  You get this error:
>
> Expression shipment is undefined on line 29, column 10 in component://product/webapp/facility/shipment/ShipmentTabBar.ftl. The problematic instruction: ---------- ==> if shipment.shipmentTypeId?exists && shipment.shipmentTypeId='SALES_SHIPMENT' [on line 29, column 5 in component://product/webapp/facility/shipment/ShipmentTabBar.ftl] ---------- Java backtrace for programmers: ---------- freemarker.core.InvalidReferenceException: Expression shipment is undefined on line 29, column 10 in component://product/webapp/facility/shipment/ShipmentTabBar.ftl. at freemarker.core.TemplateObject.assertNonNull(TemplateObject.java:124) at freemarker.core.TemplateObject.invalidTypeException(TemplateObject.java:134) at freemarker.core.Dot._getAsTemplateModel(Dot.java:78) at freemarker.core.Expression.getAsTemplateModel(Expression.java:89) at freemarker.core.BuiltIn$existsBI._getAsTemplateModel(BuiltIn.java:636) at freemarker.core.BuiltIn$existsBI.isTrue(BuiltIn.java:647) at freemarker.core.AndExpression.isTrue(AndExpression.java:68) at freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:77) at freemarker.core.Environment.visit(Environment.java:196) at freemarker.core.MixedContent.accept(MixedContent.java:92) at freemarker.core.Environment.visit(Environment.java:196) at freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:79) at freemarker.core.Environment.visit(Environment.java:196) at freemarker.core.MixedContent.accept(MixedContent.java:92) at freemarker.core.Environment.visit(Environment.java:196) at freemarker.core.Environment.process(Environment.java:176) at org.ofbiz.base.util.template.FreeMarkerWorker.renderTemplate(FreeMarkerWorker.java:197) at ...
>
> Go back to the order screen for the order you just created and click on "Pack Shipment for Ship group xxxx"
> You get this error:
> org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://product/widget/facility/ShipmentScreens.xml#PackOrder]: org.ofbiz.base.util.GeneralException: Error running BSH script at location [component://product/webapp/facility/WEB-INF/actions/shipment/PackOrder.bsh]: org.ofbiz.base.util.GeneralException: Error running BSH script at [component://product/webapp/facility/WEB-INF/actions/shipment/PackOrder.bsh], line [139]: Sourced file: component://product/webapp/facility/WEB-INF/actions/shipment/PackOrder.bsh : Method Invocation packSession.getShipmentCostEstimate : at Line: 139 : in file: component://product/webapp/facility/WEB-INF/actions/shipment/PackOrder.bsh : packSession .getShipmentCostEstimate ( orderItemShipGroup , productStoreId , shippableItemInfo , shippableTotal , shippableWeight , shippableQuantity )
>
> With this exception:
> java.lang.NullPointerException
>         at org.ofbiz.shipment.packing.PackingSession.getShipmentCostEstimate(Pac
> kingSession.java:893)
>         at org.ofbiz.shipment.packing.PackingSession.getShipmentCostEstimate(Pac
> kingSession.java:837)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> ...
>
>

[Scott Gray]

Ok got the first problem in rev. 590562, the problem was that "00001"
is not a Shipment Id but the Ship Group Id for the order, but anyway
the screen shouldn't have been crashing when an invalid shipment id is
entered so now it just reverts back to the Find Shipment Screen.

I'll have a look at the second problem shortly.

Scott

On 31/10/2007, Scott Gray <[hidden email]> wrote:

> Thanks Skip, I'll have a look.
>
> Scott
>
> On 31/10/2007, skip@theDevers <[hidden email]> wrote:
> > Create an order to DemoCustCompany for 1 GZ-1001 and 1 WG-1111
> >
> > Go to Facilities-Shipments and enter 00001 (or the shipment number).  You get this error:
> >
> > Expression shipment is undefined on line 29, column 10 in component://product/webapp/facility/shipment/ShipmentTabBar.ftl. The problematic instruction: ---------- ==> if shipment.shipmentTypeId?exists && shipment.shipmentTypeId='SALES_SHIPMENT' [on line 29, column 5 in component://product/webapp/facility/shipment/ShipmentTabBar.ftl] ---------- Java backtrace for programmers: ---------- freemarker.core.InvalidReferenceException: Expression shipment is undefined on line 29, column 10 in component://product/webapp/facility/shipment/ShipmentTabBar.ftl. at freemarker.core.TemplateObject.assertNonNull(TemplateObject.java:124) at freemarker.core.TemplateObject.invalidTypeException(TemplateObject.java:134) at freemarker.core.Dot._getAsTemplateModel(Dot.java:78) at freemarker.core.Expression.getAsTemplateModel(Expression.java:89) at freemarker.core.BuiltIn$existsBI._getAsTemplateModel(BuiltIn.java:636) at freemarker.core.BuiltIn$existsBI.isTrue(BuiltIn.java:647) at freemarker.core.AndExpression.isTrue(AndExpression.java:68) at freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:77) at freemarker.core.Environment.visit(Environment.java:196) at freemarker.core.MixedContent.accept(MixedContent.java:92) at freemarker.core.Environment.visit(Environment.java:196) at freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:79) at freemarker.core.Environment.visit(Environment.java:196) at freemarker.core.MixedContent.accept(MixedContent.java:92) at freemarker.core.Environment.visit(Environment.java:196) at freemarker.core.Environment.process(Environment.java:176) at org.ofbiz.base.util.template.FreeMarkerWorker.renderTemplate(FreeMarkerWorker.java:197) at ...
> >
> > Go back to the order screen for the order you just created and click on "Pack Shipment for Ship group xxxx"
> > You get this error:
> > org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://product/widget/facility/ShipmentScreens.xml#PackOrder]: org.ofbiz.base.util.GeneralException: Error running BSH script at location [component://product/webapp/facility/WEB-INF/actions/shipment/PackOrder.bsh]: org.ofbiz.base.util.GeneralException: Error running BSH script at [component://product/webapp/facility/WEB-INF/actions/shipment/PackOrder.bsh], line [139]: Sourced file: component://product/webapp/facility/WEB-INF/actions/shipment/PackOrder.bsh : Method Invocation packSession.getShipmentCostEstimate : at Line: 139 : in file: component://product/webapp/facility/WEB-INF/actions/shipment/PackOrder.bsh : packSession .getShipmentCostEstimate ( orderItemShipGroup , productStoreId , shippableItemInfo , shippableTotal , shippableWeight , shippableQuantity )
> >
> > With this exception:
> > java.lang.NullPointerException
> >         at org.ofbiz.shipment.packing.PackingSession.getShipmentCostEstimate(Pac
> > kingSession.java:893)
> >         at org.ofbiz.shipment.packing.PackingSession.getShipmentCostEstimate(Pac
> > kingSession.java:837)
> >         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > ...
> >
> >
>

[SkipDever]

This bug is a show-stopper I think.

Create an order for 1 WG-1111 and 5 GZ-1001 to DemoCustCompany on a billing
account (don't know if that makes a difference).

Note that you have 0 ATP and OnHand on the GZ-1001

Complete the order.

On the final screen, note that the order is for $122.91 (before promos tax
and shipping).

It should have been for 18.95, the cost of the single WG-1111.

Your subtotal is for 1 WG-1111 and 4 GZ-1001 (one is credited as an
adjustment)

This should have credit all 5 items that were not in stock instead of the
one.

Skip

[SkipDever]

Dang Scott, I wish I had your experience and skill.  I'd be moving a lot
faster getting my work done on this.

Skip

-----Original Message-----
From: Scott Gray [mailto:[hidden email]]
Sent: Tuesday, October 30, 2007 10:26 PM
To: [hidden email]
Subject: Re: Bugs in the latest trunk


Ok got the first problem in rev. 590562, the problem was that "00001"
is not a Shipment Id but the Ship Group Id for the order, but anyway
the screen shouldn't have been crashing when an invalid shipment id is
entered so now it just reverts back to the Find Shipment Screen.

I'll have a look at the second problem shortly.

Scott

On 31/10/2007, Scott Gray <[hidden email]> wrote:
> Thanks Skip, I'll have a look.
>
> Scott
>
> On 31/10/2007, skip@theDevers <[hidden email]> wrote:
> > Create an order to DemoCustCompany for 1 GZ-1001 and 1 WG-1111
> >
> > Go to Facilities-Shipments and enter 00001 (or the shipment number).
You get this error:
> >
> > Expression shipment is undefined on line 29, column 10 in
component://product/webapp/facility/shipment/ShipmentTabBar.ftl. The
problematic instruction: ---------- ==> if shipment.shipmentTypeId?exists &&
shipment.shipmentTypeId='SALES_SHIPMENT' [on line 29, column 5 in
component://product/webapp/facility/shipment/ShipmentTabBar.ftl] ----------
Java backtrace for programmers: ----------
freemarker.core.InvalidReferenceException: Expression shipment is undefined
on line 29, column 10 in
component://product/webapp/facility/shipment/ShipmentTabBar.ftl. at
freemarker.core.TemplateObject.assertNonNull(TemplateObject.java:124) at
freemarker.core.TemplateObject.invalidTypeException(TemplateObject.java:134)
at freemarker.core.Dot._getAsTemplateModel(Dot.java:78) at
freemarker.core.Expression.getAsTemplateModel(Expression.java:89) at
freemarker.core.BuiltIn$existsBI._getAsTemplateModel(BuiltIn.java:636) at
freemarker.core.BuiltIn$existsBI.isTrue(BuiltIn.java:647) at
freemarker.core.AndExpression.isTrue(AndExpression.java:68) at
freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:77) at
freemarker.core.Environment.visit(Environment.java:196) at
freemarker.core.MixedContent.accept(MixedContent.java:92) at
freemarker.core.Environment.visit(Environment.java:196) at
freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:79) at
freemarker.core.Environment.visit(Environment.java:196) at
freemarker.core.MixedContent.accept(MixedContent.java:92) at
freemarker.core.Environment.visit(Environment.java:196) at
freemarker.core.Environment.process(Environment.java:176) at
org.ofbiz.base.util.template.FreeMarkerWorker.renderTemplate(FreeMarkerWorke
r.java:197) at ...
> >
> > Go back to the order screen for the order you just created and click on
"Pack Shipment for Ship group xxxx"
> > You get this error:
> > org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen
[component://product/widget/facility/ShipmentScreens.xml#PackOrder]:
org.ofbiz.base.util.GeneralException: Error running BSH script at location
[component://product/webapp/facility/WEB-INF/actions/shipment/PackOrder.bsh]
: org.ofbiz.base.util.GeneralException: Error running BSH script at
[component://product/webapp/facility/WEB-INF/actions/shipment/PackOrder.bsh]
, line [139]: Sourced file:
component://product/webapp/facility/WEB-INF/actions/shipment/PackOrder.bsh :
Method Invocation packSession.getShipmentCostEstimate : at Line: 139 : in
file:
component://product/webapp/facility/WEB-INF/actions/shipment/PackOrder.bsh :
packSession .getShipmentCostEstimate ( orderItemShipGroup , productStoreId ,
shippableItemInfo , shippableTotal , shippableWeight , shippableQuantity )
> >
> > With this exception:
> > java.lang.NullPointerException
> >         at
org.ofbiz.shipment.packing.PackingSession.getShipmentCostEstimate(Pac
> > kingSession.java:893)
> >         at
org.ofbiz.shipment.packing.PackingSession.getShipmentCostEstimate(Pac
> > kingSession.java:837)
> >         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > ...
> >
> >
>

[Andrew Zeneski-2]

I don't think your credit is due to the fact it was not in stock, the  
credit was probably a promotion. The inventory settings can be set one  
of two ways:

1. Accept the order, which would place the items not available on back  
order (still charges the full price)
2. Do not accept the order, or rather do not allow out of stock items  
to be added to the cart.

Sounds like you are setup for #1, in which case the only thing I would  
be concerned about is why there was an adjustment for 1 item. This  
could very well have been a promotion, which would solve that issue.


Andrew

On Oct 31, 2007, at 1:38 AM, skip@theDevers wrote:

> This bug is a show-stopper I think.
>
> Create an order for 1 WG-1111 and 5 GZ-1001 to DemoCustCompany on a  
> billing
> account (don't know if that makes a difference).
>
> Note that you have 0 ATP and OnHand on the GZ-1001
>
> Complete the order.
>
> On the final screen, note that the order is for $122.91 (before  
> promos tax
> and shipping).
>
> It should have been for 18.95, the cost of the single WG-1111.
>
> Your subtotal is for 1 WG-1111 and 4 GZ-1001 (one is credited as an
> adjustment)
>
> This should have credit all 5 items that were not in stock instead  
> of the
> one.
>
> Skip
>

[Scott Gray]

Ok second problem fixed in rev. 590578 (was my fault, sorry about that)

Thanks
Scott

On 31/10/2007, skip@theDevers <[hidden email]> wrote:

> Dang Scott, I wish I had your experience and skill.  I'd be moving a lot
> faster getting my work done on this.
>
> Skip
>
> -----Original Message-----
> From: Scott Gray [mailto:[hidden email]]
> Sent: Tuesday, October 30, 2007 10:26 PM
> To: [hidden email]
> Subject: Re: Bugs in the latest trunk
>
>
> Ok got the first problem in rev. 590562, the problem was that "00001"
> is not a Shipment Id but the Ship Group Id for the order, but anyway
> the screen shouldn't have been crashing when an invalid shipment id is
> entered so now it just reverts back to the Find Shipment Screen.
>
> I'll have a look at the second problem shortly.
>
> Scott
>
> On 31/10/2007, Scott Gray <[hidden email]> wrote:
> > Thanks Skip, I'll have a look.
> >
> > Scott
> >
> > On 31/10/2007, skip@theDevers <[hidden email]> wrote:
> > > Create an order to DemoCustCompany for 1 GZ-1001 and 1 WG-1111
> > >
> > > Go to Facilities-Shipments and enter 00001 (or the shipment number).
> You get this error:
> > >
> > > Expression shipment is undefined on line 29, column 10 in
> component://product/webapp/facility/shipment/ShipmentTabBar.ftl. The
> problematic instruction: ---------- ==> if shipment.shipmentTypeId?exists &&
> shipment.shipmentTypeId='SALES_SHIPMENT' [on line 29, column 5 in
> component://product/webapp/facility/shipment/ShipmentTabBar.ftl] ----------
> Java backtrace for programmers: ----------
> freemarker.core.InvalidReferenceException: Expression shipment is undefined
> on line 29, column 10 in
> component://product/webapp/facility/shipment/ShipmentTabBar.ftl. at
> freemarker.core.TemplateObject.assertNonNull(TemplateObject.java:124) at
> freemarker.core.TemplateObject.invalidTypeException(TemplateObject.java:134)
> at freemarker.core.Dot._getAsTemplateModel(Dot.java:78) at
> freemarker.core.Expression.getAsTemplateModel(Expression.java:89) at
> freemarker.core.BuiltIn$existsBI._getAsTemplateModel(BuiltIn.java:636) at
> freemarker.core.BuiltIn$existsBI.isTrue(BuiltIn.java:647) at
> freemarker.core.AndExpression.isTrue(AndExpression.java:68) at
> freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:77) at
> freemarker.core.Environment.visit(Environment.java:196) at
> freemarker.core.MixedContent.accept(MixedContent.java:92) at
> freemarker.core.Environment.visit(Environment.java:196) at
> freemarker.core.ConditionalBlock.accept(ConditionalBlock.java:79) at
> freemarker.core.Environment.visit(Environment.java:196) at
> freemarker.core.MixedContent.accept(MixedContent.java:92) at
> freemarker.core.Environment.visit(Environment.java:196) at
> freemarker.core.Environment.process(Environment.java:176) at
> org.ofbiz.base.util.template.FreeMarkerWorker.renderTemplate(FreeMarkerWorke
> r.java:197) at ...
> > >
> > > Go back to the order screen for the order you just created and click on
> "Pack Shipment for Ship group xxxx"
> > > You get this error:
> > > org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen
> [component://product/widget/facility/ShipmentScreens.xml#PackOrder]:
> org.ofbiz.base.util.GeneralException: Error running BSH script at location
> [component://product/webapp/facility/WEB-INF/actions/shipment/PackOrder.bsh]
> : org.ofbiz.base.util.GeneralException: Error running BSH script at
> [component://product/webapp/facility/WEB-INF/actions/shipment/PackOrder.bsh]
> , line [139]: Sourced file:
> component://product/webapp/facility/WEB-INF/actions/shipment/PackOrder.bsh :
> Method Invocation packSession.getShipmentCostEstimate : at Line: 139 : in
> file:
> component://product/webapp/facility/WEB-INF/actions/shipment/PackOrder.bsh :
> packSession .getShipmentCostEstimate ( orderItemShipGroup , productStoreId ,
> shippableItemInfo , shippableTotal , shippableWeight , shippableQuantity )
> > >
> > > With this exception:
> > > java.lang.NullPointerException
> > >         at
> org.ofbiz.shipment.packing.PackingSession.getShipmentCostEstimate(Pac
> > > kingSession.java:893)
> > >         at
> org.ofbiz.shipment.packing.PackingSession.getShipmentCostEstimate(Pac
> > > kingSession.java:837)
> > >         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > > ...
> > >
> > >
> >
>
>

[SkipDever]

Andrew

This is OOTB setup with run-install for all the demo data and is what I use
for testing the trunk.  There could be a promo for the GZ-1001 in the demo
data.  I'll have to check that out.

Skip

-----Original Message-----
From: Andrew Zeneski [mailto:[hidden email]]
Sent: Tuesday, October 30, 2007 11:18 PM
To: [hidden email]
Subject: Re: Hate to dump this one on you


I don't think your credit is due to the fact it was not in stock, the
credit was probably a promotion. The inventory settings can be set one
of two ways:

1. Accept the order, which would place the items not available on back
order (still charges the full price)
2. Do not accept the order, or rather do not allow out of stock items
to be added to the cart.

Sounds like you are setup for #1, in which case the only thing I would
be concerned about is why there was an adjustment for 1 item. This
could very well have been a promotion, which would solve that issue.


Andrew

On Oct 31, 2007, at 1:38 AM, skip@theDevers wrote:

> This bug is a show-stopper I think.
>
> Create an order for 1 WG-1111 and 5 GZ-1001 to DemoCustCompany on a
> billing
> account (don't know if that makes a difference).
>
> Note that you have 0 ATP and OnHand on the GZ-1001
>
> Complete the order.
>
> On the final screen, note that the order is for $122.91 (before
> promos tax
> and shipping).
>
> It should have been for 18.95, the cost of the single WG-1111.
>
> Your subtotal is for 1 WG-1111 and 4 GZ-1001 (one is credited as an
> adjustment)
>
> This should have credit all 5 items that were not in stock instead
> of the
> one.
>
> Skip
>