OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-1388) Bug in lookup windows URL

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

32 messages Options

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1388) Bug in lookup windows URL

[ https://issues.apache.org/jira/browse/OFBIZ-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549399 ]

Jacques Le Roux commented on OFBIZ-1388:
----------------------------------------

Could this effect (working on a machine not the other) be related to platforms/browsers (I doubt it does but I ask in case) ?

> Bug in lookup windows URL
> -------------------------
>
> Key: OFBIZ-1388
> URL: https://issues.apache.org/jira/browse/OFBIZ-1388
> Project: OFBiz
> Issue Type: Bug
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Bilgin Ibryam
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: JsLookup.patch, lookup.patch
>
>
> Hi all,
> I just noticed a bug in lookup windows url generation.
> One way to generate the bug is this:
> Go to order manager and add to cart configurable pc (PC001). You can do it browsing Configurable PCs category on the left corner.
> After you add PC001 to cart, you will be in order entry screen and your URL should look like this:
> https://localhost:8443/ordermgr/control/additem/product
> At this stage if you try to add another product AND click on the product lookup button, the screen in the lookup window will be orderentry screen but not the product lookup screen!
> Popup screen will not generate LookupProduct request as it is expected, instead the request is "additem/LookupProduct" and then ControlServlet transform it to additem request. You can see that additem is coming from the URL we mentioned /control/additem/product
> Any ideas how to fix this bug?
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1388) Bug in lookup windows URL

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549401 ]

Bilgin Ibryam commented on OFBIZ-1388:
--------------------------------------

Jacques, did you try JsLookup.patch ? Is it working also for you ?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1388) Bug in lookup windows URL

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549411 ]

Jacques Le Roux commented on OFBIZ-1388:
----------------------------------------

Bligin,

Sorry I did not see your comment as I was editing. No, I even did not test as it's not a solution for the quick lookup and it did not work for you.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1388) Bug in lookup windows URL

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549409 ]

Jacques Le Roux commented on OFBIZ-1388:
----------------------------------------

Bilgin,

In the meantime I have commited your change (more as a temporary fx) ni trunk rev. 602099 and release 602101 as I agree (tested) that your solution solves the lookup problem. But I would prefer to commit a change that solves also the quick lookup issue. I still get
The Following Errors Occurred:
No product information passed, not adding anything to cart.

Sorry I have no time to investigate...

I keep the issue open.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1388) Bug in lookup windows URL

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549413 ]

Bilgin Ibryam commented on OFBIZ-1388:
--------------------------------------

Thanks for commit.
Can you explan step byt step, how can i get a "No product information passed, not adding anything to cart. " error ?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1388) Bug in lookup windows URL

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549421 ]

Jacques Le Roux commented on OFBIZ-1388:
----------------------------------------

Same as in your 1st comment but click on quick lookup instead of the lookup button

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1388) Bug in lookup windows URL

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1388:
---------------------------------

Attachment: quicklookup.patch

quicklookup.patch should close the issue

> Bug in lookup windows URL
> -------------------------
>
> Key: OFBIZ-1388
> URL: https://issues.apache.org/jira/browse/OFBIZ-1388
> Project: OFBiz
> Issue Type: Bug
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Bilgin Ibryam
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: JsLookup.patch, lookup.patch, quicklookup.patch
>
>
> Hi all,
> I just noticed a bug in lookup windows url generation.
> One way to generate the bug is this:
> Go to order manager and add to cart configurable pc (PC001). You can do it browsing Configurable PCs category on the left corner.
> After you add PC001 to cart, you will be in order entry screen and your URL should look like this:
> https://localhost:8443/ordermgr/control/additem/product
> At this stage if you try to add another product AND click on the product lookup button, the screen in the lookup window will be orderentry screen but not the product lookup screen!
> Popup screen will not generate LookupProduct request as it is expected, instead the request is "additem/LookupProduct" and then ControlServlet transform it to additem request. You can see that additem is coming from the URL we mentioned /control/additem/product
> Any ideas how to fix this bug?
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1388) Bug in lookup windows URL

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551129 ]

Bilgin Ibryam commented on OFBIZ-1388:
--------------------------------------

BTW should we remove code fragments that are not used anywhere (like quicklookup_popup method in the same file - javascript.ftl:91 ) ? Is there a reason (like later reuse) for keeping them in OFBiz ?

> Bug in lookup windows URL
> -------------------------
>
> Key: OFBIZ-1388
> URL: https://issues.apache.org/jira/browse/OFBIZ-1388
> Project: OFBiz
> Issue Type: Bug
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Bilgin Ibryam
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: JsLookup.patch, lookup.patch, quicklookup.patch
>
>
> Hi all,
> I just noticed a bug in lookup windows url generation.
> One way to generate the bug is this:
> Go to order manager and add to cart configurable pc (PC001). You can do it browsing Configurable PCs category on the left corner.
> After you add PC001 to cart, you will be in order entry screen and your URL should look like this:
> https://localhost:8443/ordermgr/control/additem/product
> At this stage if you try to add another product AND click on the product lookup button, the screen in the lookup window will be orderentry screen but not the product lookup screen!
> Popup screen will not generate LookupProduct request as it is expected, instead the request is "additem/LookupProduct" and then ControlServlet transform it to additem request. You can see that additem is coming from the URL we mentioned /control/additem/product
> Any ideas how to fix this bug?
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1388) Bug in lookup windows URL

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1388:
----------------------------------

Component/s: order
framework

> Bug in lookup windows URL
> -------------------------
>
> Key: OFBIZ-1388
> URL: https://issues.apache.org/jira/browse/OFBIZ-1388
> Project: OFBiz
> Issue Type: Bug
> Components: framework, order
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Bilgin Ibryam
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: JsLookup.patch, lookup.patch, quicklookup.patch
>
>
> Hi all,
> I just noticed a bug in lookup windows url generation.
> One way to generate the bug is this:
> Go to order manager and add to cart configurable pc (PC001). You can do it browsing Configurable PCs category on the left corner.
> After you add PC001 to cart, you will be in order entry screen and your URL should look like this:
> https://localhost:8443/ordermgr/control/additem/product
> At this stage if you try to add another product AND click on the product lookup button, the screen in the lookup window will be orderentry screen but not the product lookup screen!
> Popup screen will not generate LookupProduct request as it is expected, instead the request is "additem/LookupProduct" and then ControlServlet transform it to additem request. You can see that additem is coming from the URL we mentioned /control/additem/product
> Any ideas how to fix this bug?
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-1388) Bug in lookup windows URL

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1388.
----------------------------------

Resolution: Fixed
Fix Version/s: Release Branch 4.0

Thanks Bilgin,

Your patch is in trunk revision: 604597, applications\order\webapp\ordermgr\entry\cart\javascript.ftl does not exist in release

> Bug in lookup windows URL
> -------------------------
>
> Key: OFBIZ-1388
> URL: https://issues.apache.org/jira/browse/OFBIZ-1388
> Project: OFBiz
> Issue Type: Bug
> Components: framework, order
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Bilgin Ibryam
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: JsLookup.patch, lookup.patch, quicklookup.patch
>
>
> Hi all,
> I just noticed a bug in lookup windows url generation.
> One way to generate the bug is this:
> Go to order manager and add to cart configurable pc (PC001). You can do it browsing Configurable PCs category on the left corner.
> After you add PC001 to cart, you will be in order entry screen and your URL should look like this:
> https://localhost:8443/ordermgr/control/additem/product
> At this stage if you try to add another product AND click on the product lookup button, the screen in the lookup window will be orderentry screen but not the product lookup screen!
> Popup screen will not generate LookupProduct request as it is expected, instead the request is "additem/LookupProduct" and then ControlServlet transform it to additem request. You can see that additem is coming from the URL we mentioned /control/additem/product
> Any ideas how to fix this bug?
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1388) Bug in lookup windows URL

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552193 ]

Jacques Le Roux commented on OFBIZ-1388:
----------------------------------------

Sorry Bilgin,

I did not answer to you question

<<BTW should we remove code fragments that are not used anywhere (like quicklookup_popup method in the same file - javascript.ftl:91 ) ? Is there a reason (like later reuse) for keeping them in OFBiz ?>>

Seems that no one knows about that, if you want you can clean it up (I did not look at it).

> Bug in lookup windows URL
> -------------------------
>
> Key: OFBIZ-1388
> URL: https://issues.apache.org/jira/browse/OFBIZ-1388
> Project: OFBiz
> Issue Type: Bug
> Components: framework, order
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Bilgin Ibryam
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: JsLookup.patch, lookup.patch, quicklookup.patch
>
>
> Hi all,
> I just noticed a bug in lookup windows url generation.
> One way to generate the bug is this:
> Go to order manager and add to cart configurable pc (PC001). You can do it browsing Configurable PCs category on the left corner.
> After you add PC001 to cart, you will be in order entry screen and your URL should look like this:
> https://localhost:8443/ordermgr/control/additem/product
> At this stage if you try to add another product AND click on the product lookup button, the screen in the lookup window will be orderentry screen but not the product lookup screen!
> Popup screen will not generate LookupProduct request as it is expected, instead the request is "additem/LookupProduct" and then ControlServlet transform it to additem request. You can see that additem is coming from the URL we mentioned /control/additem/product
> Any ideas how to fix this bug?
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1388) Bug in lookup windows URL

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552549 ]

Bilgin Ibryam commented on OFBIZ-1388:
--------------------------------------

Committed in 4.0 rev. 605015

> Bug in lookup windows URL
> -------------------------
>
> Key: OFBIZ-1388
> URL: https://issues.apache.org/jira/browse/OFBIZ-1388
> Project: OFBiz
> Issue Type: Bug
> Components: framework, order
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Bilgin Ibryam
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: JsLookup.patch, lookup.patch, quicklookup.patch
>
>
> Hi all,
> I just noticed a bug in lookup windows url generation.
> One way to generate the bug is this:
> Go to order manager and add to cart configurable pc (PC001). You can do it browsing Configurable PCs category on the left corner.
> After you add PC001 to cart, you will be in order entry screen and your URL should look like this:
> https://localhost:8443/ordermgr/control/additem/product
> At this stage if you try to add another product AND click on the product lookup button, the screen in the lookup window will be orderentry screen but not the product lookup screen!
> Popup screen will not generate LookupProduct request as it is expected, instead the request is "additem/LookupProduct" and then ControlServlet transform it to additem request. You can see that additem is coming from the URL we mentioned /control/additem/product
> Any ideas how to fix this bug?
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.