[jira] Created: (OFBIZ-1497) Bug in getOrderItemSubTotal method used with RENTAL_ORDER_ITEM

[Nicolas Malin (Jira)]

Bug in getOrderItemSubTotal method used with RENTAL_ORDER_ITEM
--------------------------------------------------------------

                 Key: OFBIZ-1497
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1497
             Project: OFBiz
          Issue Type: Bug
    Affects Versions: SVN trunk
            Reporter: Bilgin Ibryam
            Priority: Minor
             Fix For: SVN trunk


The method: OrderReadHelper.getOrderItemSubTotal(GenericValue orderItem, List adjustments, boolean forTax, boolean forShipping)
 in some situations  is invoked  with GenericValue of type "OrderItemAndShipGroupAssoc" instead of "OrderItem" and this cause NullPointerException.

You can generate the bug by creating a rental product order and then adding an adjustment to this order (adding the adjustment generates NullPointerException).

Bilgin

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1497:
---------------------------------

    Attachment: getOrderItemSubTotal.patch

> Bug in getOrderItemSubTotal method used with RENTAL_ORDER_ITEM
> --------------------------------------------------------------
>
>                 Key: OFBIZ-1497
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1497
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: getOrderItemSubTotal.patch
>
>
> The method: OrderReadHelper.getOrderItemSubTotal(GenericValue orderItem, List adjustments, boolean forTax, boolean forShipping)
>  in some situations  is invoked  with GenericValue of type "OrderItemAndShipGroupAssoc" instead of "OrderItem" and this cause NullPointerException.
> You can generate the bug by creating a rental product order and then adding an adjustment to this order (adding the adjustment generates NullPointerException).
> Bilgin

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1497:
----------------------------------

    Component/s: order

> Bug in getOrderItemSubTotal method used with RENTAL_ORDER_ITEM
> --------------------------------------------------------------
>
>                 Key: OFBIZ-1497
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1497
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: getOrderItemSubTotal.patch
>
>
> The method: OrderReadHelper.getOrderItemSubTotal(GenericValue orderItem, List adjustments, boolean forTax, boolean forShipping)
>  in some situations  is invoked  with GenericValue of type "OrderItemAndShipGroupAssoc" instead of "OrderItem" and this cause NullPointerException.
> You can generate the bug by creating a rental product order and then adding an adjustment to this order (adding the adjustment generates NullPointerException).
> Bilgin

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam reassigned OFBIZ-1497:
------------------------------------

    Assignee: Bilgin Ibryam

> Bug in getOrderItemSubTotal method used with RENTAL_ORDER_ITEM
> --------------------------------------------------------------
>
>                 Key: OFBIZ-1497
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1497
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: getOrderItemSubTotal.patch
>
>
> The method: OrderReadHelper.getOrderItemSubTotal(GenericValue orderItem, List adjustments, boolean forTax, boolean forShipping)
>  in some situations  is invoked  with GenericValue of type "OrderItemAndShipGroupAssoc" instead of "OrderItem" and this cause NullPointerException.
> You can generate the bug by creating a rental product order and then adding an adjustment to this order (adding the adjustment generates NullPointerException).
> Bilgin

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam closed OFBIZ-1497.
--------------------------------

    Resolution: Fixed

Committed in trunk rev. 604420 and 4.0 rev. 604422

> Bug in getOrderItemSubTotal method used with RENTAL_ORDER_ITEM
> --------------------------------------------------------------
>
>                 Key: OFBIZ-1497
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1497
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: getOrderItemSubTotal.patch
>
>
> The method: OrderReadHelper.getOrderItemSubTotal(GenericValue orderItem, List adjustments, boolean forTax, boolean forShipping)
>  in some situations  is invoked  with GenericValue of type "OrderItemAndShipGroupAssoc" instead of "OrderItem" and this cause NullPointerException.
> You can generate the bug by creating a rental product order and then adding an adjustment to this order (adding the adjustment generates NullPointerException).
> Bilgin

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.