[jira] Created: (OFBIZ-1504) New screen to manage the InvoiceItemType entity.

[Nicolas Malin (Jira)]

New screen to manage the InvoiceItemType entity.
------------------------------------------------

                 Key: OFBIZ-1504
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1504
             Project: OFBiz
          Issue Type: Sub-task
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Jacopo Cappellato


This is *not* an organization specific screen, and so it will be accessible from the top menu of the accounting component.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550201 ]

David E. Jones commented on OFBIZ-1504:
---------------------------------------

I may be misunderstanding what this would be for... but do we really want something like this?

The InvoiceItemType entity is populated with seed data, which is usually managed along with the code, and so should go into the XML files and not be user-managed.

> New screen to manage the InvoiceItemType entity.
> ------------------------------------------------
>
>                 Key: OFBIZ-1504
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1504
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Jacopo Cappellato
>
> This is *not* an organization specific screen, and so it will be accessible from the top menu of the accounting component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550317 ]

Jacopo Cappellato commented on OFBIZ-1504:
------------------------------------------

The only reason that induced me to open this task is to give the user the ability to set the InvoiceItemType.glAccountId field, that is the global account id used if no mapping is found in InvoiceItemTypeGlAccount.

> New screen to manage the InvoiceItemType entity.
> ------------------------------------------------
>
>                 Key: OFBIZ-1504
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1504
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Jacopo Cappellato
>
> This is *not* an organization specific screen, and so it will be accessible from the top menu of the accounting component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550334 ]

Jacopo Cappellato commented on OFBIZ-1504:
------------------------------------------

Following a different approach, we could try to get rid (or deprecate) some of the glAccountId set in various entities and centralize them in the GlAccountTypeDefault entity, using the organizationPartyId=_NA_ for global settings, and possibly adding a new field to group together sets of GlAccountTypeDefault records (for example the ones for Inventory Variances or the ones for Invoice Item Types)... or we could just adopt a naming convention for the glAccountTypeId field: this would possibly replace most of the mapping entities, such as CreditCardTypeGlAccount or FinAccountTypeGlAccount or InvoiceItemTypeGlAccount

Jacopo

> New screen to manage the InvoiceItemType entity.
> ------------------------------------------------
>
>                 Key: OFBIZ-1504
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1504
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Jacopo Cappellato
>
> This is *not* an organization specific screen, and so it will be accessible from the top menu of the accounting component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550335 ]

David E. Jones commented on OFBIZ-1504:
---------------------------------------

I think it's fine to leave it there in the data model, but we should probably have a more task-oriented UI for this instead of a general one, and make sure the glAccountId field is not set in the seed data, but rather is in the demo data along with the other accounting stuff (probably with a comment to this effect to in the seed file) to reduce the risk of the glAccountId being reset when the seed data is reloaded after an upgrade (which should always be safe to do completely, ie just reload all seed data). That is an important part of seed data so that it can be updated when code is updated. In other words, seed data always sticks with the code.

> New screen to manage the InvoiceItemType entity.
> ------------------------------------------------
>
>                 Key: OFBIZ-1504
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1504
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Jacopo Cappellato
>
> This is *not* an organization specific screen, and so it will be accessible from the top menu of the accounting component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550336 ]

Jacopo Cappellato commented on OFBIZ-1504:
------------------------------------------

About seed/demo data: yes, in fact yesterday I've worked on this (preparing demo settings for the InvoiceItemType.glAccountId field) and the new data (that I will commit soon) will be in the DemoGlSetup.xml file.

About the specialized screen: yes, you are right about it; is it ok if we change the description of this task to "New screen to manage the default glAccountId for the InvoiceItemType entity."? In the new screen, it will only be possible to update that field... does it make sense or it is still a superfluous task?

> New screen to manage the InvoiceItemType entity.
> ------------------------------------------------
>
>                 Key: OFBIZ-1504
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1504
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Jacopo Cappellato
>
> This is *not* an organization specific screen, and so it will be accessible from the top menu of the accounting component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550339 ]

David E. Jones commented on OFBIZ-1504:
---------------------------------------

I think the task is fine... my concerns are pretty well clarified now. If you'd like to change the name or description that's fine, but probably not necessary (unless it's to communicate with whoever will do this task or something).

> New screen to manage the InvoiceItemType entity.
> ------------------------------------------------
>
>                 Key: OFBIZ-1504
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1504
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Jacopo Cappellato
>
> This is *not* an organization specific screen, and so it will be accessible from the top menu of the accounting component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato updated OFBIZ-1504:
-------------------------------------

    Description:
This is *not* an organization specific screen, and so it will be accessible from the top menu of the accounting component.

In the new screen, it will only be possible to update the glAccountId field of the existing records; adding/removing new records is not allowed, nor updating the other fields of the InvoiceItemType entity.

Also, the name of the top menu should reflect the specialized scope of this screen.


  was:
This is *not* an organization specific screen, and so it will be accessible from the top menu of the accounting component.


        Summary: New screen to manage the default glAccountId for the InvoiceItemType entity.  (was: New screen to manage the InvoiceItemType entity.)

Based on feedback from David (see the other comments in this task).

> New screen to manage the default glAccountId for the InvoiceItemType entity.
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-1504
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1504
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Jacopo Cappellato
>
> This is *not* an organization specific screen, and so it will be accessible from the top menu of the accounting component.
> In the new screen, it will only be possible to update the glAccountId field of the existing records; adding/removing new records is not allowed, nor updating the other fields of the InvoiceItemType entity.
> Also, the name of the top menu should reflect the specialized scope of this screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alok Agnihotri updated OFBIZ-1504:
----------------------------------

    Attachment: jira-issue-1504

Here is the patch for jira-issue-1504
Created UI for InvoiceItemType

> New screen to manage the default glAccountId for the InvoiceItemType entity.
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-1504
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1504
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Jacopo Cappellato
>         Attachments: jira-issue-1504
>
>
> This is *not* an organization specific screen, and so it will be accessible from the top menu of the accounting component.
> In the new screen, it will only be possible to update the glAccountId field of the existing records; adding/removing new records is not allowed, nor updating the other fields of the InvoiceItemType entity.
> Also, the name of the top menu should reflect the specialized scope of this screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551147 ]

Pranay Pandey commented on OFBIZ-1504:
--------------------------------------

Alok,

I think one service is missing which will be updating the records of the entity InvoiceItemType (only one field glAccountId) that is "updateInvoiceItemType".

--
Pranay

> New screen to manage the default glAccountId for the InvoiceItemType entity.
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-1504
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1504
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Jacopo Cappellato
>         Attachments: jira-issue-1504
>
>
> This is *not* an organization specific screen, and so it will be accessible from the top menu of the accounting component.
> In the new screen, it will only be possible to update the glAccountId field of the existing records; adding/removing new records is not allowed, nor updating the other fields of the InvoiceItemType entity.
> Also, the name of the top menu should reflect the specialized scope of this screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pranay Pandey updated OFBIZ-1504:
---------------------------------

    Attachment: jira-issue-1504.patch

Here i am submitting the refectored patch for this issue:

1. Added service for updating the record of InvoiceItemType(Only the field glAccountId).

> New screen to manage the default glAccountId for the InvoiceItemType entity.
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-1504
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1504
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Jacopo Cappellato
>         Attachments: jira-issue-1504, jira-issue-1504.patch
>
>
> This is *not* an organization specific screen, and so it will be accessible from the top menu of the accounting component.
> In the new screen, it will only be possible to update the glAccountId field of the existing records; adding/removing new records is not allowed, nor updating the other fields of the InvoiceItemType entity.
> Also, the name of the top menu should reflect the specialized scope of this screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pranay Pandey updated OFBIZ-1504:
---------------------------------

    Attachment:     (was: jira-issue-1504.patch)

> New screen to manage the default glAccountId for the InvoiceItemType entity.
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-1504
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1504
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Jacopo Cappellato
>         Attachments: jira-issue-1504
>
>
> This is *not* an organization specific screen, and so it will be accessible from the top menu of the accounting component.
> In the new screen, it will only be possible to update the glAccountId field of the existing records; adding/removing new records is not allowed, nor updating the other fields of the InvoiceItemType entity.
> Also, the name of the top menu should reflect the specialized scope of this screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pranay Pandey updated OFBIZ-1504:
---------------------------------

    Attachment: jira-issue-1504.patch

> New screen to manage the default glAccountId for the InvoiceItemType entity.
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-1504
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1504
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Jacopo Cappellato
>         Attachments: jira-issue-1504, jira-issue-1504.patch
>
>
> This is *not* an organization specific screen, and so it will be accessible from the top menu of the accounting component.
> In the new screen, it will only be possible to update the glAccountId field of the existing records; adding/removing new records is not allowed, nor updating the other fields of the InvoiceItemType entity.
> Also, the name of the top menu should reflect the specialized scope of this screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pranay Pandey updated OFBIZ-1504:
---------------------------------

    Attachment: Update_JIRA_1505.patch

Here i am submitting the updated patch for this issue.

--
Pranay

> New screen to manage the default glAccountId for the InvoiceItemType entity.
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-1504
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1504
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Jacopo Cappellato
>         Attachments: jira-issue-1504, jira-issue-1504.patch
>
>
> This is *not* an organization specific screen, and so it will be accessible from the top menu of the accounting component.
> In the new screen, it will only be possible to update the glAccountId field of the existing records; adding/removing new records is not allowed, nor updating the other fields of the InvoiceItemType entity.
> Also, the name of the top menu should reflect the specialized scope of this screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pranay Pandey updated OFBIZ-1504:
---------------------------------

    Attachment:     (was: Update_JIRA_1505.patch)

> New screen to manage the default glAccountId for the InvoiceItemType entity.
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-1504
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1504
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Jacopo Cappellato
>         Attachments: jira-issue-1504, jira-issue-1504.patch
>
>
> This is *not* an organization specific screen, and so it will be accessible from the top menu of the accounting component.
> In the new screen, it will only be possible to update the glAccountId field of the existing records; adding/removing new records is not allowed, nor updating the other fields of the InvoiceItemType entity.
> Also, the name of the top menu should reflect the specialized scope of this screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pranay Pandey updated OFBIZ-1504:
---------------------------------

    Comment: was deleted

> New screen to manage the default glAccountId for the InvoiceItemType entity.
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-1504
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1504
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Jacopo Cappellato
>         Attachments: jira-issue-1504, jira-issue-1504.patch
>
>
> This is *not* an organization specific screen, and so it will be accessible from the top menu of the accounting component.
> In the new screen, it will only be possible to update the glAccountId field of the existing records; adding/removing new records is not allowed, nor updating the other fields of the InvoiceItemType entity.
> Also, the name of the top menu should reflect the specialized scope of this screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pranay Pandey updated OFBIZ-1504:
---------------------------------

    Attachment: jira-issue-1504.patch

Here i am submitting the updated patch for this issue.

--
Pranay

> New screen to manage the default glAccountId for the InvoiceItemType entity.
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-1504
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1504
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Jacopo Cappellato
>         Attachments: jira-issue-1504, jira-issue-1504.patch, jira-issue-1504.patch
>
>
> This is *not* an organization specific screen, and so it will be accessible from the top menu of the accounting component.
> In the new screen, it will only be possible to update the glAccountId field of the existing records; adding/removing new records is not allowed, nor updating the other fields of the InvoiceItemType entity.
> Also, the name of the top menu should reflect the specialized scope of this screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-1504.
--------------------------------------

    Resolution: Fixed

Thanks Alok Agnihotri for the initial patch.
Pranay thanks to you too for your valuable patch.

--
Ashish Vijaywargiya

> New screen to manage the default glAccountId for the InvoiceItemType entity.
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-1504
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1504
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Jacopo Cappellato
>         Attachments: jira-issue-1504, jira-issue-1504.patch, jira-issue-1504.patch
>
>
> This is *not* an organization specific screen, and so it will be accessible from the top menu of the accounting component.
> In the new screen, it will only be possible to update the glAccountId field of the existing records; adding/removing new records is not allowed, nor updating the other fields of the InvoiceItemType entity.
> Also, the name of the top menu should reflect the specialized scope of this screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552560 ]

Ashish Vijaywargiya commented on OFBIZ-1504:
--------------------------------------------

Alok and Pranay your patch is in rev # 605032

--
Ashish Vijaywargiya

> New screen to manage the default glAccountId for the InvoiceItemType entity.
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-1504
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1504
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Jacopo Cappellato
>         Attachments: jira-issue-1504, jira-issue-1504.patch, jira-issue-1504.patch
>
>
> This is *not* an organization specific screen, and so it will be accessible from the top menu of the accounting component.
> In the new screen, it will only be possible to update the glAccountId field of the existing records; adding/removing new records is not allowed, nor updating the other fields of the InvoiceItemType entity.
> Also, the name of the top menu should reflect the specialized scope of this screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.