[jira] Created: (OFBIZ-1572) Product keyword search doesn't search in all child categories (patch)

[Nicolas Malin (Jira)]

Product keyword search doesn't search in all child categories (patch)
---------------------------------------------------------------------

                 Key: OFBIZ-1572
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1572
             Project: OFBiz
          Issue Type: Bug
          Components: product
    Affects Versions: SVN trunk
            Reporter: Wickersheimer Jeremy
             Fix For: SVN trunk


The keyword search doesn't search in the child categories below one level.

I'll attach a patch that get the categories recursively.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-1572:
----------------------------------------

    Attachment: 1572.patch

> Product keyword search doesn't search in all child categories (patch)
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-1572
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1572
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>             Fix For: SVN trunk
>
>         Attachments: 1572.patch
>
>
> The keyword search doesn't search in the child categories below one level.
> I'll attach a patch that get the categories recursively.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557863#action_12557863 ]

Jacques Le Roux commented on OFBIZ-1572:
----------------------------------------

I wonder if this was not done by intention, in case of very deep graph. Maybe we could define a depth in such case anyway...

Anybody an opinion ?

> Product keyword search doesn't search in all child categories (patch)
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-1572
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1572
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>             Fix For: SVN trunk
>
>         Attachments: 1572.patch
>
>
> The keyword search doesn't search in the child categories below one level.
> I'll attach a patch that get the categories recursively.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-1572:
--------------------------------------

    Assignee: Jacques Le Roux

> Product keyword search doesn't search in all child categories (patch)
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-1572
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1572
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: 1572.patch
>
>
> The keyword search doesn't search in the child categories below one level.
> I'll attach a patch that get the categories recursively.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558185#action_12558185 ]

Si Chen commented on OFBIZ-1572:
--------------------------------

I think it's a bug.  If you only show products in the top-level categories, the result is very counterintuitive.

> Product keyword search doesn't search in all child categories (patch)
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-1572
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1572
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: 1572.patch
>
>
> The keyword search doesn't search in the child categories below one level.
> I'll attach a patch that get the categories recursively.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558189#action_12558189 ]

David E. Jones commented on OFBIZ-1572:
---------------------------------------

I agree it is a bug. It should (and originally did...) do a full deep expansion on the category and find all sub categories recursively.

> Product keyword search doesn't search in all child categories (patch)
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-1572
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1572
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: 1572.patch
>
>
> The keyword search doesn't search in the child categories below one level.
> I'll attach a patch that get the categories recursively.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1572.
----------------------------------

    Resolution: Fixed

Thanks Jeremy,

Your patch is in trunk rev. 611372

> Product keyword search doesn't search in all child categories (patch)
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-1572
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1572
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: 1572.patch
>
>
> The keyword search doesn't search in the child categories below one level.
> I'll attach a patch that get the categories recursively.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-1572:
----------------------------------------

    Attachment: 1572-2.patch

There was a slight problem in the previous patch, like all categories show in the catalog application instead of just the first level.
This new patch adds a 'recursive' flag used only for the search, and revert to previous behaviour in other cases.

> Product keyword search doesn't search in all child categories (patch)
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-1572
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1572
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: 1572-2.patch, 1572.patch
>
>
> The keyword search doesn't search in the child categories below one level.
> I'll attach a patch that get the categories recursively.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559468#action_12559468 ]

Jacques Le Roux commented on OFBIZ-1572:
----------------------------------------

Hi Jeremy,

Thanks for the update (actually it was rather practical OOTB ;o) in trunk rev. 612431  

> Product keyword search doesn't search in all child categories (patch)
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-1572
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1572
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: 1572-2.patch, 1572.patch
>
>
> The keyword search doesn't search in the child categories below one level.
> I'll attach a patch that get the categories recursively.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.