[jira] Created: (OFBIZ-1590) Introduction of new reservation entities

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569394#action_12569394 ]

Valentina Sirkova commented on OFBIZ-1590:
------------------------------------------

Here is my second comment.
Hans and community,

I would say the current implementation of OFBiz has the following cons:
 1. Duplication of data:(Workeffort and TechDataCal entities)
 2. Room types are presented as fixedAssets which is not the right way.They are classes!
 3. Numbering problem (room numbers, seat numbers)
 4. We don`t distinguish the people. We don`t have children and adults but just people.
 5. Check availability method works only for dayly reservations.  But we need hourly reservations as well.

The entities that I proposed and described in the wiki are not intended to be realted to Workeffort. If you look at the data model you will see that they are related to Reservation and ReservationItem. Personally I find their logical place in our system in the OrderHeader and OrderItem entities, but correct me if I am wrong.

If Hans chooses to extend Workeffort anyway then this won`t solve many of the cons mentioned above, but even add more as  the logical distinction of WorkEffort and Reservations will be totally lost.

If we extend OrderHeader and OrderItem and commit the entities that i proposed we will get rid of all of the cons 1,2,3,5 and create a base for taking care of 4.

Personally I would be very happy to work with Hans and the community as I myself am involved in a hotel project and more specifically in building its reservation system. I would be happy to provide you with patches in the near future (as near as possible)resoloving all of the cons mentioned above. But I do need your feedback on my ideas as I might be wrong and need advice.....

Thanks for your time :)

> Introduction of new reservation entities
> ----------------------------------------
>
>                 Key: OFBIZ-1590
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1590
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Valentina Sirkova
>         Attachments: accomEntity.patch, accomProgram.patch, spot_class_map_entities.patch, spot_class_map_entities.patch
>
>
> I propose the introduction of the following entities: AccommodationClass, AccommodationSpot,AccommodationMap. Their design is based on the book "The data model resource book".
>  -  AccommodationClass could define classes for hotels, cars, planes etc. I have added one more field here parentAccClass, as I thought it could be valuable for building more complicated hierarchies.
>  -  AccommodationMap is used to say how many spaces a class has. I have extended it further with a field overbooked, which could store the overbooking data for each class. E.g if we have that field we might know how many rooms of class "deluxe" could be overbooked. The primary key of AccommodationMap in the book includes the "NrOfSpaces" field but I did not add it in the patch as I am not sure of its exact purpose.
>  - AccommodationSpot defines the specific seat,room etc of a given class. It is very powerful entity as it let us define the seat as a spot simply. This is very useful for planes and buses for example as we have the chance to define all the seats as spots and are not required to make them fas. I have modified the type of the field "accomNumber" to be of type short-varchar as plane seats for example are mixture of letters and numbers(The book models it of type numeric). The fk fields include the "nrOfSpaces" field in the book which I have not included in my patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569406#action_12569406 ]

Jacopo Cappellato commented on OFBIZ-1590:
------------------------------------------

Valentina,

about your point #2: I agree with you, and this has been discussed in the past, but never implemented.
So it would be great to replace the TechData* entities with WorkEffort (of a special type, to define a standard capacity/availability calendar)

> Introduction of new reservation entities
> ----------------------------------------
>
>                 Key: OFBIZ-1590
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1590
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Valentina Sirkova
>         Attachments: accomEntity.patch, accomProgram.patch, spot_class_map_entities.patch, spot_class_map_entities.patch
>
>
> I propose the introduction of the following entities: AccommodationClass, AccommodationSpot,AccommodationMap. Their design is based on the book "The data model resource book".
>  -  AccommodationClass could define classes for hotels, cars, planes etc. I have added one more field here parentAccClass, as I thought it could be valuable for building more complicated hierarchies.
>  -  AccommodationMap is used to say how many spaces a class has. I have extended it further with a field overbooked, which could store the overbooking data for each class. E.g if we have that field we might know how many rooms of class "deluxe" could be overbooked. The primary key of AccommodationMap in the book includes the "NrOfSpaces" field but I did not add it in the patch as I am not sure of its exact purpose.
>  - AccommodationSpot defines the specific seat,room etc of a given class. It is very powerful entity as it let us define the seat as a spot simply. This is very useful for planes and buses for example as we have the chance to define all the seats as spots and are not required to make them fas. I have modified the type of the field "accomNumber" to be of type short-varchar as plane seats for example are mixture of letters and numbers(The book models it of type numeric). The fk fields include the "nrOfSpaces" field in the book which I have not included in my patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569413#action_12569413 ]

Valentina Sirkova commented on OFBIZ-1590:
------------------------------------------

Thank you very much Jacopo for your comment!

Yes I remember this discussion. Just one clarification-these ideas are based on the book "Data Model Book"  - travel chapter(which i read many, many times :)) and what impressed me there was that Workeffort is not used for rental at all! Also TechCalendars are not used for that purpose!!

Actually the availability of an item could be checked from an entity called "ReservationItem".

The interesting thing is tthis book looks at travel orders as usual orders and therefore we could think of ReservationItem as OrderItem in our system.
This means we will check availability on OrderItem and NOT any of the calendars or WorkEffort.
On the other hand the TechDataCalendars could be used simply for fixedAsset maintenance(e.g room maintanance etc)

I believe in this way we achieve logical distinction of manufacturing, workeffort and rental....What do you think about this Book`s idea?

> Introduction of new reservation entities
> ----------------------------------------
>
>                 Key: OFBIZ-1590
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1590
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Valentina Sirkova
>         Attachments: accomEntity.patch, accomProgram.patch, spot_class_map_entities.patch, spot_class_map_entities.patch
>
>
> I propose the introduction of the following entities: AccommodationClass, AccommodationSpot,AccommodationMap. Their design is based on the book "The data model resource book".
>  -  AccommodationClass could define classes for hotels, cars, planes etc. I have added one more field here parentAccClass, as I thought it could be valuable for building more complicated hierarchies.
>  -  AccommodationMap is used to say how many spaces a class has. I have extended it further with a field overbooked, which could store the overbooking data for each class. E.g if we have that field we might know how many rooms of class "deluxe" could be overbooked. The primary key of AccommodationMap in the book includes the "NrOfSpaces" field but I did not add it in the patch as I am not sure of its exact purpose.
>  - AccommodationSpot defines the specific seat,room etc of a given class. It is very powerful entity as it let us define the seat as a spot simply. This is very useful for planes and buses for example as we have the chance to define all the seats as spots and are not required to make them fas. I have modified the type of the field "accomNumber" to be of type short-varchar as plane seats for example are mixture of letters and numbers(The book models it of type numeric). The fk fields include the "nrOfSpaces" field in the book which I have not included in my patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569385#action_12569385 ]

valentina edited comment on OFBIZ-1590 at 2/15/08 3:38 PM:
-------------------------------------------------------------------

Here is the first comment.

1. You have removed my extended field "overbooked" for storing overbooking data in AccommodationMap. Where do you think of placing it? I did not see it anywhere in the patches.
2. Also I noticed you have not extended ShoppingListItem with spot and map fields.
3.In Spot entity you use nrOfSpaces, while it was suggested to use numberOfSpaces.


      was (Author: valentina):
    Here is the first comment.

1. I do not understand why you have cut the relationship of the AccommodationMap to the AccommodationSpot? What are the reasons for that? I really don`t understand.?
2. You have removed my extended field "overbooked" for storing overbooking data in AccommodationMap. Where do you think of placing it? I did not see it anywhere in the patches.
3. Also I noticed you have not extended ShoppingListItem with spot and map fields.
4. Why do you extend all entities with mapId field??? Isn`t it enough to use the spotId field only?? If you keep these two entities related you just need the spot i guess...
5. In Spot entity you use nrOfSpaces, while it was suggested to use numberOfSpaces.
 

> Introduction of new reservation entities
> ----------------------------------------
>
>                 Key: OFBIZ-1590
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1590
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Valentina Sirkova
>         Attachments: accomEntity.patch, accomProgram.patch, spot_class_map_entities.patch, spot_class_map_entities.patch
>
>
> I propose the introduction of the following entities: AccommodationClass, AccommodationSpot,AccommodationMap. Their design is based on the book "The data model resource book".
>  -  AccommodationClass could define classes for hotels, cars, planes etc. I have added one more field here parentAccClass, as I thought it could be valuable for building more complicated hierarchies.
>  -  AccommodationMap is used to say how many spaces a class has. I have extended it further with a field overbooked, which could store the overbooking data for each class. E.g if we have that field we might know how many rooms of class "deluxe" could be overbooked. The primary key of AccommodationMap in the book includes the "NrOfSpaces" field but I did not add it in the patch as I am not sure of its exact purpose.
>  - AccommodationSpot defines the specific seat,room etc of a given class. It is very powerful entity as it let us define the seat as a spot simply. This is very useful for planes and buses for example as we have the chance to define all the seats as spots and are not required to make them fas. I have modified the type of the field "accomNumber" to be of type short-varchar as plane seats for example are mixture of letters and numbers(The book models it of type numeric). The fk fields include the "nrOfSpaces" field in the book which I have not included in my patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569511#action_12569511 ]

Hans Bakker commented on OFBIZ-1590:
------------------------------------

Valentina,

First of all thank you for the valuable comments and you interest in this development.
As you perhaps know this project is customer driven so development is normally started with a customer request. I am currently working with a customer who wants to receive reservations for a restaurant. The patches I have supplied reflect this and these patches are a working implementation.
So about your comments, first comment:
1. Overbooked field: as long as we have no code yet to use this field can wait until that is available?
2. shopping list: are you sure that reservations will be used in the shopping list? You have a customer who wants to use that?
3. sure, no problem my error, we will change from nrOfSpaces to numberOfSpaces

Your second comment:
1. Duplication of data:(Workeffort and TechDataCal entities): I completly agree with that. If the customer wants to use this facility we will try to change that so it uses workeffort and not techdatacalendar.
2. I agree with that too, although i do not know how to implement that.
3. With this change the seat number problem is solved, and sure we need could use it for room numbers too.
4. I agree, but how to implement?
5. Using the workeffort and not techdata calendar would solve this problem.

Your last comment:
please remember the workeffort is very good for his purpose: it is used for reservations AND for maintenance so a room cannot be booked for maintenance AND reservation.

How about moving forward now, implement the existing 2 patches with the numberOfSpaces field name changed and starting on the other changes?


Regards,
Hans

> Introduction of new reservation entities
> ----------------------------------------
>
>                 Key: OFBIZ-1590
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1590
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Valentina Sirkova
>         Attachments: accomEntity.patch, accomProgram.patch, spot_class_map_entities.patch, spot_class_map_entities.patch
>
>
> I propose the introduction of the following entities: AccommodationClass, AccommodationSpot,AccommodationMap. Their design is based on the book "The data model resource book".
>  -  AccommodationClass could define classes for hotels, cars, planes etc. I have added one more field here parentAccClass, as I thought it could be valuable for building more complicated hierarchies.
>  -  AccommodationMap is used to say how many spaces a class has. I have extended it further with a field overbooked, which could store the overbooking data for each class. E.g if we have that field we might know how many rooms of class "deluxe" could be overbooked. The primary key of AccommodationMap in the book includes the "NrOfSpaces" field but I did not add it in the patch as I am not sure of its exact purpose.
>  - AccommodationSpot defines the specific seat,room etc of a given class. It is very powerful entity as it let us define the seat as a spot simply. This is very useful for planes and buses for example as we have the chance to define all the seats as spots and are not required to make them fas. I have modified the type of the field "accomNumber" to be of type short-varchar as plane seats for example are mixture of letters and numbers(The book models it of type numeric). The fk fields include the "nrOfSpaces" field in the book which I have not included in my patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569518#action_12569518 ]

Valentina Sirkova commented on OFBIZ-1590:
------------------------------------------

Hans, thanks for your fast reply

I guess I have a clearer picture of your vision now.
About presenting the room types as classes-I have idea how that could be implemented. Well for this sort of algorithms we will need to extend the WorkEffort with accommodationClassId field.
About the children and adults, I also have an idea about that and which is almost finished and i get more time will try to discuss it with the community

There are a few more things I do not understand from the patches you provide.
A.) Why do you extend all entities wth map  field? Could you (if you have) provide demo and seed data so we can better understand you way?I dont see the purpose of the map field in the workeffort and other entities.
B) Looking at the WorkEffort entity i see it has most of the fields needed for basing hourly reservation algorithm. However if we (as you agreed) choose to make the room types classes we will need to extend the workeffort with the accommodationClassId field(my implementation which i would like to share is based on that). What do you think about that, are you ok with such idea?

(i hope the answers to these questions(A and B) will clear all ambiguities  i have around your  ideas)
Waiting for your response:Valentina

> Introduction of new reservation entities
> ----------------------------------------
>
>                 Key: OFBIZ-1590
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1590
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Valentina Sirkova
>         Attachments: accomEntity.patch, accomProgram.patch, spot_class_map_entities.patch, spot_class_map_entities.patch
>
>
> I propose the introduction of the following entities: AccommodationClass, AccommodationSpot,AccommodationMap. Their design is based on the book "The data model resource book".
>  -  AccommodationClass could define classes for hotels, cars, planes etc. I have added one more field here parentAccClass, as I thought it could be valuable for building more complicated hierarchies.
>  -  AccommodationMap is used to say how many spaces a class has. I have extended it further with a field overbooked, which could store the overbooking data for each class. E.g if we have that field we might know how many rooms of class "deluxe" could be overbooked. The primary key of AccommodationMap in the book includes the "NrOfSpaces" field but I did not add it in the patch as I am not sure of its exact purpose.
>  - AccommodationSpot defines the specific seat,room etc of a given class. It is very powerful entity as it let us define the seat as a spot simply. This is very useful for planes and buses for example as we have the chance to define all the seats as spots and are not required to make them fas. I have modified the type of the field "accomNumber" to be of type short-varchar as plane seats for example are mixture of letters and numbers(The book models it of type numeric). The fk fields include the "nrOfSpaces" field in the book which I have not included in my patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570093#action_12570093 ]

Hans Bakker commented on OFBIZ-1590:
------------------------------------

Hi Valentina,

here the answers on your last questions:

A. we have implemented the spotId within the mapId in the same way we have an orderId and orderitems.
B. The accomodation Map or Spot already contains the accomodationClassId so there is no need to add that to the workEffort.

I hope this answers all your questions.......In the next few days i will commit the 2 patches so we can move a step forward.

Regards,
Hans

> Introduction of new reservation entities
> ----------------------------------------
>
>                 Key: OFBIZ-1590
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1590
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Valentina Sirkova
>         Attachments: accomEntity.patch, accomProgram.patch, spot_class_map_entities.patch, spot_class_map_entities.patch
>
>
> I propose the introduction of the following entities: AccommodationClass, AccommodationSpot,AccommodationMap. Their design is based on the book "The data model resource book".
>  -  AccommodationClass could define classes for hotels, cars, planes etc. I have added one more field here parentAccClass, as I thought it could be valuable for building more complicated hierarchies.
>  -  AccommodationMap is used to say how many spaces a class has. I have extended it further with a field overbooked, which could store the overbooking data for each class. E.g if we have that field we might know how many rooms of class "deluxe" could be overbooked. The primary key of AccommodationMap in the book includes the "NrOfSpaces" field but I did not add it in the patch as I am not sure of its exact purpose.
>  - AccommodationSpot defines the specific seat,room etc of a given class. It is very powerful entity as it let us define the seat as a spot simply. This is very useful for planes and buses for example as we have the chance to define all the seats as spots and are not required to make them fas. I have modified the type of the field "accomNumber" to be of type short-varchar as plane seats for example are mixture of letters and numbers(The book models it of type numeric). The fk fields include the "nrOfSpaces" field in the book which I have not included in my patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570138#action_12570138 ]

Valentina Sirkova commented on OFBIZ-1590:
------------------------------------------

Hans,
Yes, that is exactly what I thought about the mapId field. And yes it will do the job for accommodationClassId field.
Valentina

> Introduction of new reservation entities
> ----------------------------------------
>
>                 Key: OFBIZ-1590
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1590
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Valentina Sirkova
>         Attachments: accomEntity.patch, accomProgram.patch, spot_class_map_entities.patch, spot_class_map_entities.patch
>
>
> I propose the introduction of the following entities: AccommodationClass, AccommodationSpot,AccommodationMap. Their design is based on the book "The data model resource book".
>  -  AccommodationClass could define classes for hotels, cars, planes etc. I have added one more field here parentAccClass, as I thought it could be valuable for building more complicated hierarchies.
>  -  AccommodationMap is used to say how many spaces a class has. I have extended it further with a field overbooked, which could store the overbooking data for each class. E.g if we have that field we might know how many rooms of class "deluxe" could be overbooked. The primary key of AccommodationMap in the book includes the "NrOfSpaces" field but I did not add it in the patch as I am not sure of its exact purpose.
>  - AccommodationSpot defines the specific seat,room etc of a given class. It is very powerful entity as it let us define the seat as a spot simply. This is very useful for planes and buses for example as we have the chance to define all the seats as spots and are not required to make them fas. I have modified the type of the field "accomNumber" to be of type short-varchar as plane seats for example are mixture of letters and numbers(The book models it of type numeric). The fk fields include the "nrOfSpaces" field in the book which I have not included in my patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker closed OFBIZ-1590.
------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
         Assignee: Hans Bakker

Committed revision 630718

> Introduction of new reservation entities
> ----------------------------------------
>
>                 Key: OFBIZ-1590
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1590
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Valentina Sirkova
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: accomEntity.patch, accomProgram.patch, spot_class_map_entities.patch, spot_class_map_entities.patch
>
>
> I propose the introduction of the following entities: AccommodationClass, AccommodationSpot,AccommodationMap. Their design is based on the book "The data model resource book".
>  -  AccommodationClass could define classes for hotels, cars, planes etc. I have added one more field here parentAccClass, as I thought it could be valuable for building more complicated hierarchies.
>  -  AccommodationMap is used to say how many spaces a class has. I have extended it further with a field overbooked, which could store the overbooking data for each class. E.g if we have that field we might know how many rooms of class "deluxe" could be overbooked. The primary key of AccommodationMap in the book includes the "NrOfSpaces" field but I did not add it in the patch as I am not sure of its exact purpose.
>  - AccommodationSpot defines the specific seat,room etc of a given class. It is very powerful entity as it let us define the seat as a spot simply. This is very useful for planes and buses for example as we have the chance to define all the seats as spots and are not required to make them fas. I have modified the type of the field "accomNumber" to be of type short-varchar as plane seats for example are mixture of letters and numbers(The book models it of type numeric). The fk fields include the "nrOfSpaces" field in the book which I have not included in my patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.