New Styles For Framework applications
------------------------------------- Key: OFBIZ-1619 URL: https://issues.apache.org/jira/browse/OFBIZ-1619 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Marco Risaliti Assignee: Marco Risaliti Priority: Minor Fix For: SVN trunk Apply the new CSS styles to all the forms into the Framework applications (Example, Example Ext, Webtools) and we will have the same look and feel on the ftl screens and screen widgets -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[ https://issues.apache.org/jira/browse/OFBIZ-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti updated OFBIZ-1619: ---------------------------------- Attachment: new_framework_styles1.patch First patch for the new style to most of the Webtools forms, still missing some Entity/Workflow forms to be migrated. Can please some committer with framework privilege review this big patch ? Thanks Marco > New Styles For Framework applications > ------------------------------------- > > Key: OFBIZ-1619 > URL: https://issues.apache.org/jira/browse/OFBIZ-1619 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: new_framework_styles1.patch > > > Apply the new CSS styles to all the forms into the Framework applications (Example, Example Ext, Webtools) and we will have the same look and feel on the ftl screens and screen widgets -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566390#action_12566390 ] Adrian Crum commented on OFBIZ-1619: ------------------------------------ Marco, Don't worry too much about Workflow. I don't think it is being used or maintained. > New Styles For Framework applications > ------------------------------------- > > Key: OFBIZ-1619 > URL: https://issues.apache.org/jira/browse/OFBIZ-1619 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: new_framework_styles1.patch > > > Apply the new CSS styles to all the forms into the Framework applications (Example, Example Ext, Webtools) and we will have the same look and feel on the ftl screens and screen widgets -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Geisert reassigned OFBIZ-1619: ---------------------------------------- Assignee: Christian Geisert (was: Marco Risaliti) > New Styles For Framework applications > ------------------------------------- > > Key: OFBIZ-1619 > URL: https://issues.apache.org/jira/browse/OFBIZ-1619 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Christian Geisert > Priority: Minor > Fix For: SVN trunk > > Attachments: new_framework_styles1.patch > > > Apply the new CSS styles to all the forms into the Framework applications (Example, Example Ext, Webtools) and we will have the same look and feel on the ftl screens and screen widgets -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-1619: ----------------------------------- Attachment: new_framework_styles1.patch Some "\ " cleaning in labels names and values > New Styles For Framework applications > ------------------------------------- > > Key: OFBIZ-1619 > URL: https://issues.apache.org/jira/browse/OFBIZ-1619 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Christian Geisert > Priority: Minor > Fix For: SVN trunk > > Attachments: new_framework_styles1.patch , new_framework_styles1.patch > > > Apply the new CSS styles to all the forms into the Framework applications (Example, Example Ext, Webtools) and we will have the same look and feel on the ftl screens and screen widgets -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569894#action_12569894 ] Christian Geisert commented on OFBIZ-1619: ------------------------------------------ Jacques, I'm a bit confused about your updated patch ;-) CommonUiLabels has been already converted to xml (including Marco's changes) so you should make your changes in CommonUiLabels.xml And we shouldn't work both on this patch... > New Styles For Framework applications > ------------------------------------- > > Key: OFBIZ-1619 > URL: https://issues.apache.org/jira/browse/OFBIZ-1619 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Christian Geisert > Priority: Minor > Fix For: SVN trunk > > Attachments: new_framework_styles1.patch , new_framework_styles1.patch > > > Apply the new CSS styles to all the forms into the Framework applications (Example, Example Ext, Webtools) and we will have the same look and feel on the ftl screens and screen widgets -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569911#action_12569911 ] Jacques Le Roux commented on OFBIZ-1619: ---------------------------------------- Christian, Ooops, I quickly reviewed it when I saw your post on dev ML. I thought it could be interesting to put some obvious error I found, but you are right, simply forget it. > New Styles For Framework applications > ------------------------------------- > > Key: OFBIZ-1619 > URL: https://issues.apache.org/jira/browse/OFBIZ-1619 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Christian Geisert > Priority: Minor > Fix For: SVN trunk > > Attachments: new_framework_styles1.patch , new_framework_styles1.patch > > > Apply the new CSS styles to all the forms into the Framework applications (Example, Example Ext, Webtools) and we will have the same look and feel on the ftl screens and screen widgets -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569953#action_12569953 ] Christian Geisert commented on OFBIZ-1619: ------------------------------------------ Applied, except framework/webtools/webapp/webtools/entity/FindGeneric.ftl because of the following error (strange...): patching file framework/webtools/webapp/webtools/entity/ViewGeneric.ftl Hunk #2 FAILED at 27. 1 out of 2 hunks FAILED -- saving rejects to file framework/webtools/webapp/webtools/entity/ViewGeneric.ftl.rej patching file framework/webtools/webapp/webtools/entity/FindGeneric.ftl patch unexpectedly ends in middle of line patch: **** malformed patch at line 3068: Marco, could you please send again a patch for this file The following files produced also errors but I merged them manually : framework/webtools/widget/ServiceScreens.xml framework/webtools/widget/LogScreens.xml framework/webtools/webapp/webtools/period/EditCustomTimePeriod.ftl framework/webtools/webapp/webtools/service/availableservices.ftl > New Styles For Framework applications > ------------------------------------- > > Key: OFBIZ-1619 > URL: https://issues.apache.org/jira/browse/OFBIZ-1619 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Christian Geisert > Priority: Minor > Fix For: SVN trunk > > Attachments: new_framework_styles1.patch , new_framework_styles1.patch > > > Apply the new CSS styles to all the forms into the Framework applications (Example, Example Ext, Webtools) and we will have the same look and feel on the ftl screens and screen widgets -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti updated OFBIZ-1619: ---------------------------------- Attachment: new_framework_styles2.patch Hi Christian, this is the patch after solving some svn conflicts. Thanks Marco > New Styles For Framework applications > ------------------------------------- > > Key: OFBIZ-1619 > URL: https://issues.apache.org/jira/browse/OFBIZ-1619 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Christian Geisert > Priority: Minor > Fix For: SVN trunk > > Attachments: new_framework_styles1.patch , new_framework_styles1.patch, new_framework_styles2.patch > > > Apply the new CSS styles to all the forms into the Framework applications (Example, Example Ext, Webtools) and we will have the same look and feel on the ftl screens and screen widgets -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570171#action_12570171 ] Marco Risaliti commented on OFBIZ-1619: --------------------------------------- Hi Christian, could you please this issue open after review/commit the second patch because something more has to be done. Thanks Marco > New Styles For Framework applications > ------------------------------------- > > Key: OFBIZ-1619 > URL: https://issues.apache.org/jira/browse/OFBIZ-1619 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Christian Geisert > Priority: Minor > Fix For: SVN trunk > > Attachments: new_framework_styles1.patch , new_framework_styles1.patch, new_framework_styles2.patch > > > Apply the new CSS styles to all the forms into the Framework applications (Example, Example Ext, Webtools) and we will have the same look and feel on the ftl screens and screen widgets -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570309#action_12570309 ] Christian Geisert commented on OFBIZ-1619: ------------------------------------------ Second patch applied Keep up the good work Marco! > New Styles For Framework applications > ------------------------------------- > > Key: OFBIZ-1619 > URL: https://issues.apache.org/jira/browse/OFBIZ-1619 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Christian Geisert > Priority: Minor > Fix For: SVN trunk > > Attachments: new_framework_styles1.patch , new_framework_styles1.patch, new_framework_styles2.patch > > > Apply the new CSS styles to all the forms into the Framework applications (Example, Example Ext, Webtools) and we will have the same look and feel on the ftl screens and screen widgets -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570323#action_12570323 ] Adrian Crum commented on OFBIZ-1619: ------------------------------------ One of the things I'm beginning to notice about these patches is that they do more than update the styles - they are also changing the layout. The last commit included files that had already been updated to the new styles, so they really didn't need to be changed. > New Styles For Framework applications > ------------------------------------- > > Key: OFBIZ-1619 > URL: https://issues.apache.org/jira/browse/OFBIZ-1619 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Christian Geisert > Priority: Minor > Fix For: SVN trunk > > Attachments: new_framework_styles1.patch , new_framework_styles1.patch, new_framework_styles2.patch > > > Apply the new CSS styles to all the forms into the Framework applications (Example, Example Ext, Webtools) and we will have the same look and feel on the ftl screens and screen widgets -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti updated OFBIZ-1619: ---------------------------------- Attachment: new_framework_styles3.patch Hi Adrian, this confusion into webtools application is due to the changes from head3 to h3 style that was not included into an old patch that still had head3. So now I have convert again all the head3 to h3 and now seams to me better. Please take a look at it and let me know if it's now ok. Thanks Marco > New Styles For Framework applications > ------------------------------------- > > Key: OFBIZ-1619 > URL: https://issues.apache.org/jira/browse/OFBIZ-1619 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Christian Geisert > Priority: Minor > Fix For: SVN trunk > > Attachments: new_framework_styles1.patch , new_framework_styles1.patch, new_framework_styles2.patch , new_framework_styles3.patch > > > Apply the new CSS styles to all the forms into the Framework applications (Example, Example Ext, Webtools) and we will have the same look and feel on the ftl screens and screen widgets -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572252#action_12572252 ] Adrian Crum commented on OFBIZ-1619: ------------------------------------ Marco, Converting head3 to h3 is fine. It's changing the layout that puzzles me. Page titles that used to stand alone on the page in the h1 style have been moved to screenlet title bars, and screenlets have been added where they weren't really needed. All that was necessary in this effort (as far as I knew) was to replace or remove deprecated styles. > New Styles For Framework applications > ------------------------------------- > > Key: OFBIZ-1619 > URL: https://issues.apache.org/jira/browse/OFBIZ-1619 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Christian Geisert > Priority: Minor > Fix For: SVN trunk > > Attachments: new_framework_styles1.patch , new_framework_styles1.patch, new_framework_styles2.patch , new_framework_styles3.patch > > > Apply the new CSS styles to all the forms into the Framework applications (Example, Example Ext, Webtools) and we will have the same look and feel on the ftl screens and screen widgets -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575673#action_12575673 ] Marco Risaliti commented on OFBIZ-1619: --------------------------------------- Patch new_framework_styles3.patch is still to be review and committed to avoid the actual confusion into webtools application. Thanks Marco > New Styles For Framework applications > ------------------------------------- > > Key: OFBIZ-1619 > URL: https://issues.apache.org/jira/browse/OFBIZ-1619 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Christian Geisert > Priority: Minor > Fix For: SVN trunk > > Attachments: new_framework_styles1.patch , new_framework_styles1.patch, new_framework_styles2.patch , new_framework_styles3.patch > > > Apply the new CSS styles to all the forms into the Framework applications (Example, Example Ext, Webtools) and we will have the same look and feel on the ftl screens and screen widgets -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575712#action_12575712 ] Jacques Le Roux commented on OFBIZ-1619: ---------------------------------------- I look at it... > New Styles For Framework applications > ------------------------------------- > > Key: OFBIZ-1619 > URL: https://issues.apache.org/jira/browse/OFBIZ-1619 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Christian Geisert > Priority: Minor > Fix For: SVN trunk > > Attachments: new_framework_styles1.patch , new_framework_styles1.patch, new_framework_styles2.patch , new_framework_styles3.patch > > > Apply the new CSS styles to all the forms into the Framework applications (Example, Example Ext, Webtools) and we will have the same look and feel on the ftl screens and screen widgets -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575720#action_12575720 ] Jacques Le Roux commented on OFBIZ-1619: ---------------------------------------- Removed some tabs. I'm not sure I like it, notably the https://localhost:8443/webtools/control/EntitySyncStatus screen. Why the title ("Entity Sync Status") and the table grid are removed in this screen ? > New Styles For Framework applications > ------------------------------------- > > Key: OFBIZ-1619 > URL: https://issues.apache.org/jira/browse/OFBIZ-1619 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Christian Geisert > Priority: Minor > Fix For: SVN trunk > > Attachments: new_framework_styles1.patch , new_framework_styles1.patch, new_framework_styles2.patch , new_framework_styles3.patch > > > Apply the new CSS styles to all the forms into the Framework applications (Example, Example Ext, Webtools) and we will have the same look and feel on the ftl screens and screen widgets -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575766#action_12575766 ] Jacques Le Roux commented on OFBIZ-1619: ---------------------------------------- OK, for the grid removed, common behaviour > New Styles For Framework applications > ------------------------------------- > > Key: OFBIZ-1619 > URL: https://issues.apache.org/jira/browse/OFBIZ-1619 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Christian Geisert > Priority: Minor > Fix For: SVN trunk > > Attachments: new_framework_styles1.patch , new_framework_styles1.patch, new_framework_styles2.patch , new_framework_styles3.patch > > > Apply the new CSS styles to all the forms into the Framework applications (Example, Example Ext, Webtools) and we will have the same look and feel on the ftl screens and screen widgets -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575842#action_12575842 ] Marco Risaliti commented on OFBIZ-1619: --------------------------------------- Hi Jacques, In this patch you can find simply the same layout I have made on all the backend applications. I have changed some style from head3 to h3 that is not more available into main.css. Thanks Marco > New Styles For Framework applications > ------------------------------------- > > Key: OFBIZ-1619 > URL: https://issues.apache.org/jira/browse/OFBIZ-1619 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Christian Geisert > Priority: Minor > Fix For: SVN trunk > > Attachments: new_framework_styles1.patch , new_framework_styles1.patch, new_framework_styles2.patch , new_framework_styles3.patch > > > Apply the new CSS styles to all the forms into the Framework applications (Example, Example Ext, Webtools) and we will have the same look and feel on the ftl screens and screen widgets -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575865#action_12575865 ] Jacques Le Roux commented on OFBIZ-1619: ---------------------------------------- Marco, You mean that removing the sub-title "Entity Sync Status" is intentionnal in that screen ? Look at EntitySyncScreens.xml in your patch. You will see also some unwanted tabs in it (only this file has tabs in it). Morevover this file is unmergeable (either with Tortoise or patch). Please check it, thanks. > New Styles For Framework applications > ------------------------------------- > > Key: OFBIZ-1619 > URL: https://issues.apache.org/jira/browse/OFBIZ-1619 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Christian Geisert > Priority: Minor > Fix For: SVN trunk > > Attachments: new_framework_styles1.patch , new_framework_styles1.patch, new_framework_styles2.patch , new_framework_styles3.patch > > > Apply the new CSS styles to all the forms into the Framework applications (Example, Example Ext, Webtools) and we will have the same look and feel on the ftl screens and screen widgets -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Free forum by Nabble | Edit this page |