OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-165) ProductionRunDeclaration.bsh not checking for null

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 5 messages Options
Nicolas Malin (Jira)
Reply | Threaded
Open this post in threaded view
♦
♦
|

[jira] Created: (OFBIZ-165) ProductionRunDeclaration.bsh not checking for null

Nicolas Malin (Jira)
ProductionRunDeclaration.bsh not checking for null
--------------------------------------------------

                 Key: OFBIZ-165
                 URL: http://issues.apache.org/jira/browse/OFBIZ-165
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: manufacturing
    Affects Versions: SVN trunk
            Reporter: Scott Gray
            Priority: Minor
         Attachments: ofbiz.log

The attached log has the details, but basically if estimatedSetupMillis or estimatedMilliSeconds are null then calling toString on the Double fails (lines 132 & 133).  I would attach a patch but I'm not sure what the best approach is, we could switch from getDouble(value).toString() to getString(value) or just check for null first or possibly ensure that a null becomes a 0 when the routingTask is created?

Regards
Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Nicolas Malin (Jira)
Reply | Threaded
Open this post in threaded view
♦
♦
|

[jira] Assigned: (OFBIZ-165) ProductionRunDeclaration.bsh not checking for null

Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-165?page=all ]

Jacopo Cappellato reassigned OFBIZ-165:
---------------------------------------

    Assignee: Jacopo Cappellato

> ProductionRunDeclaration.bsh not checking for null
> --------------------------------------------------
>
>                 Key: OFBIZ-165
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-165
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: manufacturing
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: ofbiz.log
>
>
> The attached log has the details, but basically if estimatedSetupMillis or estimatedMilliSeconds are null then calling toString on the Double fails (lines 132 & 133).  I would attach a patch but I'm not sure what the best approach is, we could switch from getDouble(value).toString() to getString(value) or just check for null first or possibly ensure that a null becomes a 0 when the routingTask is created?
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Nicolas Malin (Jira)
Reply | Threaded
Open this post in threaded view
♦
♦
|

[jira] Resolved: (OFBIZ-165) ProductionRunDeclaration.bsh not checking for null

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-165?page=all ]

Jacopo Cappellato resolved OFBIZ-165.
-------------------------------------

    Resolution: Fixed

Scott,

yeah the code there is awful and sooner or later I'll have to clean it a bit.
It should be fixed now (rev.432535); please let me know if it's not ok.

Thanks

> ProductionRunDeclaration.bsh not checking for null
> --------------------------------------------------
>
>                 Key: OFBIZ-165
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-165
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: manufacturing
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: ofbiz.log
>
>
> The attached log has the details, but basically if estimatedSetupMillis or estimatedMilliSeconds are null then calling toString on the Double fails (lines 132 & 133).  I would attach a patch but I'm not sure what the best approach is, we could switch from getDouble(value).toString() to getString(value) or just check for null first or possibly ensure that a null becomes a 0 when the routingTask is created?
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Nicolas Malin (Jira)
Reply | Threaded
Open this post in threaded view
♦
♦
|

[jira] Commented: (OFBIZ-165) ProductionRunDeclaration.bsh not checking for null

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-165?page=comments#action_12428958 ]
           
Scott Gray commented on OFBIZ-165:
----------------------------------

Looks good to me
Thanks

> ProductionRunDeclaration.bsh not checking for null
> --------------------------------------------------
>
>                 Key: OFBIZ-165
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-165
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: manufacturing
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: ofbiz.log
>
>
> The attached log has the details, but basically if estimatedSetupMillis or estimatedMilliSeconds are null then calling toString on the Double fails (lines 132 & 133).  I would attach a patch but I'm not sure what the best approach is, we could switch from getDouble(value).toString() to getString(value) or just check for null first or possibly ensure that a null becomes a 0 when the routingTask is created?
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Nicolas Malin (Jira)
Reply | Threaded
Open this post in threaded view
♦
♦
|

[jira] Closed: (OFBIZ-165) ProductionRunDeclaration.bsh not checking for null

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-165?page=all ]

Jacopo Cappellato closed OFBIZ-165.
-----------------------------------


> ProductionRunDeclaration.bsh not checking for null
> --------------------------------------------------
>
>                 Key: OFBIZ-165
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-165
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: manufacturing
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: ofbiz.log
>
>
> The attached log has the details, but basically if estimatedSetupMillis or estimatedMilliSeconds are null then calling toString on the Double fails (lines 132 & 133).  I would attach a patch but I'm not sure what the best approach is, we could switch from getDouble(value).toString() to getString(value) or just check for null first or possibly ensure that a null becomes a 0 when the routingTask is created?
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Free forum by Nabble Edit this page