[jira] Created: (OFBIZ-1684) Split Pay Pref Per Shp Grp incorrectly calculates max amounts for Payment Preferences

[Nicolas Malin (Jira)]

Split Pay Pref Per Shp Grp incorrectly calculates max amounts for Payment Preferences
-------------------------------------------------------------------------------------

                 Key: OFBIZ-1684
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1684
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: SVN trunk
            Reporter: Scott Gray


When creating an order, if the Product Store option "Split Pay Pref Per Shp Grp" is set to "Y" (which is the default), then taxes are not taken into account when calculating the max amount for a payment preference.

This results in a credit card auth (for example) of (grand total - tax)  for the order.

Steps to reproduce:
1. Customer = DemoCustomer
2. Products = 5 x GZ-1000
3. Shipping = UPS Air
4. Payment Method = Credit Card

The order total will be for $65.65 but the credit card will only be authed for $62.56

I don't have time to fix this myself so I've posted it here.
Anyone wanting a work around for this bug can just set "Split Pay Pref Per Shp Grp" to "N" on their product store.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595432#action_12595432 ]

Bilgin Ibryam commented on OFBIZ-1684:
--------------------------------------

Hi Scott,

I committed a fix in rev. 654657  and I think the bug is fixed, can you confirm that.
Thanks for the report.

Bilgin

> Split Pay Pref Per Shp Grp incorrectly calculates max amounts for Payment Preferences
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1684
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1684
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>
> When creating an order, if the Product Store option "Split Pay Pref Per Shp Grp" is set to "Y" (which is the default), then taxes are not taken into account when calculating the max amount for a payment preference.
> This results in a credit card auth (for example) of (grand total - tax)  for the order.
> Steps to reproduce:
> 1. Customer = DemoCustomer
> 2. Products = 5 x GZ-1000
> 3. Shipping = UPS Air
> 4. Payment Method = Credit Card
> The order total will be for $65.65 but the credit card will only be authed for $62.56
> I don't have time to fix this myself so I've posted it here.
> Anyone wanting a work around for this bug can just set "Split Pay Pref Per Shp Grp" to "N" on their product store.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray closed OFBIZ-1684.
-----------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Hi Bilgin

Thanks for taking care of this, I haven't had a chance to test it but the code looks straight forward enough.  

My only concern is that when this feature is used tax will be prematurely rounded at the ship group level rather than the order total which could result in rounding errors.  I'm not too worried though as I can't really see the point of this feature when placing two orders would achieve the same result without the hassle.

> Split Pay Pref Per Shp Grp incorrectly calculates max amounts for Payment Preferences
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1684
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1684
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>             Fix For: SVN trunk
>
>
> When creating an order, if the Product Store option "Split Pay Pref Per Shp Grp" is set to "Y" (which is the default), then taxes are not taken into account when calculating the max amount for a payment preference.
> This results in a credit card auth (for example) of (grand total - tax)  for the order.
> Steps to reproduce:
> 1. Customer = DemoCustomer
> 2. Products = 5 x GZ-1000
> 3. Shipping = UPS Air
> 4. Payment Method = Credit Card
> The order total will be for $65.65 but the credit card will only be authed for $62.56
> I don't have time to fix this myself so I've posted it here.
> Anyone wanting a work around for this bug can just set "Split Pay Pref Per Shp Grp" to "N" on their product store.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.