OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-1690) Set widget default url encode value to true

_‹ Previous Topic Next Topic _›

Classic

List

7 messages Options

Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-1690) Set widget default url encode value to true

Set widget default url encode value to true
-------------------------------------------

Key: OFBIZ-1690
URL: https://issues.apache.org/jira/browse/OFBIZ-1690
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk, Release Branch 4.0
Reporter: Bilgin Ibryam
Priority: Minor
Fix For: SVN trunk, Release Branch 4.0
Attachments: encode.patch

The bug is explained here: http://www.nabble.com/Question-about-ofbiz-url-encoding-to15638660.html#a15638660
Can someone with framework access commit it please.

Thanks,
Bilgin

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1690) Set widget default url encode value to true

[ https://issues.apache.org/jira/browse/OFBIZ-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1690:
---------------------------------

Attachment: encode.patch

> Set widget default url encode value to true
> -------------------------------------------
>
> Key: OFBIZ-1690
> URL: https://issues.apache.org/jira/browse/OFBIZ-1690
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: encode.patch
>
>
> The bug is explained here: http://www.nabble.com/Question-about-ofbiz-url-encoding-to15638660.html#a15638660
> Can someone with framework access commit it please.
> Thanks,
> Bilgin

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1690) Set widget default url encode value to true

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574795#action_12574795 ]

Adrian Crum commented on OFBIZ-1690:
------------------------------------

Bilgin,

I'd like to hear more comments on the subject. Your patch only changes the default in the widget's xsd, it doesn't address the scenario where the xsd is not available. To handle that case, the model widgets would have to default the setting to true also. That could break a lot of existing code.

> Set widget default url encode value to true
> -------------------------------------------
>
> Key: OFBIZ-1690
> URL: https://issues.apache.org/jira/browse/OFBIZ-1690
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: encode.patch
>
>
> The bug is explained here: http://www.nabble.com/Question-about-ofbiz-url-encoding-to15638660.html#a15638660
> Can someone with framework access commit it please.
> Thanks,
> Bilgin

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1690) Set widget default url encode value to true

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1690:
---------------------------------

Attachment: encode.patch

> Set widget default url encode value to true
> -------------------------------------------
>
> Key: OFBIZ-1690
> URL: https://issues.apache.org/jira/browse/OFBIZ-1690
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: encode.patch, encode.patch
>
>
> The bug is explained here: http://www.nabble.com/Question-about-ofbiz-url-encoding-to15638660.html#a15638660
> Can someone with framework access commit it please.
> Thanks,
> Bilgin

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1690) Set widget default url encode value to true

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574877#action_12574877 ]

Bilgin Ibryam commented on OFBIZ-1690:
--------------------------------------

Adrian,

I updated the patch according to your remarks.
Can you tell me what kind of existing code this patch could break?

Thanks for your review and comments!

> Set widget default url encode value to true
> -------------------------------------------
>
> Key: OFBIZ-1690
> URL: https://issues.apache.org/jira/browse/OFBIZ-1690
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: encode.patch, encode.patch
>
>
> The bug is explained here: http://www.nabble.com/Question-about-ofbiz-url-encoding-to15638660.html#a15638660
> Can someone with framework access commit it please.
> Thanks,
> Bilgin

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1690) Set widget default url encode value to true

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575036#action_12575036 ]

Adrian Crum commented on OFBIZ-1690:
------------------------------------

Bilgin,

My concern is with external links - will the jsessionid parameter get appended to them also.

> Set widget default url encode value to true
> -------------------------------------------
>
> Key: OFBIZ-1690
> URL: https://issues.apache.org/jira/browse/OFBIZ-1690
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: encode.patch, encode.patch
>
>
> The bug is explained here: http://www.nabble.com/Question-about-ofbiz-url-encoding-to15638660.html#a15638660
> Can someone with framework access commit it please.
> Thanks,
> Bilgin

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1690) Set widget default url encode value to true

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575957#action_12575957 ]

Bilgin Ibryam commented on OFBIZ-1690:
--------------------------------------

Adrian you are right,
but setting encode attribute to false for external links should solve this issue?

> Set widget default url encode value to true
> -------------------------------------------
>
> Key: OFBIZ-1690
> URL: https://issues.apache.org/jira/browse/OFBIZ-1690
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: encode.patch, encode.patch
>
>
> The bug is explained here: http://www.nabble.com/Question-about-ofbiz-url-encoding-to15638660.html#a15638660
> Can someone with framework access commit it please.
> Thanks,
> Bilgin

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.